llvm dev - Aug 2015 - Code owner for the scalarizer

I think the people that have been in there the most are Hal and Chandler of
late with a few others here and there.

-eric

On Wed, Aug 19, 2015 at 10:30 AM Chris Lattner via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
>
> > On Aug 19, 2015, at 9:50 AM, Hans Wennborg <hans at
chromium.org> wrote:
> >
> > We should find a code owner for the scalarizer
> > (lib/Transforms/Scalar/Scalarizer.cpp).
> >
> > I nominate Richard Sandiford, who added it in r195471.
> >
> > Let me know what you think.
>
> I think it would make sense to look for someone a bit more granular, even
> though it’s a harder problem: it would be great to find an owner for the
> mid-level optimizer, including scalar,IPA,IPO, and perhaps the loop xforms.
>
> -Chris
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150819/e17c0e2e/attachment.html>

Having an owner for the whole mid-level optimizer would be great, if
there's someone who's up for it.

I still think finer-grained ownership is valuable, though, as such
owners would be likely to be more familiar with the details in the
code, and it also reduces the risk of overloading the high-level
owner.

On Wed, Aug 19, 2015 at 11:04 AM, Eric Christopher <echristo at gmail.com>
wrote:
> I think the people that have been in there the most are Hal and Chandler of
> late with a few others here and there.
>
> -eric
>
> On Wed, Aug 19, 2015 at 10:30 AM Chris Lattner via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
>>
>>
>> > On Aug 19, 2015, at 9:50 AM, Hans Wennborg <hans at
chromium.org> wrote:
>> >
>> > We should find a code owner for the scalarizer
>> > (lib/Transforms/Scalar/Scalarizer.cpp).
>> >
>> > I nominate Richard Sandiford, who added it in r195471.
>> >
>> > Let me know what you think.
>>
>> I think it would make sense to look for someone a bit more granular,
even
>> though it’s a harder problem: it would be great to find an owner for
the
>> mid-level optimizer, including scalar,IPA,IPO, and perhaps the loop
xforms.
>>
>> -Chris

On 19 August 2015 at 19:19, Hans Wennborg via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> I still think finer-grained ownership is valuable, though, as such
> owners would be likely to be more familiar with the details in the
> code, and it also reduces the risk of overloading the high-level
> owner.
FWIW, anyone that can review patches will do that job, even not being
a code owner him/herself.

If Richard is familiar and has had a number of post-commit review
quality patches in this portion of code, he can already approve other
patches without being a code owner.

I don't mind either way, just don't want experienced people refraining
from reviewing or approving patches because they're not the code
owners.

cheers,
--renato