Chandler Carruth via llvm-dev
2015-Aug-14 03:53 UTC
[llvm-dev] Any objections to moving ObjCARC analysis passes to llvm/Analysis?
Currently these leave in lib/Transforms/ObjCARC even though they are analysis passes. This seems confusing and odd. In particular, Analysis/Passes.h talks about ObjCARCAliasAnalysis. =/ I'd like to just move the analysis headers to live under include/llvm/Analysis and the source under lib/Analysis. This will preclude omitting the ObjC ARC analysis passes from your build of LLVM if you don't care about them, but considering the number of dead-by-default passes in LLVM, this really doesn't seem like a significant concern. It also separates the language-specific bits a bit, but I'd rather have things correctly grouped by analysis and transform. If folks are seriously concerned about this, I could alternatively create an ObjCARC directory under Analysis, but that really seems like overkill. I think the name prefix is probably enough to distinguish things. Thoughts? -Chandler -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150814/4cd97502/attachment-0001.html>
Philip Reames via llvm-dev
2015-Aug-14 15:51 UTC
[llvm-dev] Any objections to moving ObjCARC analysis passes to llvm/Analysis?
On 08/13/2015 08:53 PM, Chandler Carruth via llvm-dev wrote:> Currently these leave in lib/Transforms/ObjCARC even though they are > analysis passes. This seems confusing and odd. In particular, > Analysis/Passes.h talks about ObjCARCAliasAnalysis. =/ > > I'd like to just move the analysis headers to live under > include/llvm/Analysis and the source under lib/Analysis. This will > preclude omitting the ObjC ARC analysis passes from your build of LLVM > if you don't care about them, but considering the number of > dead-by-default passes in LLVM, this really doesn't seem like a > significant concern. It also separates the language-specific bits a > bit, but I'd rather have things correctly grouped by analysis and > transform.+1> > If folks are seriously concerned about this, I could alternatively > create an ObjCARC directory under Analysis, but that really seems like > overkill. I think the name prefix is probably enough to distinguish > things.I would mildly prefer a sub-directory if there was more than (say) 3-4 files. Not a strong preference.> > Thoughts? > -Chandler > > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org http://llvm.cs.uiuc.edu > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150814/eab60a44/attachment.html>
Duncan P. N. Exon Smith via llvm-dev
2015-Aug-17 22:24 UTC
[llvm-dev] Any objections to moving ObjCARC analysis passes to llvm/Analysis?
> On 2015-Aug-14, at 08:51, Philip Reames via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > > > On 08/13/2015 08:53 PM, Chandler Carruth via llvm-dev wrote: >> Currently these leave in lib/Transforms/ObjCARC even though they are analysis passes. This seems confusing and odd. In particular, Analysis/Passes.h talks about ObjCARCAliasAnalysis. =/ >> >> I'd like to just move the analysis headers to live under include/llvm/Analysis and the source under lib/Analysis. This will preclude omitting the ObjC ARC analysis passes from your build of LLVM if you don't care about them, but considering the number of dead-by-default passes in LLVM, this really doesn't seem like a significant concern. It also separates the language-specific bits a bit, but I'd rather have things correctly grouped by analysis and transform. > +1Makes sense to me too.>> >> If folks are seriously concerned about this, I could alternatively create an ObjCARC directory under Analysis, but that really seems like overkill. I think the name prefix is probably enough to distinguish things. > I would mildly prefer a sub-directory if there was more than (say) 3-4 files. Not a strong preference. >> >> Thoughts? >> -Chandler >> >> >> _______________________________________________ >> LLVM Developers mailing list >> >> llvm-dev at lists.llvm.org http://llvm.cs.uiuc.edu >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org http://llvm.cs.uiuc.edu > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev