The new linker is quickly becoming more than just an experiment. 64-bit COFF linker is mostly feature complete, and now we are having a direct translation of the COFF linker for ELF. Historically LLD has been suffered by over-designing and over-engineering. I don't want to repeat that again in the new codebase, so I'd like to be an owner of the new linkers (both for ELF and COFF), so that I'm responsible to ensure all patches are reviewed (whether pre-commit or post-commit) if submitted to one of ELF or COFF directories. Is this okay with you guys? If it sounds reasonable to you guys, I'll create an OWNERS file under the LLD top directory and add myself for ELF and COFF. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150714/1edb4918/attachment.html>
On Tue, Jul 14, 2015 at 4:08 PM, Rui Ueyama <ruiu at google.com> wrote:> The new linker is quickly becoming more than just an experiment. 64-bit COFF > linker is mostly feature complete, and now we are having a direct > translation of the COFF linker for ELF. > > Historically LLD has been suffered by over-designing and over-engineering. I > don't want to repeat that again in the new codebase, so I'd like to be an > owner of the new linkers (both for ELF and COFF), so that I'm responsible to > ensure all patches are reviewed (whether pre-commit or post-commit) if > submitted to one of ELF or COFF directories. > > Is this okay with you guys? If it sounds reasonable to you guys, I'll create > an OWNERS file under the LLD top directory and add myself for ELF and COFF.Glad to see you're taking ownership. Long overdue. +1 for me.
LGTM On 14 July 2015 at 16:08, Rui Ueyama <ruiu at google.com> wrote:> The new linker is quickly becoming more than just an experiment. 64-bit COFF > linker is mostly feature complete, and now we are having a direct > translation of the COFF linker for ELF. > > Historically LLD has been suffered by over-designing and over-engineering. I > don't want to repeat that again in the new codebase, so I'd like to be an > owner of the new linkers (both for ELF and COFF), so that I'm responsible to > ensure all patches are reviewed (whether pre-commit or post-commit) if > submitted to one of ELF or COFF directories. > > Is this okay with you guys? If it sounds reasonable to you guys, I'll create > an OWNERS file under the LLD top directory and add myself for ELF and COFF.
On 07/14/15 04:09 PM, Rui Ueyama <ruiu at google.com> wrote:> > > The new linker is quickly becoming more than just an experiment. 64-bit COFF linker is mostly feature complete, and now we are having a direct translation of the COFF linker for ELF. > > Historically LLD has been suffered by over-designing and over-engineering. I don't want to repeat that again in the new codebase, so I'd like to be an owner of the new linkers (both for ELF and COFF), so that I'm responsible to ensure all patches are reviewed (whether pre-commit or post-commit) if submitted to one of ELF or COFF directories. > > Is this okay with you guys? If it sounds reasonable to you guys, I'll create an OWNERS file under the LLD top directory and add myself for ELF and COFF. > >Fine with me. -Nick -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150714/e84b94ba/attachment.html>
> On Jul 14, 2015, at 10:24 PM, Nick Kledzik <kledzik at apple.com> wrote: > > > > On 07/14/15 04:09 PM, Rui Ueyama <ruiu at google.com> wrote: >> >> The new linker is quickly becoming more than just an experiment. 64-bit COFF linker is mostly feature complete, and now we are having a direct translation of the COFF linker for ELF. >> >> Historically LLD has been suffered by over-designing and over-engineering. I don't want to repeat that again in the new codebase, so I'd like to be an owner of the new linkers (both for ELF and COFF), so that I'm responsible to ensure all patches are reviewed (whether pre-commit or post-commit) if submitted to one of ELF or COFF directories. >> >> Is this okay with you guys? If it sounds reasonable to you guys, I'll create an OWNERS file under the LLD top directory and add myself for ELF and COFF. > Fine with me.WFM, please update the OWNERS file, thanks & congrats Rui! -Chris -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150714/256833ab/attachment.html>
On Wed, Jul 15, 2015 at 2:08 AM, Rui Ueyama <ruiu at google.com> wrote:> Historically LLD has been suffered by over-designing and over-engineering. I > don't want to repeat that again in the new codebase, so I'd like to be an > owner of the new linkers (both for ELF and COFF), so that I'm responsible to > ensure all patches are reviewed (whether pre-commit or post-commit) if > submitted to one of ELF or COFF directories. > > Is this okay with you guys?LGTM -- Simon Atanasyan
On 15 July 2015 at 00:08, Rui Ueyama <ruiu at google.com> wrote:> Historically LLD has been suffered by over-designing and over-engineering. I > don't want to repeat that again in the new codebase, so I'd like to be an > owner of the new linkers (both for ELF and COFF), so that I'm responsible to > ensure all patches are reviewed (whether pre-commit or post-commit) if > submitted to one of ELF or COFF directories.Thanks Rui! That'd be great! cheers, --renato
Hi Rui,> so I'd like to be an owner of the new linkers (both for ELF and COFF), ...Sounds good to me. Do you mind if I add myself as a code owner for LLD Core / MachO, since I'll be continuing to work on that? Cheers, Lang. On Wed, Jul 15, 2015 at 2:17 AM, Renato Golin <renato.golin at linaro.org> wrote:> On 15 July 2015 at 00:08, Rui Ueyama <ruiu at google.com> wrote: > > Historically LLD has been suffered by over-designing and > over-engineering. I > > don't want to repeat that again in the new codebase, so I'd like to be an > > owner of the new linkers (both for ELF and COFF), so that I'm > responsible to > > ensure all patches are reviewed (whether pre-commit or post-commit) if > > submitted to one of ELF or COFF directories. > > Thanks Rui! That'd be great! > > cheers, > --renato >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150715/9c27ab2a/attachment.html>