Hello I am trying to enable globalsmodref-aa by default. globalmodref-aa is a ModulePass and therefore can be invalidated and need to be rerun. I see globalsmodref-aa is enabled in LTO passmanager by adding the analysis pass explicitly. I wonder whether globalsmodref-aa can be enabled/run based on pass dependencies, i.e. those indicated in getAnalysisUsage(). Thanks, Xin -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150713/25210cd1/attachment.html>
Hah. No. =/ So, globalsmodref-aa is *very very broken*. I'm working on emails to explain this, but I *really* don't want this to be enabled in the primary pass pipeline in its current form, if ever. It currently relies on bugs in the pass manager to even begin to work, and is wrong in many cases as a consequence. On Mon, Jul 13, 2015 at 10:27 AM Xin Tong <trent.xin.tong at gmail.com> wrote:> Hello > > > I am trying to enable globalsmodref-aa by default. globalmodref-aa is a > ModulePass and therefore can be invalidated and need to be rerun. > > > I see globalsmodref-aa is enabled in LTO passmanager by adding the > analysis pass explicitly. I wonder whether globalsmodref-aa can be > enabled/run based on pass dependencies, i.e. those indicated in > getAnalysisUsage(). > > Thanks, > Xin > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150713/fb4445ba/attachment.html>
so what are my options at the moment ? should i insert PM.add(createGlobalsModRefPass()); before transformations i know globalmodref-aa might improve ? Thanks -Xin On Mon, Jul 13, 2015 at 10:29 AM, Chandler Carruth <chandlerc at google.com> wrote:> Hah. No. =/ > > So, globalsmodref-aa is *very very broken*. I'm working on emails to > explain this, but I *really* don't want this to be enabled in the primary > pass pipeline in its current form, if ever. It currently relies on bugs in > the pass manager to even begin to work, and is wrong in many cases as a > consequence. > > On Mon, Jul 13, 2015 at 10:27 AM Xin Tong <trent.xin.tong at gmail.com> > wrote: > >> Hello >> >> >> I am trying to enable globalsmodref-aa by default. globalmodref-aa is a >> ModulePass and therefore can be invalidated and need to be rerun. >> >> >> I see globalsmodref-aa is enabled in LTO passmanager by adding the >> analysis pass explicitly. I wonder whether globalsmodref-aa can be >> enabled/run based on pass dependencies, i.e. those indicated in >> getAnalysisUsage(). >> >> Thanks, >> Xin >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150713/f03913d4/attachment.html>