Juergen Ributzka
2015-Jul-10 16:34 UTC
[LLVMdev] [RFC] New StackMap format proposal (StackMap v2)
Hi Hal, no, as far as I can recall we don’t make that guarantee for StackMap Records. Although, since we record the StackMap Records in function order and in instruction order inside a function this has always been true, but that wasn’t intentional. This format shouldn’t change this, but it also isn’t something that we programmatically enforce. Do you depend on that behavior? -Juergen> On Jul 9, 2015, at 4:59 PM, Hal Finkel <hfinkel at anl.gov> wrote: > > Do you guarantee that these will appear in order of increasing instruction offset? > > -Hal-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150710/f0578e24/attachment.html>
Hal Finkel
2015-Jul-10 16:40 UTC
[LLVMdev] [RFC] New StackMap format proposal (StackMap v2)
----- Original Message -----> From: "Juergen Ributzka" <juergen at apple.com> > To: "Hal Finkel" <hfinkel at anl.gov> > Cc: "Lang Hames" <lhames at apple.com>, "LLVM Dev" <llvmdev at cs.uiuc.edu> > Sent: Friday, July 10, 2015 11:34:48 AM > Subject: Re: [LLVMdev] [RFC] New StackMap format proposal (StackMap v2) > > > Hi Hal, > > no, as far as I can recall we don’t make that guarantee for StackMap > Records. Although, since we record the StackMap Records in function > order and in instruction order inside a function this has always > been true, but that wasn’t intentional. This format shouldn’t change > this, but it also isn’t something that we programmatically enforce. > > Do you depend on that behavior?No, but I've noticed that it is true in practice, and so I think that we should say something about it one way or another. Especially since, in switching to a fixed-size record format, binary searching now becomes relatively easy/fast. Maybe it would be a useful guarantee? Thanks again, Hal> > > -Juergen > > > > > > > On Jul 9, 2015, at 4:59 PM, Hal Finkel < hfinkel at anl.gov > wrote: > > Do you guarantee that these will appear in order of increasing > instruction offset? > > -Hal >-- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory
Juergen Ributzka
2015-Jul-10 16:47 UTC
[LLVMdev] [RFC] New StackMap format proposal (StackMap v2)
Sounds good. I will add that to the StackMap documentation when I update it for v2. —Juergen> On Jul 10, 2015, at 9:40 AM, Hal Finkel <hfinkel at anl.gov> wrote: > > No, but I've noticed that it is true in practice, and so I think that we should say something about it one way or another. Especially since, in switching to a fixed-size record format, binary searching now becomes relatively easy/fast. Maybe it would be a useful guarantee? > > Thanks again, > Hal-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150710/ed93df3f/attachment.html>