Ah, thanks, interesting - investigating On Wed, Jul 8, 2015 at 12:37 PM Renato Golin <renato.golin at linaro.org> wrote:> On 8 July 2015 at 11:31, Manuel Klimek <klimek at google.com> wrote: > > Those seem to be comments by the original author? Is this a problem? > > Not always, see http://reviews.llvm.org/D10676 or any other. > > I can only see the commenter name if they change some status, like > adding themselves to the list. > > --renato >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150708/a5af576e/attachment.html>
Ok, the problems is that in an attempt to make the emails more concise (so we have less clutter at the top where it says "<foo> added a comment") I changed the translation of "<foo> added a comment" to the empty string. The problem with that is that the same translation is apparently also used in the UI. I'll undo that configuration. Let me know if the "<foo> did <bar>" comments get too annoying and I'll figure something out. On Wed, Jul 8, 2015 at 1:26 PM Manuel Klimek <klimek at google.com> wrote:> Ah, thanks, interesting - investigating > > > On Wed, Jul 8, 2015 at 12:37 PM Renato Golin <renato.golin at linaro.org> > wrote: > >> On 8 July 2015 at 11:31, Manuel Klimek <klimek at google.com> wrote: >> > Those seem to be comments by the original author? Is this a problem? >> >> Not always, see http://reviews.llvm.org/D10676 or any other. >> >> I can only see the commenter name if they change some status, like >> adding themselves to the list. >> >> --renato >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150708/368b9199/attachment.html>
Great, thanks! On 8 July 2015 at 14:06, Manuel Klimek <klimek at google.com> wrote:> Ok, the problems is that in an attempt to make the emails more concise (so > we have less clutter at the top where it says "<foo> added a comment") I > changed the translation of "<foo> added a comment" to the empty string. The > problem with that is that the same translation is apparently also used in > the UI. I'll undo that configuration. Let me know if the "<foo> did <bar>" > comments get too annoying and I'll figure something out. > > On Wed, Jul 8, 2015 at 1:26 PM Manuel Klimek <klimek at google.com> wrote: >> >> Ah, thanks, interesting - investigating >> >> >> On Wed, Jul 8, 2015 at 12:37 PM Renato Golin <renato.golin at linaro.org> >> wrote: >>> >>> On 8 July 2015 at 11:31, Manuel Klimek <klimek at google.com> wrote: >>> > Those seem to be comments by the original author? Is this a problem? >>> >>> Not always, see http://reviews.llvm.org/D10676 or any other. >>> >>> I can only see the commenter name if they change some status, like >>> adding themselves to the list. >>> >>> --renato