Alexei Starovoitov
2015-Jun-05 00:35 UTC
[LLVMdev] [llvm] r239035 - Include BPF target in CMake builds.
On Thu, Jun 4, 2015 at 5:26 PM, Eric Christopher <echristo at gmail.com> wrote:> > > On Thu, Jun 4, 2015 at 4:09 PM Alexei Starovoitov > <alexei.starovoitov at gmail.com> wrote: >> >> On Thu, Jun 4, 2015 at 3:52 PM, Eric Christopher <echristo at gmail.com> >> wrote: >> > You were correct in your earlier assumption, this shouldn't have been >> > added >> > by default yet. >> > >> > I'm going to go ahead and revert this patch in a bit unless someone >> > tells me >> > not to bother, and you can propose your patch to do, essentially, the >> > same >> > thing with the rationale from this message if you'd like. >> >> of course. consider it proposed. >> llvmdev was cc-ed already. >> > > Probably best to have a new email with a subject of "Make BPF > non-experimental" or some such to make it more obvious to people reading the > list.sure. will do. as far as reverting... I was thinking, could you give it a day or so to go through all the buildbots ? I've been monitoring some and so far things are clean. And if nothing blows up in a day, it will give me more confidence to argue for permanent inclusion :)
Eric Christopher
2015-Jun-05 00:37 UTC
[LLVMdev] [llvm] r239035 - Include BPF target in CMake builds.
On Thu, Jun 4, 2015 at 5:36 PM Alexei Starovoitov < alexei.starovoitov at gmail.com> wrote:> On Thu, Jun 4, 2015 at 5:26 PM, Eric Christopher <echristo at gmail.com> > wrote: > > > > > > On Thu, Jun 4, 2015 at 4:09 PM Alexei Starovoitov > > <alexei.starovoitov at gmail.com> wrote: > >> > >> On Thu, Jun 4, 2015 at 3:52 PM, Eric Christopher <echristo at gmail.com> > >> wrote: > >> > You were correct in your earlier assumption, this shouldn't have been > >> > added > >> > by default yet. > >> > > >> > I'm going to go ahead and revert this patch in a bit unless someone > >> > tells me > >> > not to bother, and you can propose your patch to do, essentially, the > >> > same > >> > thing with the rationale from this message if you'd like. > >> > >> of course. consider it proposed. > >> llvmdev was cc-ed already. > >> > > > > Probably best to have a new email with a subject of "Make BPF > > non-experimental" or some such to make it more obvious to people reading > the > > list. > > sure. will do. > as far as reverting... I was thinking, could you give it a day > or so to go through all the buildbots ? I've been monitoring > some and so far things are clean. And if nothing blows up > in a day, it will give me more confidence to argue for permanent > inclusion :) >Or ultimately not reverting at all :) And sure. I'll hold off. Nothing bad seems to be happening. -eric -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150605/8750f7cf/attachment.html>