On 19 February 2015 at 13:57, Renato Golin <renato.golin at linaro.org> wrote:> test/CodeGen/R600/Output/infinite-loop-evergreen.ll > > Is actually in an infinite loop on AArch64... This is RC4 Phase3. I > didn't see that on RC3.Well, I spoke too early. Apparently the test finished after 8 minutes running... Is that expected? 8 minutes is longer than it takes to run the whole check-all on that box... cheers, --renato
+Matt who wrote that test. On Thu, Feb 19, 2015 at 5:59 AM, Renato Golin <renato.golin at linaro.org> wrote:> On 19 February 2015 at 13:57, Renato Golin <renato.golin at linaro.org> wrote: >> test/CodeGen/R600/Output/infinite-loop-evergreen.ll >> >> Is actually in an infinite loop on AArch64... This is RC4 Phase3. I >> didn't see that on RC3....> Well, I spoke too early. Apparently the test finished after 8 minutes > running... Is that expected?There weren't any R600 patches merged between rc3 and rc4.. I think the test is just broken and you got unlucky with this build. If I remove the XFAIL, the test fails for me by hitting an unreachable in AMDILCFGStructurizer.cpp. The behaviour feels a little arbitrary. Who knows what would happen in a non-asserts bug, and what the test expectation really is. I'm not going to worry about this one for the release. Cheers, Hans
On 19 February 2015 at 17:15, Hans Wennborg <hans at chromium.org> wrote:> There weren't any R600 patches merged between rc3 and rc4.. I think > the test is just broken and you got unlucky with this build.Yeah, I think I just didn't see it in time.> I'm not going to worry about this one for the release.Ok. cheers, --renato
> On Feb 19, 2015, at 9:15 AM, Hans Wennborg <hans at chromium.org> wrote: > > +Matt who wrote that test. > > On Thu, Feb 19, 2015 at 5:59 AM, Renato Golin <renato.golin at linaro.org> wrote: >> On 19 February 2015 at 13:57, Renato Golin <renato.golin at linaro.org> wrote: >>> test/CodeGen/R600/Output/infinite-loop-evergreen.ll >>> >>> Is actually in an infinite loop on AArch64... This is RC4 Phase3. I >>> didn't see that on RC3. > ... >> Well, I spoke too early. Apparently the test finished after 8 minutes >> running... Is that expected? > > There weren't any R600 patches merged between rc3 and rc4.. I think > the test is just broken and you got unlucky with this build. > > If I remove the XFAIL, the test fails for me by hitting an unreachable > in AMDILCFGStructurizer.cpp. The behaviour feels a little arbitrary. > Who knows what would happen in a non-asserts bug, and what the test > expectation really is.The point is basically to record this is broken so somebody notices in the future if this gets fixed. What the test does doesn’t really matter. It crashes immediately for me with the unreachable.> > I'm not going to worry about this one for the release. > > Cheers, > Hans