Chandler Carruth
2015-Feb-01 11:08 UTC
[LLVMdev] RFC: The free function llvm::SimplifyCFG isn't used by any in-tree code, can we kill it?
More precisely, its only used within its own implementation and via the pass. Wondering if we should just sink all the code into the pass rather than having a free function. -Chandler -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150201/a183ce59/attachment.html>
Reid Kleckner
2015-Feb-01 18:09 UTC
[LLVMdev] RFC: The free function llvm::SimplifyCFG isn't used by any in-tree code, can we kill it?
This is the simplifycfg utility function that takes a worklist of BBs? I was planning on using it to fix http://llvm.org/pr20300. The pass would identify unreachable resumes, convert them to unreachable, and ask simplifycfg to propagate that backwards. Is that the right approach, or do I have the wrong pass? On Sun, Feb 1, 2015 at 3:08 AM, Chandler Carruth <chandlerc at gmail.com> wrote:> More precisely, its only used within its own implementation and via the > pass. Wondering if we should just sink all the code into the pass rather > than having a free function. > > -Chandler > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150201/3608f899/attachment.html>
Philip Reames
2015-Feb-03 17:59 UTC
[LLVMdev] RFC: The free function llvm::SimplifyCFG isn't used by any in-tree code, can we kill it?
Unless having the free function adds a lot of complexity, please keep it. I don't have an immediate use for it right now, but it seems like something which might be useful in an out of tree pass in the future. Philip On 02/01/2015 03:08 AM, Chandler Carruth wrote:> More precisely, its only used within its own implementation and via > the pass. Wondering if we should just sink all the code into the pass > rather than having a free function. > > -Chandler > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150203/6574f389/attachment.html>