> Most of this is solved by importing the patch with git am. But it works only if the patch was generated from git format-patch.Trouble is, that's not what we get, or at least nowhere near often enough to even bother learning that tool.> If you want to save also the “download and find the patch file”, any review coming from Phabricator can be committed in a single command, for example: > > $ arc patch D7003Yeah, I'm not installing PHP locally just for a non-standard arc tool. I'm quite happy with what Phabricator does on the web, but it should present standard interfaces for clients (like a git branch/tag). Tim.
> On Jan 16, 2015, at 7:11 PM, Tim Northover <t.p.northover at gmail.com> wrote: > >> Most of this is solved by importing the patch with git am. But it works only if the patch was generated from git format-patch. > > Trouble is, that's not what we get, or at least nowhere near often > enough to even bother learning that tool.Well, if someone send a patch using “git show” instead of “git format-patch”, just ask to resend ? And the learning curve is … almost inexistant, there is nothing to learn. “git am path_to_the_patch” and you are done. You can even solve the download part by running "git am” and copy-pasting the content of the diff> >> If you want to save also the “download and find the patch file”, any review coming from Phabricator can be committed in a single command, for example: >> >> $ arc patch D7003 > > Yeah, I'm not installing PHP locallyIt seems someone did it for you "PHP has come standard with Macs since OS X version 10.0.0"> just for a non-standard arc tool.I am not sure how to determined what is or is not a standard tool...> I'm quite happy with what Phabricator does on the web, but it should > present standard interfaces for clients (like a git branch/tag).That would be nice indeed. (other asked for it https://phabricator.wikimedia.org/T127 ) — Mehdi
On Fri, Jan 16, 2015 at 7:11 PM, Tim Northover <t.p.northover at gmail.com> wrote:> > Most of this is solved by importing the patch with git am. But it works > only if the patch was generated from git format-patch. > > Trouble is, that's not what we get, or at least nowhere near often > enough to even bother learning that tool. > > > If you want to save also the “download and find the patch file”, any > review coming from Phabricator can be committed in a single command, for > example: > > > > $ arc patch D7003 > > Yeah, I'm not installing PHP locally just for a non-standard arc tool. > I'm quite happy with what Phabricator does on the web, but it should > present standard interfaces for clients (like a git branch/tag).I think we should just get some tiny python script that replaces the *tiny* amount of logic we actually need from 'arc'. =] -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150116/775050cb/attachment.html>
> Well, if someone send a patch using “git show” instead of “git format-patch”, just ask to resend ?And if they're using svn? Or arc (I don't actually care what it does though)?> It seems someone did it for you "PHP has come standard with Macs since OS X version 10.0.0"I only use OS X at work, where I'd have to get arc from source. Again, I simply don't think whatever web interface we (sometimes) use should be dictating our command-line tools.> I am not sure how to determined what is or is not a standard tool...arc is non-standard. It uses PHP; it's not even in MacPorts for when I am at work. I would vigorously oppose any recommendation to use its command-line tool as standard LLVM practice. As I said, I'm fine with that crap happening on a web-server someone else has to administer. I'm not fine with having to deal with it myself. Tim.