Duncan P. N. Exon Smith
2015-Jan-15 20:25 UTC
[LLVMdev] [RFC] First-class debug info IR: MDLocation (redux)
> On 2015-Jan-15, at 09:35, Hans Wennborg <hans at chromium.org> wrote: > > On Wed, Jan 14, 2015 at 8:26 PM, Duncan P. N. Exon Smith > <dexonsmith at apple.com> wrote: >> >>> On 2015 Jan 13, at 11:13, Robinson, Paul <Paul_Robinson at playstation.sony.com> wrote: >>> >>>> I suspect it would actually be *better* if I got all this in before >>>> the branch, since it'll make cherry-picking testcases easier. >>> >>> Excellent point, go for it. >> >> I missed the branch deadline, but I merged it in as of r226095. > > Thanks! Can you prepare an update to the release notes that cover the > debug info / metadata changes?How does this look? -------------- next part -------------- A non-text attachment was scrubbed... Name: metadata-3.6.patch Type: application/octet-stream Size: 5445 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150115/6bb32290/attachment.obj>
Hans Wennborg
2015-Jan-15 21:04 UTC
[LLVMdev] [RFC] First-class debug info IR: MDLocation (redux)
On Thu, Jan 15, 2015 at 12:25 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:> >> On 2015-Jan-15, at 09:35, Hans Wennborg <hans at chromium.org> wrote: >> >> On Wed, Jan 14, 2015 at 8:26 PM, Duncan P. N. Exon Smith >> <dexonsmith at apple.com> wrote: >>> >>>> On 2015 Jan 13, at 11:13, Robinson, Paul <Paul_Robinson at playstation.sony.com> wrote: >>>> >>>>> I suspect it would actually be *better* if I got all this in before >>>>> the branch, since it'll make cherry-picking testcases easier. >>>> >>>> Excellent point, go for it. >>> >>> I missed the branch deadline, but I merged it in as of r226095. >> >> Thanks! Can you prepare an update to the release notes that cover the >> debug info / metadata changes? > > How does this look?Looks great. Please commit it to the branch. Thanks, Hans> +is should now be written as:Nit: there's an extra is here.
Duncan P. N. Exon Smith
2015-Jan-15 21:44 UTC
[LLVMdev] [RFC] First-class debug info IR: MDLocation (redux)
> On 2015-Jan-15, at 13:04, Hans Wennborg <hans at chromium.org> wrote: > > On Thu, Jan 15, 2015 at 12:25 PM, Duncan P. N. Exon Smith > <dexonsmith at apple.com> wrote: >> >>> On 2015-Jan-15, at 09:35, Hans Wennborg <hans at chromium.org> wrote: >>> >>> On Wed, Jan 14, 2015 at 8:26 PM, Duncan P. N. Exon Smith >>> <dexonsmith at apple.com> wrote: >>>> >>>>> On 2015 Jan 13, at 11:13, Robinson, Paul <Paul_Robinson at playstation.sony.com> wrote: >>>>> >>>>>> I suspect it would actually be *better* if I got all this in before >>>>>> the branch, since it'll make cherry-picking testcases easier. >>>>> >>>>> Excellent point, go for it. >>>> >>>> I missed the branch deadline, but I merged it in as of r226095. >>> >>> Thanks! Can you prepare an update to the release notes that cover the >>> debug info / metadata changes? >> >> How does this look? > > Looks great. Please commit it to the branch.r226212> > Thanks, > Hans > > >> +is should now be written as: > Nit: there's an extra is here.r226213 (didn't notice this comment until I was replying).