I've looked at it a bit more and an updated ninja is part of it. You also need build.ninja to contain 'pool = console' on the lit rules. I added it manually to try it out but presumably a cmake update is needed to add this automatically. ________________________________ From: Renato Golin [renato.golin at linaro.org] Sent: 23 December 2014 00:55 To: David Blaikie Cc: LLVM Dev; Daniel Sanders Subject: Re: [LLVMdev] LIT Verbose Hi David, Just checked and it still doesn't print the percents during the run, and still prints the test results only after the run is finished. I'll fiddle with it more when I come home from holidays. Cheers, Renato On 23 Dec 2014 00:46, "David Blaikie" <dblaikie at gmail.com<mailto:dblaikie at gmail.com>> wrote: On Sat, Dec 20, 2014 at 2:00 AM, Renato Golin <renato.golin at linaro.org<mailto:renato.golin at linaro.org>> wrote: On 19 December 2014 at 17:29, Daniel Sanders <Daniel.Sanders at imgtec.com<mailto:Daniel.Sanders at imgtec.com>> wrote:> My understanding was the other way around. The tests timeout but they shouldn't. However, re-reading the original email I see that my mind inserted a word that isn't there. > Renato, just to double check: Is it failing _due_ to timeout? Or failing to timeout?Each test runs correctly and successfully, but all together take longer to run than the overall timeout. Unlike the make version, ninja doesn't print each test as they run, but after they have all finished, so you only have one output for several minutes "Running tests". A recent change (to lit? to cmake? to ninja?) causes this not to be the case, at least on interactive builds. I actually now get the lit progress bar UI & everything. Piping that output to a file... I get this: Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. So maybe that's working too? (though it's not printing out every file, it's true) The buildmaster kills the slave after a long time without receiving input, but that doesn't mean the slave is locked. It just means that the slave is not sending progress updates as it works through the tests. What I'm trying to enable is ninja to print each test as they run, not all at the end. Though, I'll be out until January without my laptop, so that'll be after the holidays. :) cheers, --renato _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu<mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141223/30bc477b/attachment.html>
On 23 December 2014 at 11:56, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:> I've looked at it a bit more and an updated ninja is part of it. You also > need build.ninja to contain 'pool = console' on the lit rules. I added it > manually to try it out but presumably a cmake update is needed to add this > automatically.Hi Daniel, What do you mean by "pool = console"? There are no pools named console, is that some kind of special rule that you created? I'd want to get CMake to generate a "pool = linkers" on all link jobs, and populate it from an argument's value, irrespective of -j argument. This is very useful for distcc. But that's for later. cheers, --renato
> From: Renato Golin [renato.golin at linaro.org] > Sent: 07 January 2015 10:13 > To: Daniel Sanders > Cc: David Blaikie; LLVM Dev > Subject: Re: [LLVMdev] LIT Verbose > > On 23 December 2014 at 11:56, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote: > > I've looked at it a bit more and an updated ninja is part of it. You also > > need build.ninja to contain 'pool = console' on the lit rules. I added it > > manually to try it out but presumably a cmake update is needed to add this > > automatically. > > Hi Daniel, > > What do you mean by "pool = console"? There are no pools named > console, is that some kind of special rule that you created? > > I'd want to get CMake to generate a "pool = linkers" on all link jobs, > and populate it from an argument's value, irrespective of -j argument. > This is very useful for distcc. But that's for later. > > cheers, > --renatoNinja 1.5 added a pre-defined pool named console. See http://martine.github.io/ninja/manual.html#_the_literal_console_literal_pool
On 23 December 2014 at 11:56, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:> I've looked at it a bit more and an updated ninja is part of it. You also > need build.ninja to contain 'pool = console' on the lit rules. I added it > manually to try it out but presumably a cmake update is needed to add this > automatically.Hi Daniel, So, I got back looking at it, and I have a question. It seems that CMake only added support for creating ninja pools in the 3.0 version, while most arches use 2.8 or less. But worse, it seems, that CMake only understands numeric pools, so far, ruling out the console pool. I'm not sure we would be able to add the console pool to the lit rules from CMake, and I don't want to add an extra step on all CMake builds, but I could do so on the buildbot (some smart sed one-liners on the rules.ninja file). Do you know of any alternative? If not, I may have to do that... :/ cheers, --renato
> -----Original Message----- > From: Renato Golin [mailto:renato.golin at linaro.org] > Sent: 22 January 2015 11:37 > To: Daniel Sanders > Cc: David Blaikie; LLVM Dev > Subject: Re: [LLVMdev] LIT Verbose > > On 23 December 2014 at 11:56, Daniel Sanders > <Daniel.Sanders at imgtec.com> wrote: > > I've looked at it a bit more and an updated ninja is part of it. You also > > need build.ninja to contain 'pool = console' on the lit rules. I added it > > manually to try it out but presumably a cmake update is needed to add this > > automatically. > > Hi Daniel, > > So, I got back looking at it, and I have a question. > > It seems that CMake only added support for creating ninja pools in the > 3.0 version, while most arches use 2.8 or less. But worse, it seems, > that CMake only understands numeric pools, so far, ruling out the > console pool.Support for the console pool should appear in cmake 3.2 (http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=444f61e0) and our CMakeLists.txt's should be ready for it (http://llvm.org/viewvc/llvm-project?view=revision&revision=222181). I'm on cmake 3.0.2 so I haven't tried it for myself yet.> I'm not sure we would be able to add the console pool to the lit rules > from CMake, and I don't want to add an extra step on all CMake builds, > but I could do so on the buildbot (some smart sed one-liners on the > rules.ninja file). > > Do you know of any alternative? If not, I may have to do that... :/ > > cheers, > --renatoI'm afraid the sed approach is the only thing that I can think of.