btw, do you have commit access or should I commit it? On 6 January 2015 at 11:22, Rafael Espíndola <rafael.espindola at gmail.com> wrote:> LGTM, thanks! > > On 4 January 2015 at 19:08, Wilfred Hughes <me at wilfred.me.uk> wrote: >> Hi >> >> I'd like users to be able to install the LLVM major modes from >> MELPA[1], the most popular Emacs package repository. However, these >> files are not well-formed packages. >> >> I've made the following changes: >> >> * Both files have valid package headers and footers (you can verify >> with M-x checkdoc). >> * Fixed style warnings generated by checkdoc. >> * Fixed a byte-compiler warning in llvm-mode.el. >> * Ensure that the modes are autoloaded, so users do not need to >> (require 'llvm-mode) to use them. >> >> Patch attached, let me know what you think. >> >> Thanks >> Wilfred >> >> [1] http://melpa.org/ >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>
I don't have commit access, so please go ahead. Wilfred On 6 Jan 2015 23:45, "Rafael Espíndola" <rafael.espindola at gmail.com> wrote:> btw, do you have commit access or should I commit it? > > On 6 January 2015 at 11:22, Rafael Espíndola <rafael.espindola at gmail.com> > wrote: > > LGTM, thanks! > > > > On 4 January 2015 at 19:08, Wilfred Hughes <me at wilfred.me.uk> wrote: > >> Hi > >> > >> I'd like users to be able to install the LLVM major modes from > >> MELPA[1], the most popular Emacs package repository. However, these > >> files are not well-formed packages. > >> > >> I've made the following changes: > >> > >> * Both files have valid package headers and footers (you can verify > >> with M-x checkdoc). > >> * Fixed style warnings generated by checkdoc. > >> * Fixed a byte-compiler warning in llvm-mode.el. > >> * Ensure that the modes are autoloaded, so users do not need to > >> (require 'llvm-mode) to use them. > >> > >> Patch attached, let me know what you think. > >> > >> Thanks > >> Wilfred > >> > >> [1] http://melpa.org/ > >> > >> _______________________________________________ > >> LLVM Developers mailing list > >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150107/a55b8fa3/attachment.html>
r225356. Thanks. On 7 January 2015 at 03:53, Wilfred Hughes <me at wilfred.me.uk> wrote:> I don't have commit access, so please go ahead. > > Wilfred > > On 6 Jan 2015 23:45, "Rafael Espíndola" <rafael.espindola at gmail.com> wrote: >> >> btw, do you have commit access or should I commit it? >> >> On 6 January 2015 at 11:22, Rafael Espíndola <rafael.espindola at gmail.com> >> wrote: >> > LGTM, thanks! >> > >> > On 4 January 2015 at 19:08, Wilfred Hughes <me at wilfred.me.uk> wrote: >> >> Hi >> >> >> >> I'd like users to be able to install the LLVM major modes from >> >> MELPA[1], the most popular Emacs package repository. However, these >> >> files are not well-formed packages. >> >> >> >> I've made the following changes: >> >> >> >> * Both files have valid package headers and footers (you can verify >> >> with M-x checkdoc). >> >> * Fixed style warnings generated by checkdoc. >> >> * Fixed a byte-compiler warning in llvm-mode.el. >> >> * Ensure that the modes are autoloaded, so users do not need to >> >> (require 'llvm-mode) to use them. >> >> >> >> Patch attached, let me know what you think. >> >> >> >> Thanks >> >> Wilfred >> >> >> >> [1] http://melpa.org/ >> >> >> >> _______________________________________________ >> >> LLVM Developers mailing list >> >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> >>