llvm dev - Nov 2014 - [LLVMdev] [llvm][SelectionDAG] trivial patch: fix misprint in SelectionDAGLegalize::ExpandInsertToVectorThroughStack

Hi Owen!

The "First store the whole vector" is without uses and will be deleted
later.
I've attached trivial patch to fix it.
I have no commit access so if patch is OK, please, commit it .

Danil.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20141112/52592eeb/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ExpandInsertToVectorThroughStack.patch
Type: application/octet-stream
Size: 2960 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20141112/52592eeb/attachment.obj>

LGTM.  Can you supply a testcase?

—Owen
> On Nov 12, 2014, at 5:52 AM, Daniil Troshkov <troshkovdanil at
gmail.com> wrote:
> 
> Hi Owen!
>  
> The "First store the whole vector" is without uses and will be
deleted later.
> I've attached trivial patch to fix it.
> I have no commit access so if patch is OK, please, commit it .
>  
> Danil.
> <ExpandInsertToVectorThroughStack.patch>

I detected this bug using test case from platform which is not currently
supported on llvm targets. (Our team is porting llvm on new target).
Creating the test case will take some extra time. I'll try to do it ASAP.
Have you any ideas about the test case? (targets using
ExpandInsertToVectorThroughStack, etc...)


On Wed, Nov 12, 2014 at 8:29 PM, Owen Anderson <resistor at mac.com>
wrote:
> LGTM.  Can you supply a testcase?
>
> —Owen
>
> > On Nov 12, 2014, at 5:52 AM, Daniil Troshkov <troshkovdanil at
gmail.com>
> wrote:
> >
> > Hi Owen!
> >
> > The "First store the whole vector" is without uses and will
be deleted
> later.
> > I've attached trivial patch to fix it.
> > I have no commit access so if patch is OK, please, commit it .
> >
> > Danil.
> > <ExpandInsertToVectorThroughStack.patch>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20141113/9797e9a3/attachment.html>