Looks like most people in this thread support using LLVM style in LLD. I also had an offline discussion and many people wanted to have one coding style in all LLVM projects. So I'm convinced that we should do that. I'm going to create a patch to rename all variables if no one objects. On Mon, Oct 6, 2014 at 3:10 PM, Bruce Hoult <bruce at hoult.org> wrote:> On Tue, Oct 7, 2014 at 8:54 AM, Rui Ueyama <ruiu at google.com> wrote: > >> would touch all the lines. Diff is not powerful enough to trace the >> history beyond variable renaming. svn blame would become useless. >> > > "useless" is much too strong a description. > > If svn blame points to the reformat commit, then simply re-run the blame > on the commit before the reformat. > > If total reformats are frequent then this is impractical. If they happen > once in five years then it's not really a big deal. Wrapper scripts can > even be pretty easily written to do this automatically. > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141006/7753943b/attachment.html>
On Oct 6, 2014, at 3:44 PM, Rui Ueyama <ruiu at google.com> wrote:> Looks like most people in this thread support using LLVM style in LLD. I also had an offline discussion and many people wanted to have one coding style in all LLVM projects. So I'm convinced that we should do that. > > I'm going to create a patch to rename all variables if no one objects.I object! -Nick> > On Mon, Oct 6, 2014 at 3:10 PM, Bruce Hoult <bruce at hoult.org> wrote: > On Tue, Oct 7, 2014 at 8:54 AM, Rui Ueyama <ruiu at google.com> wrote: > would touch all the lines. Diff is not powerful enough to trace the history beyond variable renaming. svn blame would become useless. > > "useless" is much too strong a description. > > If svn blame points to the reformat commit, then simply re-run the blame on the commit before the reformat. > > If total reformats are frequent then this is impractical. If they happen once in five years then it's not really a big deal. Wrapper scripts can even be pretty easily written to do this automatically. > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141006/d0771b56/attachment.html>
On Mon, Oct 6, 2014 at 5:00 PM, Nick Kledzik <kledzik at apple.com> wrote:> On Oct 6, 2014, at 3:44 PM, Rui Ueyama <ruiu at google.com> wrote: > > Looks like most people in this thread support using LLVM style in LLD. I > also had an offline discussion and many people wanted to have one coding > style in all LLVM projects. So I'm convinced that we should do that. > > I'm going to create a patch to rename all variables if no one objects. > > I object! >I'd like to hear the reason. :)> -Nick > > > On Mon, Oct 6, 2014 at 3:10 PM, Bruce Hoult <bruce at hoult.org> wrote: > >> On Tue, Oct 7, 2014 at 8:54 AM, Rui Ueyama <ruiu at google.com> wrote: >> >>> would touch all the lines. Diff is not powerful enough to trace the >>> history beyond variable renaming. svn blame would become useless. >>> >> >> "useless" is much too strong a description. >> >> If svn blame points to the reformat commit, then simply re-run the blame >> on the commit before the reformat. >> >> If total reformats are frequent then this is impractical. If they happen >> once in five years then it's not really a big deal. Wrapper scripts can >> even be pretty easily written to do this automatically. >> >> > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141006/0963f094/attachment.html>
On Mon, Oct 06, 2014 at 03:44:19PM -0700, Rui Ueyama wrote:> Looks like most people in this thread support using LLVM style in LLD. I > also had an offline discussion and many people wanted to have one coding > style in all LLVM projects. So I'm convinced that we should do that. > > I'm going to create a patch to rename all variables if no one objects.I'd split the two things discussed. Move to clang-format as one item, adjust the (semi-)public headers as second item and do the rest of the source whenever someone changes them. Joerg