On 3 October 2014 14:42, Evgeniy Stepanov <eugenis at google.com> wrote:> this happens when x86 target is not compiled in. We really should (and > will) do something about it. > > Btw, you've asked the same question a month ago :) Sorry it has been > an issue for such a long time.No worries, I also haven't done much. But I need to get the RT bot green soon enough. Is that a CMake issue? Or a lit issues? --renato
The flag itself is target-specific, which seems to be very uncommon in LLVM. Perhaps it's better to move it to some common part of the code. This flag makes sense for other platforms as well, it is just not implemented there. Alternatively, we could fix compiler-rt cmake not to pass this flag when targetting non-x86. This is not so easy because we use custom commands to build tests with just-built clang (different from CMAKE_C_COMPILER), and we don't have any support for testing the features of this custom compiler. Also, there are plan to kill this code and build compiler-rt in sub-trees with normal CMake rules. On Fri, Oct 3, 2014 at 5:50 PM, Renato Golin <renato.golin at linaro.org> wrote:> On 3 October 2014 14:42, Evgeniy Stepanov <eugenis at google.com> wrote: >> this happens when x86 target is not compiled in. We really should (and >> will) do something about it. >> >> Btw, you've asked the same question a month ago :) Sorry it has been >> an issue for such a long time. > > No worries, I also haven't done much. But I need to get the RT bot > green soon enough. Is that a CMake issue? Or a lit issues? > > --renato
On 3 October 2014 15:02, Evgeniy Stepanov <eugenis at google.com> wrote:> The flag itself is target-specific, which seems to be very uncommon in > LLVM. Perhaps it's better to move it to some common part of the code. > This flag makes sense for other platforms as well, it is just not > implemented there.Would it make sense to run the same test without that flag on ARM? If not, than we should move those tests to X86 directories and not run them if the X86 backend is not built. When configuring Clang/LLVM I see that compiler RT follows the same back-ends as I request for Clang, which should be ok for text-comparison tests, but not for execution. Does Compiler-RT have any knowledge of that difference when testing? cheers, --renato