On Wed, Sep 17, 2014 at 12:27:42PM +0300, Yaron Keren wrote:> Large software libraries like OpenCV (under 3rdparty directory) do include > copies of zlib and friends and build it, for that reasons. The source code > is just half a megabyte and I think the license is compatible. We could do > the same with zlib or miniz.>From a packager's perspective, library bundling is one of the mostobnoxious issues around. It creates all kind of fun whenever a security issue is found or you have to fix the same portability issue in 100 different copies (*cough* gtest *cough*) Joerg
Mueller-Roemer, Johannes Sebastian
2014-Sep-17 12:27 UTC
[LLVMdev] proposal to avoid zlib dependency.
Yes, this is incredibly annoying, so please avoid that. However I noticed that the current solution using CMake is broken, as I cannot enter my own ZLIB_ROOT, since no proper find_package is used. -- Johannes S. Mueller-Roemer, MSc Wiss. Mitarbeiter - Interactive Engineering Technologies (IET) Fraunhofer-Institut für Graphische Datenverarbeitung IGD Fraunhoferstr. 5 | 64283 Darmstadt | Germany Tel +49 6151 155-606 | Fax +49 6151 155-139 johannes.mueller-roemer at igd.fraunhofer.de | www.igd.fraunhofer.de -----Original Message----- From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On Behalf Of Joerg Sonnenberger Sent: Wednesday, September 17, 2014 12:56 To: llvmdev at cs.uiuc.edu Subject: Re: [LLVMdev] proposal to avoid zlib dependency. On Wed, Sep 17, 2014 at 12:27:42PM +0300, Yaron Keren wrote:> Large software libraries like OpenCV (under 3rdparty directory) do > include copies of zlib and friends and build it, for that reasons. The > source code is just half a megabyte and I think the license is > compatible. We could do the same with zlib or miniz.>From a packager's perspective, library bundling is one of the most obnoxious issues around. It creates all kind of fun whenever a security issue is found or you have to fix the same portability issue in 100 different copies (*cough* gtest *cough*)Joerg _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
On 17 September 2014 13:27, Mueller-Roemer, Johannes Sebastian <Johannes.Sebastian.Mueller-Roemer at igd.fraunhofer.de> wrote:> Yes, this is incredibly annoying, so please avoid that. However I noticed that the current solution using CMake is broken, as I cannot enter my own ZLIB_ROOT, since no proper find_package is used.I just had a go at hacking this so that we use find_package(ZLIB) if LLVM_ENABLE_ZLIB is used. Does the attached patch work correctly? If so I could send to llvm-commits for review. -------------- next part -------------- A non-text attachment was scrubbed... Name: use_find_package_zlib.patch Type: text/x-patch Size: 1549 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140917/4a70d897/attachment.bin>