Brad King
2014-Sep-09 19:16 UTC
[LLVMdev] Can't build against LLVM-3.5 with CMake: CMakeExports.cmake broken?
On 09/09/2014 01:53 PM, Dan Liew wrote:>> It looks like LLVMConfigLibs was created in r112714 for local use in >> Makefile.rules. The only use outside Makefile.rules is now in >> cmake/modules/Makefile. Teaching cmake/modules/Makefile to do >> a direct invocation would be fine with me. > > Okay. Attached is a patch that does this. Does this work okay for you?Yes. Thanks, -Brad
Dan Liew
2014-Sep-09 19:25 UTC
[LLVMdev] Can't build against LLVM-3.5 with CMake: CMakeExports.cmake broken?
> > Okay. Attached is a patch that does this. Does this work okay for you? > > Yes.Great. @Eric Is this okay to commit to trunk? I think I'll hold of applying to the release_35 branch until I know if I'm allowed to. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140909/076cd439/attachment.html>
Eric Christopher
2014-Sep-09 19:34 UTC
[LLVMdev] Can't build against LLVM-3.5 with CMake: CMakeExports.cmake broken?
On Tue, Sep 9, 2014 at 12:25 PM, Dan Liew <dan at su-root.co.uk> wrote:> > > Okay. Attached is a patch that does this. Does this work okay for you? > > > > Yes. > > Great. > > @Eric Is this okay to commit to trunk? >Yep. Thanks!> I think I'll hold of applying to the release_35 branch until I know if I'm > allowed to. >I think Tom was our point release guy IIRC. -eric -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140909/68895f77/attachment.html>