On 5 September 2014 13:38, Matthew Gardiner <mg11 at csr.com>
wrote:> I'm now being blamed by a buildbot for this
Hi Matt,
Don't worry, no one is "blaming" you. :)
Builds fail for various reasons, sometimes it's your commit, sometimes
it's a commit on a repository that is not tracked by that bot,
sometimes it's a bot issue.
In this case, the bot is unstable and I'm working to get us more
stable ARM bots as we speak, but for the time being, the rule of thumb
is this:
When you get a mail from a buildbot failure, you:
1. Click on the link and inspect the error. If it's obviously you,
please fix it asap or revert the patch. Also, ping the IRC channel and
reply to the email (which will have arrived to all other committers)
that you're looking into it, so they don't have to worry.
2. If it's not obviously you, check:
2a. The stdio output of the red bits for timeouts, internal compiler
error, no space left on disk, lost connection. These are bot problems,
ignore for now, but keep an eye to make sure the next builds are
green.
2b. Or, the tests failing, and if the test was added or changed by
another commit on the same build, feel free to reply the email asking
the developer to look into it.
2c. Or, that the failure can be reproduced in your machine and try to
see if there's anything you did that could come to that.
If it was your commit, sometimes, you'll need help from the
maintainer, for instance, if this is an ARM specific failure.
Every bot has an owner and, if it's your fault, you should email the
owner if he hasn't contacted you yet. Not everyone does that, and bot
owners know that they should wait a bit to spot if any "fixing bots"
commit is coming through before calling foul. Though, we generally
mail you anyway, just to make sure you are aware of the problem.
Some of us try to bisect on our own hardware and will pinpoint the
offending commit and work with the developer to fix it. Some of us may
even provide you access to a board so you can debug your own code on
our architecture.
If that takes more than a few days, reverting the commit is probably
best. You should revert your own commits, or work with whomever is
reverting it, to make sure nothing is removed by accident (multiple or
old commits are harder to revert).
If that takes even longer, you should create a bugzilla report,
copying the owner of the bot, architecture code owner, etc and work
from there.
If that feature/bugfix is *really* important to you, please make
everyone aware by marking the bug as so, and display interest and
pro-activity when dealing with the fixes and investigation. Also, let
us know if that needs back-porting to the current releases' patch
release (3.5.1 etc) and contact the point-release manager, which may
change, so enquire on the list.
Hope that helps,
cheers,
--renato