Simon Atanasyan
2014-Jul-28 12:21 UTC
[LLVMdev] [RFC] Install yaml2obj and obj2yaml utilities together with other LLVM tools
Let's suppose that MCLinker folks are here already - I am a committer of this project :). Maybe I did not formulate my suggestion correctly. When I offer to "install" the yaml2obj and obj2yaml utilities I mean result of the "make install" command only. I do not suggest to include this utilities into any distributed binary packages. To be clear I attached the patch with suggested changes. On Mon, Jul 28, 2014 at 3:07 AM, Sean Silva <chisophugis at gmail.com> wrote:> I think that installing these tools and having them used by third-party > projects are separate questions. > > AFAIK, currently these tools are considered purely internal testing tools, > so we don't want external projects relying on them. Anyway, I personally > can't think of any project other than MCLinker for which it would make sense > to depend on these tools, so better to just have the MCLinker folks get > involved upstream. > > As to installing the tools, I'm sure that many of the tools that get > installed currently are testing tools as well, so I don't see the harm of > installing these tools (besides possibly bloating packages, which should > probably be evaluated). Personally I don't think these tools are very useful > outside of their testing role so I wouldn't bother installing them. > > -- Sean Silva > > On Sun, Jul 27, 2014 at 8:57 AM, Simon Atanasyan <simon at atanasyan.com> > wrote: >> >> Now the yaml2obj and obj2yaml utilities used in LLVM and LLD projects >> tests only and not installed by the "make install" command. I think >> they might be also useful in third-party projects like MCLinker. I >> suggest to move these utilities into the "tools" category and install >> them together with other LLVM tools. >> >> Any objections or comments?-- Simon Atanasyan -------------- next part -------------- A non-text attachment was scrubbed... Name: yaml2obj-install.patch Type: application/octet-stream Size: 1389 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140728/62d5ee8f/attachment.obj>
Sean Silva
2014-Jul-28 15:55 UTC
[LLVMdev] [RFC] Install yaml2obj and obj2yaml utilities together with other LLVM tools
On Mon, Jul 28, 2014 at 6:21 AM, Simon Atanasyan <simon at atanasyan.com> wrote:> Let's suppose that MCLinker folks are here already - I am a committer > of this project :). >Doesn't seem like a problem then.> > Maybe I did not formulate my suggestion correctly. When I offer to > "install" the yaml2obj and obj2yaml utilities I mean result of the > "make install" command only. I do not suggest to include this > utilities into any distributed binary packages. To be clear I attached > the patch with suggested changes. >I don't think that patch would hurt. I'd like a second opinion from Rafael though. -- Sean Silva> > On Mon, Jul 28, 2014 at 3:07 AM, Sean Silva <chisophugis at gmail.com> wrote: > > I think that installing these tools and having them used by third-party > > projects are separate questions. > > > > AFAIK, currently these tools are considered purely internal testing > tools, > > so we don't want external projects relying on them. Anyway, I personally > > can't think of any project other than MCLinker for which it would make > sense > > to depend on these tools, so better to just have the MCLinker folks get > > involved upstream. > > > > As to installing the tools, I'm sure that many of the tools that get > > installed currently are testing tools as well, so I don't see the harm of > > installing these tools (besides possibly bloating packages, which should > > probably be evaluated). Personally I don't think these tools are very > useful > > outside of their testing role so I wouldn't bother installing them. > > > > -- Sean Silva > > > > On Sun, Jul 27, 2014 at 8:57 AM, Simon Atanasyan <simon at atanasyan.com> > > wrote: > >> > >> Now the yaml2obj and obj2yaml utilities used in LLVM and LLD projects > >> tests only and not installed by the "make install" command. I think > >> they might be also useful in third-party projects like MCLinker. I > >> suggest to move these utilities into the "tools" category and install > >> them together with other LLVM tools. > >> > >> Any objections or comments? > > -- > Simon Atanasyan >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140728/414aee49/attachment.html>
Rafael Avila de Espindola
2014-Jul-28 17:26 UTC
[LLVMdev] [RFC] Install yaml2obj and obj2yaml utilities together with other LLVM tools
LGTM Sent from my iPhone> On Jul 28, 2014, at 11:55, Sean Silva <chisophugis at gmail.com> wrote: > > > > >> On Mon, Jul 28, 2014 at 6:21 AM, Simon Atanasyan <simon at atanasyan.com> wrote: >> Let's suppose that MCLinker folks are here already - I am a committer >> of this project :). > > Doesn't seem like a problem then. > >> >> Maybe I did not formulate my suggestion correctly. When I offer to >> "install" the yaml2obj and obj2yaml utilities I mean result of the >> "make install" command only. I do not suggest to include this >> utilities into any distributed binary packages. To be clear I attached >> the patch with suggested changes. > > I don't think that patch would hurt. I'd like a second opinion from Rafael though. > > -- Sean Silva > >> >> On Mon, Jul 28, 2014 at 3:07 AM, Sean Silva <chisophugis at gmail.com> wrote: >> > I think that installing these tools and having them used by third-party >> > projects are separate questions. >> > >> > AFAIK, currently these tools are considered purely internal testing tools, >> > so we don't want external projects relying on them. Anyway, I personally >> > can't think of any project other than MCLinker for which it would make sense >> > to depend on these tools, so better to just have the MCLinker folks get >> > involved upstream. >> > >> > As to installing the tools, I'm sure that many of the tools that get >> > installed currently are testing tools as well, so I don't see the harm of >> > installing these tools (besides possibly bloating packages, which should >> > probably be evaluated). Personally I don't think these tools are very useful >> > outside of their testing role so I wouldn't bother installing them. >> > >> > -- Sean Silva >> > >> > On Sun, Jul 27, 2014 at 8:57 AM, Simon Atanasyan <simon at atanasyan.com> >> > wrote: >> >> >> >> Now the yaml2obj and obj2yaml utilities used in LLVM and LLD projects >> >> tests only and not installed by the "make install" command. I think >> >> they might be also useful in third-party projects like MCLinker. I >> >> suggest to move these utilities into the "tools" category and install >> >> them together with other LLVM tools. >> >> >> >> Any objections or comments? >> >> -- >> Simon Atanasyan >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140728/31a22005/attachment.html>