Bas van den Berg
2014-Jul-10 11:10 UTC
[LLVMdev] [lld] LLD's software architecture (update)
Well, it does have a Registry& that's defined in Reader.h. But that can be forward declared (and apparently is in some of the other headers it includes. On Thu, Jul 10, 2014 at 12:08 PM, Andreas Wendleder < andreas.wendleder at googlemail.com> wrote:> Hi > > - passes depend on Reader and Writer >> > > That's an easy one. Compile tested on Windows with Cmake. > > Regards, > Andreas > > From 36855377f20b0492735339f36ed7c650a4c90624 Mon Sep 17 00:00:00 2001 > From: Andreas Wendleder <andreas.wendleder at gmail.com> > Date: Thu, 10 Jul 2014 10:58:32 +0100 > Subject: [PATCH] Remove LayoutPass dependency on ReaderWriter. > > It's not used anyway. > --- > include/lld/Passes/LayoutPass.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/lld/Passes/LayoutPass.h > b/include/lld/Passes/LayoutPass.h > index 3392480..ffb633d 100644 > --- a/include/lld/Passes/LayoutPass.h > +++ b/include/lld/Passes/LayoutPass.h > @@ -12,7 +12,6 @@ > > #include "lld/Core/File.h" > #include "lld/Core/Pass.h" > -#include "lld/ReaderWriter/Reader.h" > > #include "llvm/ADT/DenseMap.h" > > -- > 1.9.2.msysgit.0 > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140710/d957aed8/attachment.html>
Jean-Daniel Dupas
2014-Jul-10 12:30 UTC
[LLVMdev] [lld] LLD's software architecture (update)
Using forward-declaration would not fix the layer violation. Le 10 juil. 2014 à 13:10, Bas van den Berg <b.van.den.berg.nl at gmail.com> a écrit :> Well, it does have a Registry& that's defined in Reader.h. > But that can be forward declared (and apparently is in some > of the other headers it includes. > > > > On Thu, Jul 10, 2014 at 12:08 PM, Andreas Wendleder <andreas.wendleder at googlemail.com> wrote: > Hi > > - passes depend on Reader and Writer > > That's an easy one. Compile tested on Windows with Cmake. > > Regards, > Andreas > > From 36855377f20b0492735339f36ed7c650a4c90624 Mon Sep 17 00:00:00 2001 > From: Andreas Wendleder <andreas.wendleder at gmail.com> > Date: Thu, 10 Jul 2014 10:58:32 +0100 > Subject: [PATCH] Remove LayoutPass dependency on ReaderWriter. > > It's not used anyway. > --- > include/lld/Passes/LayoutPass.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/lld/Passes/LayoutPass.h b/include/lld/Passes/LayoutPass.h > index 3392480..ffb633d 100644 > --- a/include/lld/Passes/LayoutPass.h > +++ b/include/lld/Passes/LayoutPass.h > @@ -12,7 +12,6 @@ > > #include "lld/Core/File.h" > #include "lld/Core/Pass.h" > -#include "lld/ReaderWriter/Reader.h" > > #include "llvm/ADT/DenseMap.h" > > -- > 1.9.2.msysgit.0 > > > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140710/0d04299a/attachment.html>
Bas van den Berg
2014-Jul-10 12:47 UTC
[LLVMdev] [lld] LLD's software architecture (update)
Yes, but if you look in LayoutPasses.c, it calls registry.referenceKindToString(..), so it does need the definition.. On Thu, Jul 10, 2014 at 2:30 PM, Jean-Daniel Dupas <mailing at xenonium.com> wrote:> Using forward-declaration would not fix the layer violation. > > Le 10 juil. 2014 à 13:10, Bas van den Berg <b.van.den.berg.nl at gmail.com> > a écrit : > > Well, it does have a Registry& that's defined in Reader.h. > But that can be forward declared (and apparently is in some > of the other headers it includes. > > > > On Thu, Jul 10, 2014 at 12:08 PM, Andreas Wendleder < > andreas.wendleder at googlemail.com> wrote: > >> Hi >> >> - passes depend on Reader and Writer >>> >> >> That's an easy one. Compile tested on Windows with Cmake. >> >> Regards, >> Andreas >> >> From 36855377f20b0492735339f36ed7c650a4c90624 Mon Sep 17 00:00:00 2001 >> From: Andreas Wendleder <andreas.wendleder at gmail.com> >> Date: Thu, 10 Jul 2014 10:58:32 +0100 >> Subject: [PATCH] Remove LayoutPass dependency on ReaderWriter. >> >> It's not used anyway. >> --- >> include/lld/Passes/LayoutPass.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/lld/Passes/LayoutPass.h >> b/include/lld/Passes/LayoutPass.h >> index 3392480..ffb633d 100644 >> --- a/include/lld/Passes/LayoutPass.h >> +++ b/include/lld/Passes/LayoutPass.h >> @@ -12,7 +12,6 @@ >> >> #include "lld/Core/File.h" >> #include "lld/Core/Pass.h" >> -#include "lld/ReaderWriter/Reader.h" >> >> #include "llvm/ADT/DenseMap.h" >> >> -- >> 1.9.2.msysgit.0 >> >> >> >> > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140710/eb8535c9/attachment.html>