llvm dev - Jul 2014 - [LLVMdev] instprof tests down in ARM build

A few weeks ago, I started seeing 6 tests start failing in the Profile
test suite of the ARM Linux build.  Anyone else seeing this?  They all
fail with similar output:


Command Output (stderr):
--
compiler-rt/test/profile/instrprof-write-file.c:13:12: error: expected
string not found in input
 // CHECK: br i1 %{{.*}}, label %{{.*}}, label %{{.*}}, !prof !1
           ^
<stdin>:6:17: note: scanning from here
define i32 @main(i32 %argc, i8** %argv) #0 {
                ^
<stdin>:17:2: note: possible intended match here
 br i1 %cmp, label %if.then, label %if.end, !prof !3
 ^
compiler-rt/test/profile/instrprof-write-file.c:33:11: error: expected
string not found in input
// CHECK: !1 = metadata !{metadata !"branch_weights", i32 1, i32 2}
          ^
<stdin>:51:1: note: scanning from here
cond.true: ; preds = %entry
^
<stdin>:76:1: note: possible intended match here
!3 = metadata !{metadata !"branch_weights", i32 1, i32 2}
^

--

********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 61.15s
********************
Failing Tests (6):
    Profile :: instrprof-basic.c
    Profile :: instrprof-set-filename.c
    Profile :: instrprof-without-libc.c
    Profile :: instrprof-write-file-atexit-explicitly.c
    Profile :: instrprof-write-file-only.c
    Profile :: instrprof-write-file.c

  Expected Passes    : 149
  Expected Failures  : 26
  Unsupported Tests  : 91
  Unexpected Failures: 6


Thanks,
Greg

On 9 July 2014 18:23, Greg Fitzgerald <garious at gmail.com>
wrote:
> compiler-rt/test/profile/instrprof-write-file.c:13:12: error: expected
> string not found in input
>  // CHECK: br i1 %{{.*}}, label %{{.*}}, label %{{.*}}, !prof !1
>            ^
> <stdin>:17:2: note: possible intended match here
>  br i1 %cmp, label %if.then, label %if.end, !prof !3
Looks like a silly unnamed metadata stuff. You could add a variable to
cope with the different numbers. Something like

// CHECK: br i1 %{{.*}}, label %{{.*}}, label %{{.*}}, !prof ![[meta:.*]]
// CHECK: ![[meta]] = metadata !{metadata !"branch_weights", i32 1,
i32 2}

cheers,
--renato

> On 2014-Jul-09, at 11:01, Renato Golin <renato.golin at linaro.org>
wrote:
> 
> On 9 July 2014 18:23, Greg Fitzgerald <garious at gmail.com> wrote:
>> compiler-rt/test/profile/instrprof-write-file.c:13:12: error: expected
>> string not found in input
>> // CHECK: br i1 %{{.*}}, label %{{.*}}, label %{{.*}}, !prof !1
>>           ^
>> <stdin>:17:2: note: possible intended match here
>> br i1 %cmp, label %if.then, label %if.end, !prof !3
> 
> Looks like a silly unnamed metadata stuff. You could add a variable to
> cope with the different numbers. Something like
> 
> // CHECK: br i1 %{{.*}}, label %{{.*}}, label %{{.*}}, !prof ![[meta:.*]]
> // CHECK: ![[meta]] = metadata !{metadata !"branch_weights", i32
1, i32 2}
> 
> cheers,
> --renato
Can you file a PR and CC me?