Duncan P. N. Exon Smith
2014-Jun-27 20:52 UTC
[LLVMdev] Another phabricator feature request...
> On 2014-Jun-27, at 11:50, Michael Spencer <bigcheesegs at gmail.com> wrote: > > On Fri, Jun 27, 2014 at 11:39 AM, Chandler Carruth <chandlerc at gmail.com> wrote: >> I know you worked hard to make sure that updating a revision doesn't send >> email unless there is text typed into one of the boxes Manuel, but I think >> we should by default put some text into a box (and send the email unless the >> user deletes that text) when accepting a revision. Otherwise, the final LGTM >> can accidentally happen on Phab and not reach the mailing list (D4178 for >> example). >> >> Thoughts? >> > > Is there any reason not to have accepts always send an email? > > - Michael SpencerIf it's possible to make "accept" send an email with the text "LGTM", that would design away another source of discontinuity between the list and Phab.
Is there a Phab developer mailing list which this discussion could be moved to or cc'd? Maybe others on that list would like to join in or it would be more relevant there?
On Fri, Jun 27, 2014 at 11:05 PM, "C. Bergström" <cbergstrom at pathscale.com> wrote:> Is there a Phab developer mailing list which this discussion could be > moved to or cc'd? Maybe others on that list would like to join in or it > would be more relevant there?There's an IRC channel and phab's site / bug tracker (phabricator.com). The problem in this specific case is that it's only our phab instance that behaves that way (default phab spams emails on everything a user does). I'll work on the LGTM issue. Thanks! /Manuel> > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140630/7da372d2/attachment.html>