> Does %run support ssh-based testing?Yes, %run is configured by the user. I configure it to call a shell script that calls qemu-arm. It could just as easily ssh or "adb push && adb shell". -Greg On Wed, Apr 16, 2014 at 11:44 PM, Yury Gribov <y.gribov at samsung.com> wrote:> Greg, > > >> Clever, but I hope we can try to avoid the symlink hackery. Locally, >> I've renamed "%sim %t" to "%run %t" so it reads quite nicely, IMHO. > > Does %run support ssh-based testing? qemu-arm is cool but it does not > emulate threads and other low-level stuff well which may be important for > some users. > > -Y >
On Thu, Apr 17, 2014 at 12:24 PM, Greg Fitzgerald <garious at gmail.com> wrote:> > Does %run support ssh-based testing? > > Yes, %run is configured by the user. I configure it to call a shell > script that calls qemu-arm. It could just as easily ssh or "adb push > && adb shell". >Please discuss this with Evgeniy. We considered adding "%run" to all binary invocations, but dropped this idea. I don't remember the details, but IIRC %run is just not general enough. Some tests are not hermetic enough - for example, suppose that the test dlopen()'s a shared object - how would you copy this file to the device/emulator? Same holds for arguments of -fsanitize-blacklist=.> > -Greg > > > On Wed, Apr 16, 2014 at 11:44 PM, Yury Gribov <y.gribov at samsung.com> > wrote: > > Greg, > > > > > >> Clever, but I hope we can try to avoid the symlink hackery. Locally, > >> I've renamed "%sim %t" to "%run %t" so it reads quite nicely, IMHO. > > > > Does %run support ssh-based testing? qemu-arm is cool but it does not > > emulate threads and other low-level stuff well which may be important for > > some users. > > > > -Y > > >-- Alexey Samsonov, Mountain View, CA -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140418/0a473c25/attachment.html>
On 04/17/2014 11:24 PM, Greg Fitzgerald wrote:>> Does %run support ssh-based testing? > > Yes, %run is configured by the user. I configure it to call a shell > script that calls qemu-arm. It could just as easily ssh or "adb push > && adb shell".It's not that easy. Some tests require passing environment variables (which aren't transparently forwarded by ssh/adb) and some require several objects to run (e.g. executable + dynamic library). It sounds like the only way would be to support this in %run would be to parse all lit commands (not just %run-command btw), detect environments variables and all objects that executable depends on, copy them to device, etc. Frankly I'm not sure %run will be robust solution for anything but qemu-arm. -Y
> We considered adding "%run" to all binary invocations, > but dropped this idea. I don't remember the details, but IIRC %run is > just not general enough.IMHO this is where simplicity of lit approach starts to fail - important information (environment variables, dependent shared libs, expected test status, etc.) is buried inside arbitrarily complex runstrings. -Y