Tom (and Andy, Owen, Evan, Nadav), I'd like the following commits placed into the 3.4.1 branch. I've attempted to sort this list by code owner: Andrew Trick: r203719 - PR17473 r203725 - This test need the X86 backend, move it to the X86 sub directory. [adjusts the test location from r203719] r202273 - Fix PR18165: LSR must avoid scaling factors that exceed the limit on truncated use. r201104 - [LPM] A terribly simple fix to a terribly complex bug: PR18773. r198863 - Fixed old typo in ScalarEvolution, that caused wrong SCEVs zext operation. Owen Anderson: r200201 - Fix for PR18102. r200202 - Additional fix for 200201: due to dependence on bitwidth test was moved to X86 directory. r200705 - Expand vector bswap in LegalizeVectorOps r205738 - Put a limit on ScheduleDAGSDNodes::ClusterNeighboringLoads to avoid blowing up compile time. Evan Cheng: r200028 - InstCombine: Don't try to use aggregate elements of ConstantExprs. r199351 - BasicAA: We need to check both access sizes when comparing a gep and an r198290 - BasicAA: Fix value equality and phi cycles r198400 - BasicAA: Use reachabilty instead of dominance for checking value equality in phi Nadav Rotem: r199570 - LoopVectorizer: A reduction that has multiple uses of the reduction value is not r199291 - LoopVectorize: Only strip casts from integer types when replacing symbolic Also, please include the following patches in 3.4.1. I am the code owner, and I approve ;) r205630 - [PowerPC] Add a full condition code register to make the "cc" clobber work r204155 - Fix PR19144: Incorrect offset generated for int-to-fp conversion at -O0 r203054 - The PPC global base register cannot be r0 r199832 - Fix pr18515. r200288 - Handle spilling the PPC GPRC_NOR0 register class r199763 - Fix pointer info on PPC byval stores r202192 - Account for 128-bit integer operations in PPCCTRLoops r198425 - Fix loop rerolling pass failure with non-consant loop lower bound I apologize the delay; I've not had a chance to refine my list until this morning. Thanks again, Hal ----- Original Message -----> From: "Hal Finkel" <hfinkel at anl.gov> > To: "Tom Stellard" <tom at stellard.net> > Cc: "Ben Pope" <benpope81 at gmail.com>, llvmdev at cs.uiuc.edu, "Erik Verbruggen" <erik.verbruggen at me.com> > Sent: Thursday, March 27, 2014 7:49:36 AM > Subject: Re: [LLVMdev] 3.4.1 Release Plans > > ----- Original Message ----- > > From: "Tom Stellard" <tom at stellard.net> > > To: llvmdev at cs.uiuc.edu > > Cc: "Renato Golin" <renato.golin at linaro.org>, "Sylvestre Ledru" > > <sylvestre at debian.org>, "Sebastian Dreßler" > > <sebastian.dressler at gmail.com>, "Hal Finkel" <hfinkel at anl.gov>, > > "Ben Pope" <benpope81 at gmail.com>, "Arnaud Allard de > > Grandmaison" <arnaud.adegm at gmail.com>, "Erik Verbruggen" > > <erik.verbruggen at me.com> > > Sent: Wednesday, March 26, 2014 11:10:43 AM > > Subject: 3.4.1 Release Plans > > > > Hi, > > > > We are now about halfway between the 3.4 and 3.5 releases, and I > > would > > like to start preparing for a 3.4.1 release. Here is my proposed > > release > > schedule: > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the > > 3.4 branch. > > April 9 - April 18: Testing Phase > > April 18: 3.4.1 Release > > > > How you can help: > > > > - If you have any bug fixes you think should be included to 3.4.1, > > send > > me an email with the SVN revision in trunk and also cc the code > > owner > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > - Start integrating the 3.4 branch into your project or OS > > distribution > > to and check for any issues. > > > > - Volunteer as a tester for the testing phase. > > I'll go through the commit list shortly; also I'll help with testing > on (X86 and PPC64). > > Thanks again for working on this! > > -Hal > > > > > Thank you, > > > > Tom > > > > -- > Hal Finkel > Assistant Computational Scientist > Leadership Computing Facility > Argonne National Laboratory > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory
On Apr 8, 2014, at 9:53 AM, Hal Finkel <hfinkel at anl.gov> wrote:> I'd like the following commits placed into the 3.4.1 branch. I've attempted to sort this list by code owner: > > Andrew Trick: > r203719 - PR17473 > r203725 - This test need the X86 backend, move it to the X86 sub directory. [adjusts the test location from r203719] > > r202273 - Fix PR18165: LSR must avoid scaling factors that exceed the limit on truncated use. > > r201104 - [LPM] A terribly simple fix to a terribly complex bug: PR18773. > > r198863 - Fixed old typo in ScalarEvolution, that caused wrong SCEVs zext operation.I approve! -Andy -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/4a02ba2c/attachment.html>
I approve. —Owen On Apr 8, 2014, at 9:53 AM, Hal Finkel <hfinkel at anl.gov> wrote:> Owen Anderson: > r200201 - Fix for PR18102. > r200202 - Additional fix for 200201: due to dependence on bitwidth test was moved to X86 directory. > > r200705 - Expand vector bswap in LegalizeVectorOps > > r205738 - Put a limit on ScheduleDAGSDNodes::ClusterNeighboringLoads to avoid blowing up compile time.-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/a0df3304/attachment.html>
On Tue, Apr 08, 2014 at 10:35:02AM -0700, Andrew Trick wrote:> > On Apr 8, 2014, at 9:53 AM, Hal Finkel <hfinkel at anl.gov> wrote: > > > I'd like the following commits placed into the 3.4.1 branch. I've attempted to sort this list by code owner: > > > > Andrew Trick: > > r203719 - PR17473 > > r203725 - This test need the X86 backend, move it to the X86 sub directory. [adjusts the test location from r203719] > > > > r202273 - Fix PR18165: LSR must avoid scaling factors that exceed the limit on truncated use. > > > > r201104 - [LPM] A terribly simple fix to a terribly complex bug: PR18773. > > > > r198863 - Fixed old typo in ScalarEvolution, that caused wrong SCEVs zext operation. > > I approve! > > -AndyI just merged these patches. -Tom
On Tue, Apr 08, 2014 at 11:53:38AM -0500, Hal Finkel wrote:> Tom (and Andy, Owen, Evan, Nadav), > > I'd like the following commits placed into the 3.4.1 branch. I've attempted to sort this list by code owner: > > Andrew Trick: > r203719 - PR17473 > r203725 - This test need the X86 backend, move it to the X86 sub directory. [adjusts the test location from r203719] > > r202273 - Fix PR18165: LSR must avoid scaling factors that exceed the limit on truncated use. > > r201104 - [LPM] A terribly simple fix to a terribly complex bug: PR18773. > > r198863 - Fixed old typo in ScalarEvolution, that caused wrong SCEVs zext operation. > > Owen Anderson: > r200201 - Fix for PR18102. > r200202 - Additional fix for 200201: due to dependence on bitwidth test was moved to X86 directory. > > r200705 - Expand vector bswap in LegalizeVectorOps >Hi Hal, I was able to merge all the fixes approved by Owen, except for r200705. The test case for that commit doesn't pass on the 3.4 branch. I've attached the output from llc and FileCheck. Could you send me an updated patch with a test case that work on 3.4? Thanks, Tom -------------- next part -------------- FILECHECK: /home/tstellar/llvm/Release+Asserts/bin/llc < /home/tstellar/llvm/test/CodeGen/X86/bswap-vector.ll -mcpu=x86_64 | /home/tstellar/llvm/Release+Asserts/bin/FileCheck /home/tstellar/llvm/test/CodeGen/X86/bswap-vector.ll 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) /home/tstellar/llvm/test/CodeGen/X86/bswap-vector.ll:16:10: error: expected string not found in input ; CHECK: retq ^ <stdin>:14:9: note: scanning from here bswapq %rax ^ <stdin>:18:2: note: possible intended match here ret ^ LLC: /home/tstellar/llvm/Release+Asserts/bin/llc < /home/tstellar/llvm/test/CodeGen/X86/bswap-vector.ll -mcpu=x86_64 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) 'x86_64' is not a recognized processor for this target (ignoring processor) .file "<stdin>" .text .globl foo .align 16, 0x90 .type foo, at function foo: # @foo .cfi_startproc # BB#0: # %entry movd %xmm0, %rax bswapq %rax movd %rax, %xmm1 punpckhqdq %xmm0, %xmm0 # xmm0 = xmm0[1,1] movd %xmm0, %rax bswapq %rax movd %rax, %xmm0 punpcklqdq %xmm0, %xmm1 # xmm1 = xmm1[0],xmm0[0] movdqa %xmm1, %xmm0 ret .Ltmp0: .size foo, .Ltmp0-foo .cfi_endproc
Hi Hal,> Nadav Rotem: > r199570 - LoopVectorizer: A reduction that has multiple uses of the reduction value is not > > r199291 - LoopVectorize: Only strip casts from integer types when replacing symbolicThis commit changes the functions replaceSymbolicStrideSCEV() and InnerLoopVectorizer::addStrideCheck(), which were both added in r198950, so when I apply it to 3.4 nothing changes. If the bug fixed by this commit is present in 3.4, you may need to come up with a different patch to fix it.> Also, please include the following patches in 3.4.1. I am the code owner, and I approve ;) > > r205630 - [PowerPC] Add a full condition code register to make the "cc" clobber workThe test case for this fails on the 3.4 branch, so I was not able to merge it. The problem is that cmpld instructions are generated instead of cmpd. Can you take a look?> r204155 - Fix PR19144: Incorrect offset generated for int-to-fp conversion at -O0 > r203054 - The PPC global base register cannot be r0 > r199832 - Fix pr18515. > r200288 - Handle spilling the PPC GPRC_NOR0 register class > r199763 - Fix pointer info on PPC byval stores > r202192 - Account for 128-bit integer operations in PPCCTRLoops > > r198425 - Fix loop rerolling pass failure with non-consant loop lower bound >The rest of the patches approved by you and Nadav have been merged. -Tom> I apologize the delay; I've not had a chance to refine my list until this morning. > > Thanks again, > Hal > > ----- Original Message ----- > > From: "Hal Finkel" <hfinkel at anl.gov> > > To: "Tom Stellard" <tom at stellard.net> > > Cc: "Ben Pope" <benpope81 at gmail.com>, llvmdev at cs.uiuc.edu, "Erik Verbruggen" <erik.verbruggen at me.com> > > Sent: Thursday, March 27, 2014 7:49:36 AM > > Subject: Re: [LLVMdev] 3.4.1 Release Plans > > > > ----- Original Message ----- > > > From: "Tom Stellard" <tom at stellard.net> > > > To: llvmdev at cs.uiuc.edu > > > Cc: "Renato Golin" <renato.golin at linaro.org>, "Sylvestre Ledru" > > > <sylvestre at debian.org>, "Sebastian Dreßler" > > > <sebastian.dressler at gmail.com>, "Hal Finkel" <hfinkel at anl.gov>, > > > "Ben Pope" <benpope81 at gmail.com>, "Arnaud Allard de > > > Grandmaison" <arnaud.adegm at gmail.com>, "Erik Verbruggen" > > > <erik.verbruggen at me.com> > > > Sent: Wednesday, March 26, 2014 11:10:43 AM > > > Subject: 3.4.1 Release Plans > > > > > > Hi, > > > > > > We are now about halfway between the 3.4 and 3.5 releases, and I > > > would > > > like to start preparing for a 3.4.1 release. Here is my proposed > > > release > > > schedule: > > > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the > > > 3.4 branch. > > > April 9 - April 18: Testing Phase > > > April 18: 3.4.1 Release > > > > > > How you can help: > > > > > > - If you have any bug fixes you think should be included to 3.4.1, > > > send > > > me an email with the SVN revision in trunk and also cc the code > > > owner > > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > > > - Start integrating the 3.4 branch into your project or OS > > > distribution > > > to and check for any issues. > > > > > > - Volunteer as a tester for the testing phase. > > > > I'll go through the commit list shortly; also I'll help with testing > > on (X86 and PPC64). > > > > Thanks again for working on this! > > > > -Hal > > > > > > > > Thank you, > > > > > > Tom > > > > > > > -- > > Hal Finkel > > Assistant Computational Scientist > > Leadership Computing Facility > > Argonne National Laboratory > > > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > -- > Hal Finkel > Assistant Computational Scientist > Leadership Computing Facility > Argonne National Laboratory
----- Original Message -----> From: "Tom Stellard" <tom at stellard.net> > To: "Hal Finkel" <hfinkel at anl.gov> > Cc: "Andrew Trick" <atrick at apple.com>, "Owen Anderson" <owen at apple.com>, "Evan Cheng" <evan.cheng at apple.com>, "nadav" > <nadav at apple.com>, "Ben Pope" <benpope81 at gmail.com>, llvmdev at cs.uiuc.edu, "Erik Verbruggen" <erik.verbruggen at me.com> > Sent: Tuesday, April 8, 2014 7:28:01 PM > Subject: Re: [LLVMdev] 3.4.1 Release Plans > > Hi Hal, > > > Nadav Rotem: > > r199570 - LoopVectorizer: A reduction that has multiple uses of the > > reduction value is not > > > > r199291 - LoopVectorize: Only strip casts from integer types when > > replacing symbolic > > This commit changes the functions > replaceSymbolicStrideSCEV() and > InnerLoopVectorizer::addStrideCheck(), > which were both added in r198950, so when I apply it to 3.4 nothing > changes. If the bug fixed by this commit is present in 3.4, you may > need to come up with a different patch to fix it.I'm sorry, you're right. There is nothing to fix there in 3.4.> > > Also, please include the following patches in 3.4.1. I am the code > > owner, and I approve ;) > > > > r205630 - [PowerPC] Add a full condition code register to make the > > "cc" clobber work > > The test case for this fails on the 3.4 branch, so I was not able to > merge it. The problem is that cmpld instructions are generated > instead of > cmpd. Can you take a look?Will do shortly (but I'll cc llvm-commits instead of llvmdev). -Hal> > > r204155 - Fix PR19144: Incorrect offset generated for int-to-fp > > conversion at -O0 > > r203054 - The PPC global base register cannot be r0 > > r199832 - Fix pr18515. > > r200288 - Handle spilling the PPC GPRC_NOR0 register class > > r199763 - Fix pointer info on PPC byval stores > > r202192 - Account for 128-bit integer operations in PPCCTRLoops > > > > r198425 - Fix loop rerolling pass failure with non-consant loop > > lower bound > > > > The rest of the patches approved by you and Nadav have been merged. > > -Tom > > > I apologize the delay; I've not had a chance to refine my list > > until this morning. > > > > Thanks again, > > Hal > > > > ----- Original Message ----- > > > From: "Hal Finkel" <hfinkel at anl.gov> > > > To: "Tom Stellard" <tom at stellard.net> > > > Cc: "Ben Pope" <benpope81 at gmail.com>, llvmdev at cs.uiuc.edu, "Erik > > > Verbruggen" <erik.verbruggen at me.com> > > > Sent: Thursday, March 27, 2014 7:49:36 AM > > > Subject: Re: [LLVMdev] 3.4.1 Release Plans > > > > > > ----- Original Message ----- > > > > From: "Tom Stellard" <tom at stellard.net> > > > > To: llvmdev at cs.uiuc.edu > > > > Cc: "Renato Golin" <renato.golin at linaro.org>, "Sylvestre Ledru" > > > > <sylvestre at debian.org>, "Sebastian Dreßler" > > > > <sebastian.dressler at gmail.com>, "Hal Finkel" <hfinkel at anl.gov>, > > > > "Ben Pope" <benpope81 at gmail.com>, "Arnaud Allard de > > > > Grandmaison" <arnaud.adegm at gmail.com>, "Erik Verbruggen" > > > > <erik.verbruggen at me.com> > > > > Sent: Wednesday, March 26, 2014 11:10:43 AM > > > > Subject: 3.4.1 Release Plans > > > > > > > > Hi, > > > > > > > > We are now about halfway between the 3.4 and 3.5 releases, and > > > > I > > > > would > > > > like to start preparing for a 3.4.1 release. Here is my > > > > proposed > > > > release > > > > schedule: > > > > > > > > Mar 26 - April 9: Identify and backport additional bug fixes to > > > > the > > > > 3.4 branch. > > > > April 9 - April 18: Testing Phase > > > > April 18: 3.4.1 Release > > > > > > > > How you can help: > > > > > > > > - If you have any bug fixes you think should be included to > > > > 3.4.1, > > > > send > > > > me an email with the SVN revision in trunk and also cc the > > > > code > > > > owner > > > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > > > > > - Start integrating the 3.4 branch into your project or OS > > > > distribution > > > > to and check for any issues. > > > > > > > > - Volunteer as a tester for the testing phase. > > > > > > I'll go through the commit list shortly; also I'll help with > > > testing > > > on (X86 and PPC64). > > > > > > Thanks again for working on this! > > > > > > -Hal > > > > > > > > > > > Thank you, > > > > > > > > Tom > > > > > > > > > > -- > > > Hal Finkel > > > Assistant Computational Scientist > > > Leadership Computing Facility > > > Argonne National Laboratory > > > > > > _______________________________________________ > > > LLVM Developers mailing list > > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > > > > -- > > Hal Finkel > > Assistant Computational Scientist > > Leadership Computing Facility > > Argonne National Laboratory >-- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory
I approve taking r200028. Thanks, Evan On Apr 8, 2014, at 9:53 AM, Hal Finkel <hfinkel at anl.gov> wrote:> Tom (and Andy, Owen, Evan, Nadav), > > I'd like the following commits placed into the 3.4.1 branch. I've attempted to sort this list by code owner: > > Andrew Trick: > r203719 - PR17473 > r203725 - This test need the X86 backend, move it to the X86 sub directory. [adjusts the test location from r203719] > > r202273 - Fix PR18165: LSR must avoid scaling factors that exceed the limit on truncated use. > > r201104 - [LPM] A terribly simple fix to a terribly complex bug: PR18773. > > r198863 - Fixed old typo in ScalarEvolution, that caused wrong SCEVs zext operation. > > Owen Anderson: > r200201 - Fix for PR18102. > r200202 - Additional fix for 200201: due to dependence on bitwidth test was moved to X86 directory. > > r200705 - Expand vector bswap in LegalizeVectorOps > > r205738 - Put a limit on ScheduleDAGSDNodes::ClusterNeighboringLoads to avoid blowing up compile time. > > Evan Cheng: > r200028 - InstCombine: Don't try to use aggregate elements of ConstantExprs. > > r199351 - BasicAA: We need to check both access sizes when comparing a gep and an > > r198290 - BasicAA: Fix value equality and phi cycles > r198400 - BasicAA: Use reachabilty instead of dominance for checking value equality in phi > > Nadav Rotem: > r199570 - LoopVectorizer: A reduction that has multiple uses of the reduction value is not > > r199291 - LoopVectorize: Only strip casts from integer types when replacing symbolic > > Also, please include the following patches in 3.4.1. I am the code owner, and I approve ;) > > r205630 - [PowerPC] Add a full condition code register to make the "cc" clobber work > r204155 - Fix PR19144: Incorrect offset generated for int-to-fp conversion at -O0 > r203054 - The PPC global base register cannot be r0 > r199832 - Fix pr18515. > r200288 - Handle spilling the PPC GPRC_NOR0 register class > r199763 - Fix pointer info on PPC byval stores > r202192 - Account for 128-bit integer operations in PPCCTRLoops > > r198425 - Fix loop rerolling pass failure with non-consant loop lower bound > > I apologize the delay; I've not had a chance to refine my list until this morning. > > Thanks again, > Hal > > ----- Original Message ----- >> From: "Hal Finkel" <hfinkel at anl.gov> >> To: "Tom Stellard" <tom at stellard.net> >> Cc: "Ben Pope" <benpope81 at gmail.com>, llvmdev at cs.uiuc.edu, "Erik Verbruggen" <erik.verbruggen at me.com> >> Sent: Thursday, March 27, 2014 7:49:36 AM >> Subject: Re: [LLVMdev] 3.4.1 Release Plans >> >> ----- Original Message ----- >>> From: "Tom Stellard" <tom at stellard.net> >>> To: llvmdev at cs.uiuc.edu >>> Cc: "Renato Golin" <renato.golin at linaro.org>, "Sylvestre Ledru" >>> <sylvestre at debian.org>, "Sebastian Dreßler" >>> <sebastian.dressler at gmail.com>, "Hal Finkel" <hfinkel at anl.gov>, >>> "Ben Pope" <benpope81 at gmail.com>, "Arnaud Allard de >>> Grandmaison" <arnaud.adegm at gmail.com>, "Erik Verbruggen" >>> <erik.verbruggen at me.com> >>> Sent: Wednesday, March 26, 2014 11:10:43 AM >>> Subject: 3.4.1 Release Plans >>> >>> Hi, >>> >>> We are now about halfway between the 3.4 and 3.5 releases, and I >>> would >>> like to start preparing for a 3.4.1 release. Here is my proposed >>> release >>> schedule: >>> >>> Mar 26 - April 9: Identify and backport additional bug fixes to the >>> 3.4 branch. >>> April 9 - April 18: Testing Phase >>> April 18: 3.4.1 Release >>> >>> How you can help: >>> >>> - If you have any bug fixes you think should be included to 3.4.1, >>> send >>> me an email with the SVN revision in trunk and also cc the code >>> owner >>> and llvm-commits (or cfe-commits if it is a clang patch). >>> >>> - Start integrating the 3.4 branch into your project or OS >>> distribution >>> to and check for any issues. >>> >>> - Volunteer as a tester for the testing phase. >> >> I'll go through the commit list shortly; also I'll help with testing >> on (X86 and PPC64). >> >> Thanks again for working on this! >> >> -Hal >> >>> >>> Thank you, >>> >>> Tom >>> >> >> -- >> Hal Finkel >> Assistant Computational Scientist >> Leadership Computing Facility >> Argonne National Laboratory >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > > -- > Hal Finkel > Assistant Computational Scientist > Leadership Computing Facility > Argonne National Laboratory
----- Original Message -----> From: "Evan Cheng" <evan.cheng at apple.com> > To: "Hal Finkel" <hfinkel at anl.gov> > Cc: "Tom Stellard" <tom at stellard.net>, "Andrew Trick" <atrick at apple.com>, "Owen Anderson" <owen at apple.com>, "nadav" > <nadav at apple.com>, "Ben Pope" <benpope81 at gmail.com>, "LLVM Dev" <llvmdev at cs.uiuc.edu>, "Erik Verbruggen" > <erik.verbruggen at me.com> > Sent: Wednesday, April 9, 2014 12:23:38 PM > Subject: Re: [LLVMdev] 3.4.1 Release Plans > > I approve taking r200028.Thanks! Do you not want to take the BasicAA fixes, or do you just want more time to look at them? [It looks like Tom is giving us all until Friday]. I would like to pull them into 3.4.1 because they fix miscompiles. -Hal> > Thanks, > > Evan > > On Apr 8, 2014, at 9:53 AM, Hal Finkel <hfinkel at anl.gov> wrote: > > > Tom (and Andy, Owen, Evan, Nadav), > > > > I'd like the following commits placed into the 3.4.1 branch. I've > > attempted to sort this list by code owner: > > > > Andrew Trick: > > r203719 - PR17473 > > r203725 - This test need the X86 backend, move it to the X86 sub > > directory. [adjusts the test location from r203719] > > > > r202273 - Fix PR18165: LSR must avoid scaling factors that exceed > > the limit on truncated use. > > > > r201104 - [LPM] A terribly simple fix to a terribly complex bug: > > PR18773. > > > > r198863 - Fixed old typo in ScalarEvolution, that caused wrong > > SCEVs zext operation. > > > > Owen Anderson: > > r200201 - Fix for PR18102. > > r200202 - Additional fix for 200201: due to dependence on bitwidth > > test was moved to X86 directory. > > > > r200705 - Expand vector bswap in LegalizeVectorOps > > > > r205738 - Put a limit on > > ScheduleDAGSDNodes::ClusterNeighboringLoads to avoid blowing up > > compile time. > > > > Evan Cheng: > > r200028 - InstCombine: Don't try to use aggregate elements of > > ConstantExprs. > > > > r199351 - BasicAA: We need to check both access sizes when > > comparing a gep and an > > > > r198290 - BasicAA: Fix value equality and phi cycles > > r198400 - BasicAA: Use reachabilty instead of dominance for > > checking value equality in phi > > > > Nadav Rotem: > > r199570 - LoopVectorizer: A reduction that has multiple uses of the > > reduction value is not > > > > r199291 - LoopVectorize: Only strip casts from integer types when > > replacing symbolic > > > > Also, please include the following patches in 3.4.1. I am the code > > owner, and I approve ;) > > > > r205630 - [PowerPC] Add a full condition code register to make the > > "cc" clobber work > > r204155 - Fix PR19144: Incorrect offset generated for int-to-fp > > conversion at -O0 > > r203054 - The PPC global base register cannot be r0 > > r199832 - Fix pr18515. > > r200288 - Handle spilling the PPC GPRC_NOR0 register class > > r199763 - Fix pointer info on PPC byval stores > > r202192 - Account for 128-bit integer operations in PPCCTRLoops > > > > r198425 - Fix loop rerolling pass failure with non-consant loop > > lower bound > > > > I apologize the delay; I've not had a chance to refine my list > > until this morning. > > > > Thanks again, > > Hal > > > > ----- Original Message ----- > >> From: "Hal Finkel" <hfinkel at anl.gov> > >> To: "Tom Stellard" <tom at stellard.net> > >> Cc: "Ben Pope" <benpope81 at gmail.com>, llvmdev at cs.uiuc.edu, "Erik > >> Verbruggen" <erik.verbruggen at me.com> > >> Sent: Thursday, March 27, 2014 7:49:36 AM > >> Subject: Re: [LLVMdev] 3.4.1 Release Plans > >> > >> ----- Original Message ----- > >>> From: "Tom Stellard" <tom at stellard.net> > >>> To: llvmdev at cs.uiuc.edu > >>> Cc: "Renato Golin" <renato.golin at linaro.org>, "Sylvestre Ledru" > >>> <sylvestre at debian.org>, "Sebastian Dreßler" > >>> <sebastian.dressler at gmail.com>, "Hal Finkel" <hfinkel at anl.gov>, > >>> "Ben Pope" <benpope81 at gmail.com>, "Arnaud Allard de > >>> Grandmaison" <arnaud.adegm at gmail.com>, "Erik Verbruggen" > >>> <erik.verbruggen at me.com> > >>> Sent: Wednesday, March 26, 2014 11:10:43 AM > >>> Subject: 3.4.1 Release Plans > >>> > >>> Hi, > >>> > >>> We are now about halfway between the 3.4 and 3.5 releases, and I > >>> would > >>> like to start preparing for a 3.4.1 release. Here is my proposed > >>> release > >>> schedule: > >>> > >>> Mar 26 - April 9: Identify and backport additional bug fixes to > >>> the > >>> 3.4 branch. > >>> April 9 - April 18: Testing Phase > >>> April 18: 3.4.1 Release > >>> > >>> How you can help: > >>> > >>> - If you have any bug fixes you think should be included to > >>> 3.4.1, > >>> send > >>> me an email with the SVN revision in trunk and also cc the code > >>> owner > >>> and llvm-commits (or cfe-commits if it is a clang patch). > >>> > >>> - Start integrating the 3.4 branch into your project or OS > >>> distribution > >>> to and check for any issues. > >>> > >>> - Volunteer as a tester for the testing phase. > >> > >> I'll go through the commit list shortly; also I'll help with > >> testing > >> on (X86 and PPC64). > >> > >> Thanks again for working on this! > >> > >> -Hal > >> > >>> > >>> Thank you, > >>> > >>> Tom > >>> > >> > >> -- > >> Hal Finkel > >> Assistant Computational Scientist > >> Leadership Computing Facility > >> Argonne National Laboratory > >> > >> _______________________________________________ > >> LLVM Developers mailing list > >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >> > > > > -- > > Hal Finkel > > Assistant Computational Scientist > > Leadership Computing Facility > > Argonne National Laboratory > >-- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory
On Wed, Apr 09, 2014 at 10:23:38AM -0700, Evan Cheng wrote:> I approve taking r200028.This patch has been merged. -Tom> > Thanks, > > Evan > > On Apr 8, 2014, at 9:53 AM, Hal Finkel <hfinkel at anl.gov> wrote: > > > Tom (and Andy, Owen, Evan, Nadav), > > > > I'd like the following commits placed into the 3.4.1 branch. I've attempted to sort this list by code owner: > > > > Andrew Trick: > > r203719 - PR17473 > > r203725 - This test need the X86 backend, move it to the X86 sub directory. [adjusts the test location from r203719] > > > > r202273 - Fix PR18165: LSR must avoid scaling factors that exceed the limit on truncated use. > > > > r201104 - [LPM] A terribly simple fix to a terribly complex bug: PR18773. > > > > r198863 - Fixed old typo in ScalarEvolution, that caused wrong SCEVs zext operation. > > > > Owen Anderson: > > r200201 - Fix for PR18102. > > r200202 - Additional fix for 200201: due to dependence on bitwidth test was moved to X86 directory. > > > > r200705 - Expand vector bswap in LegalizeVectorOps > > > > r205738 - Put a limit on ScheduleDAGSDNodes::ClusterNeighboringLoads to avoid blowing up compile time. > > > > Evan Cheng: > > r200028 - InstCombine: Don't try to use aggregate elements of ConstantExprs. > > > > r199351 - BasicAA: We need to check both access sizes when comparing a gep and an > > > > r198290 - BasicAA: Fix value equality and phi cycles > > r198400 - BasicAA: Use reachabilty instead of dominance for checking value equality in phi > > > > Nadav Rotem: > > r199570 - LoopVectorizer: A reduction that has multiple uses of the reduction value is not > > > > r199291 - LoopVectorize: Only strip casts from integer types when replacing symbolic > > > > Also, please include the following patches in 3.4.1. I am the code owner, and I approve ;) > > > > r205630 - [PowerPC] Add a full condition code register to make the "cc" clobber work > > r204155 - Fix PR19144: Incorrect offset generated for int-to-fp conversion at -O0 > > r203054 - The PPC global base register cannot be r0 > > r199832 - Fix pr18515. > > r200288 - Handle spilling the PPC GPRC_NOR0 register class > > r199763 - Fix pointer info on PPC byval stores > > r202192 - Account for 128-bit integer operations in PPCCTRLoops > > > > r198425 - Fix loop rerolling pass failure with non-consant loop lower bound > > > > I apologize the delay; I've not had a chance to refine my list until this morning. > > > > Thanks again, > > Hal > > > > ----- Original Message ----- > >> From: "Hal Finkel" <hfinkel at anl.gov> > >> To: "Tom Stellard" <tom at stellard.net> > >> Cc: "Ben Pope" <benpope81 at gmail.com>, llvmdev at cs.uiuc.edu, "Erik Verbruggen" <erik.verbruggen at me.com> > >> Sent: Thursday, March 27, 2014 7:49:36 AM > >> Subject: Re: [LLVMdev] 3.4.1 Release Plans > >> > >> ----- Original Message ----- > >>> From: "Tom Stellard" <tom at stellard.net> > >>> To: llvmdev at cs.uiuc.edu > >>> Cc: "Renato Golin" <renato.golin at linaro.org>, "Sylvestre Ledru" > >>> <sylvestre at debian.org>, "Sebastian Dreßler" > >>> <sebastian.dressler at gmail.com>, "Hal Finkel" <hfinkel at anl.gov>, > >>> "Ben Pope" <benpope81 at gmail.com>, "Arnaud Allard de > >>> Grandmaison" <arnaud.adegm at gmail.com>, "Erik Verbruggen" > >>> <erik.verbruggen at me.com> > >>> Sent: Wednesday, March 26, 2014 11:10:43 AM > >>> Subject: 3.4.1 Release Plans > >>> > >>> Hi, > >>> > >>> We are now about halfway between the 3.4 and 3.5 releases, and I > >>> would > >>> like to start preparing for a 3.4.1 release. Here is my proposed > >>> release > >>> schedule: > >>> > >>> Mar 26 - April 9: Identify and backport additional bug fixes to the > >>> 3.4 branch. > >>> April 9 - April 18: Testing Phase > >>> April 18: 3.4.1 Release > >>> > >>> How you can help: > >>> > >>> - If you have any bug fixes you think should be included to 3.4.1, > >>> send > >>> me an email with the SVN revision in trunk and also cc the code > >>> owner > >>> and llvm-commits (or cfe-commits if it is a clang patch). > >>> > >>> - Start integrating the 3.4 branch into your project or OS > >>> distribution > >>> to and check for any issues. > >>> > >>> - Volunteer as a tester for the testing phase. > >> > >> I'll go through the commit list shortly; also I'll help with testing > >> on (X86 and PPC64). > >> > >> Thanks again for working on this! > >> > >> -Hal > >> > >>> > >>> Thank you, > >>> > >>> Tom > >>> > >> > >> -- > >> Hal Finkel > >> Assistant Computational Scientist > >> Leadership Computing Facility > >> Argonne National Laboratory > >> > >> _______________________________________________ > >> LLVM Developers mailing list > >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >> > > > > -- > > Hal Finkel > > Assistant Computational Scientist > > Leadership Computing Facility > > Argonne National Laboratory >