Hi Robert, Can you ping the code owners about these patches. It might be good to write a separate email per code owner and cc the appropriate -commits list. Thanks, Tom On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote:> Hi Tom, > > I would like to nominate the following patches to be backported to 3.4.1 > > Clang: > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com> - Fix an logic error in the > clang driver preventing crtfastmath.o from linking when -Ofast is used > without -ffast-math > > LLVM: > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com> - [x86] Fix printing of > register operands with q modifier > 2. r203581 - Hans Wennborg <hans at hanshq.net> - X86: Don't generate 64-bit > movd after cmpneqsd in 32-bit mode (PR19059) > 3. r203146 - Reid Kleckner <reid at kleckner.net> - MS asm: The initial dot in > struct access is optional > 4. r202774 - Reid Kleckner <reid at kleckner.net> - MC: Fix Intel assembly > parser for [global + offset] > 5. r201507 - Craig Topper <craig.topper at gmail.com> - Fix diassembler > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore the > base register entirely. Mod=01/10 should treat this as R13 plus > displacment. Fixes PR18860 > 6. r201126 - Robert Khasanov - Changed attributes of all gather intrinsics > from IntrReadMem to IntrReadArgMem as they access only memory based on > argument. > > Most patches fix different stable issues on X86 target. > > Thanks, > Robert > > > > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net>: > > > Hi, > > > > We are now about halfway between the 3.4 and 3.5 releases, and I would > > like to start preparing for a 3.4.1 release. Here is my proposed release > > schedule: > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the 3.4 > > branch. > > April 9 - April 18: Testing Phase > > April 18: 3.4.1 Release > > > > How you can help: > > > > - If you have any bug fixes you think should be included to 3.4.1, send > > me an email with the SVN revision in trunk and also cc the code owner > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > - Start integrating the 3.4 branch into your project or OS distribution > > to and check for any issues. > > > > - Volunteer as a tester for the testing phase. > > > > Thank you, > > > > Tom > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >
Hi Reid, Would you approve your patches r203146 and r202774 to be backported to 3.4.1? They fix stability issues in x86 asm. Thanks, Robert понедельник, 7 апреля 2014 г. пользователь Tom Stellard написал:> Hi Robert, > > Can you ping the code owners about these patches. It might be good > to write a separate email per code owner and cc the appropriate -commits > list. > > Thanks, > Tom > > On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: > > Hi Tom, > > > > I would like to nominate the following patches to be backported to 3.4.1 > > > > Clang: > > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com <javascript:;>> - Fix an > logic error in the > > clang driver preventing crtfastmath.o from linking when -Ofast is used > > without -ffast-math > > > > LLVM: > > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com <javascript:;>> - > [x86] Fix printing of > > register operands with q modifier > > 2. r203581 - Hans Wennborg <hans at hanshq.net <javascript:;>> - X86: > Don't generate 64-bit > > movd after cmpneqsd in 32-bit mode (PR19059) > > 3. r203146 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MS asm: > The initial dot in > > struct access is optional > > 4. r202774 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MC: Fix > Intel assembly > > parser for [global + offset] > > 5. r201507 - Craig Topper <craig.topper at gmail.com <javascript:;>> - Fix > diassembler > > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore the > > base register entirely. Mod=01/10 should treat this as R13 plus > > displacment. Fixes PR18860 > > 6. r201126 - Robert Khasanov - Changed attributes of all gather > intrinsics > > from IntrReadMem to IntrReadArgMem as they access only memory based on > > argument. > > > > Most patches fix different stable issues on X86 target. > > > > Thanks, > > Robert > > > > > > > > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net <javascript:;> > >: > > > > > Hi, > > > > > > We are now about halfway between the 3.4 and 3.5 releases, and I would > > > like to start preparing for a 3.4.1 release. Here is my proposed > release > > > schedule: > > > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the 3.4 > > > branch. > > > April 9 - April 18: Testing Phase > > > April 18: 3.4.1 Release > > > > > > How you can help: > > > > > > - If you have any bug fixes you think should be included to 3.4.1, send > > > me an email with the SVN revision in trunk and also cc the code owner > > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > > > - Start integrating the 3.4 branch into your project or OS distribution > > > to and check for any issues. > > > > > > - Volunteer as a tester for the testing phase. > > > > > > Thank you, > > > > > > Tom > > > _______________________________________________ > > > LLVM Developers mailing list > > > LLVMdev at cs.uiuc.edu <javascript:;> http://llvm.cs.uiuc.edu > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/ab9b5759/attachment.html>
Hi Craig, Would you approve r201507(your) and r201126(my) patches to be backported to 3.4.1? These patches fix stability issues on x86. понедельник, 7 апреля 2014 г. пользователь Tom Stellard написал:> Hi Robert, > > Can you ping the code owners about these patches. It might be good > to write a separate email per code owner and cc the appropriate -commits > list. > > Thanks, > Tom > > On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: > > Hi Tom, > > > > I would like to nominate the following patches to be backported to 3.4.1 > > > > Clang: > > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com <javascript:;>> - Fix an > logic error in the > > clang driver preventing crtfastmath.o from linking when -Ofast is used > > without -ffast-math > > > > LLVM: > > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com <javascript:;>> - > [x86] Fix printing of > > register operands with q modifier > > 2. r203581 - Hans Wennborg <hans at hanshq.net <javascript:;>> - X86: > Don't generate 64-bit > > movd after cmpneqsd in 32-bit mode (PR19059) > > 3. r203146 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MS asm: > The initial dot in > > struct access is optional > > 4. r202774 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MC: Fix > Intel assembly > > parser for [global + offset] > > 5. r201507 - Craig Topper <craig.topper at gmail.com <javascript:;>> - Fix > diassembler > > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore the > > base register entirely. Mod=01/10 should treat this as R13 plus > > displacment. Fixes PR18860 > > 6. r201126 - Robert Khasanov - Changed attributes of all gather > intrinsics > > from IntrReadMem to IntrReadArgMem as they access only memory based on > > argument. > > > > Most patches fix different stable issues on X86 target. > > > > Thanks, > > Robert > > > > > > > > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net <javascript:;> > >: > > > > > Hi, > > > > > > We are now about halfway between the 3.4 and 3.5 releases, and I would > > > like to start preparing for a 3.4.1 release. Here is my proposed > release > > > schedule: > > > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the 3.4 > > > branch. > > > April 9 - April 18: Testing Phase > > > April 18: 3.4.1 Release > > > > > > How you can help: > > > > > > - If you have any bug fixes you think should be included to 3.4.1, send > > > me an email with the SVN revision in trunk and also cc the code owner > > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > > > - Start integrating the 3.4 branch into your project or OS distribution > > > to and check for any issues. > > > > > > - Volunteer as a tester for the testing phase. > > > > > > Thank you, > > > > > > Tom > > > _______________________________________________ > > > LLVM Developers mailing list > > > LLVMdev at cs.uiuc.edu <javascript:;> http://llvm.cs.uiuc.edu > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/83fe5767/attachment.html>
Hi Hans, Would you approve your patch r203581 to be backported to 3.4.1? It fixes stability issue on x86. Thanks, Robert. понедельник, 7 апреля 2014 г. пользователь Tom Stellard написал:> Hi Robert, > > Can you ping the code owners about these patches. It might be good > to write a separate email per code owner and cc the appropriate -commits > list. > > Thanks, > Tom > > On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: > > Hi Tom, > > > > I would like to nominate the following patches to be backported to 3.4.1 > > > > Clang: > > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com <javascript:;>> - Fix an > logic error in the > > clang driver preventing crtfastmath.o from linking when -Ofast is used > > without -ffast-math > > > > LLVM: > > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com <javascript:;>> - > [x86] Fix printing of > > register operands with q modifier > > 2. r203581 - Hans Wennborg <hans at hanshq.net <javascript:;>> - X86: > Don't generate 64-bit > > movd after cmpneqsd in 32-bit mode (PR19059) > > 3. r203146 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MS asm: > The initial dot in > > struct access is optional > > 4. r202774 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MC: Fix > Intel assembly > > parser for [global + offset] > > 5. r201507 - Craig Topper <craig.topper at gmail.com <javascript:;>> - Fix > diassembler > > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore the > > base register entirely. Mod=01/10 should treat this as R13 plus > > displacment. Fixes PR18860 > > 6. r201126 - Robert Khasanov - Changed attributes of all gather > intrinsics > > from IntrReadMem to IntrReadArgMem as they access only memory based on > > argument. > > > > Most patches fix different stable issues on X86 target. > > > > Thanks, > > Robert > > > > > > > > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net <javascript:;> > >: > > > > > Hi, > > > > > > We are now about halfway between the 3.4 and 3.5 releases, and I would > > > like to start preparing for a 3.4.1 release. Here is my proposed > release > > > schedule: > > > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the 3.4 > > > branch. > > > April 9 - April 18: Testing Phase > > > April 18: 3.4.1 Release > > > > > > How you can help: > > > > > > - If you have any bug fixes you think should be included to 3.4.1, send > > > me an email with the SVN revision in trunk and also cc the code owner > > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > > > - Start integrating the 3.4 branch into your project or OS distribution > > > to and check for any issues. > > > > > > - Volunteer as a tester for the testing phase. > > > > > > Thank you, > > > > > > Tom > > > _______________________________________________ > > > LLVM Developers mailing list > > > LLVMdev at cs.uiuc.edu <javascript:;> http://llvm.cs.uiuc.edu > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/cf092df6/attachment.html>
Hi Akira, Would you approve your patch r205067 to be backported to 3.4.1? It fixes stability issue on x86. Thanks, Robert. понедельник, 7 апреля 2014 г. пользователь Tom Stellard написал:> Hi Robert, > > Can you ping the code owners about these patches. It might be good > to write a separate email per code owner and cc the appropriate -commits > list. > > Thanks, > Tom > > On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: > > Hi Tom, > > > > I would like to nominate the following patches to be backported to 3.4.1 > > > > Clang: > > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com <javascript:;>> - Fix an > logic error in the > > clang driver preventing crtfastmath.o from linking when -Ofast is used > > without -ffast-math > > > > LLVM: > > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com <javascript:;>> - > [x86] Fix printing of > > register operands with q modifier > > 2. r203581 - Hans Wennborg <hans at hanshq.net <javascript:;>> - X86: > Don't generate 64-bit > > movd after cmpneqsd in 32-bit mode (PR19059) > > 3. r203146 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MS asm: > The initial dot in > > struct access is optional > > 4. r202774 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MC: Fix > Intel assembly > > parser for [global + offset] > > 5. r201507 - Craig Topper <craig.topper at gmail.com <javascript:;>> - Fix > diassembler > > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore the > > base register entirely. Mod=01/10 should treat this as R13 plus > > displacment. Fixes PR18860 > > 6. r201126 - Robert Khasanov - Changed attributes of all gather > intrinsics > > from IntrReadMem to IntrReadArgMem as they access only memory based on > > argument. > > > > Most patches fix different stable issues on X86 target. > > > > Thanks, > > Robert > > > > > > > > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net <javascript:;> > >: > > > > > Hi, > > > > > > We are now about halfway between the 3.4 and 3.5 releases, and I would > > > like to start preparing for a 3.4.1 release. Here is my proposed > release > > > schedule: > > > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the 3.4 > > > branch. > > > April 9 - April 18: Testing Phase > > > April 18: 3.4.1 Release > > > > > > How you can help: > > > > > > - If you have any bug fixes you think should be included to 3.4.1, send > > > me an email with the SVN revision in trunk and also cc the code owner > > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > > > - Start integrating the 3.4 branch into your project or OS distribution > > > to and check for any issues. > > > > > > - Volunteer as a tester for the testing phase. > > > > > > Thank you, > > > > > > Tom > > > _______________________________________________ > > > LLVM Developers mailing list > > > LLVMdev at cs.uiuc.edu <javascript:;> http://llvm.cs.uiuc.edu > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/7265c795/attachment.html>
Hi, I approve backporting of my patch to 3.4.1:> Clang: > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com> - Fix an logic error in the > clang driver preventing crtfastmath.o from linking when -Ofast is used > without -ffast-math2014-04-07 20:23 GMT+04:00 Tom Stellard <tom at stellard.net>:> Hi Robert, > > Can you ping the code owners about these patches. It might be good > to write a separate email per code owner and cc the appropriate -commits > list. > > Thanks, > Tom > > On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: > > Hi Tom, > > > > I would like to nominate the following patches to be backported to 3.4.1 > > > > Clang: > > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com> - Fix an logic error in > the > > clang driver preventing crtfastmath.o from linking when -Ofast is used > > without -ffast-math > > > > LLVM: > > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com> - [x86] Fix printing > of > > register operands with q modifier > > 2. r203581 - Hans Wennborg <hans at hanshq.net> - X86: Don't generate > 64-bit > > movd after cmpneqsd in 32-bit mode (PR19059) > > 3. r203146 - Reid Kleckner <reid at kleckner.net> - MS asm: The initial > dot in > > struct access is optional > > 4. r202774 - Reid Kleckner <reid at kleckner.net> - MC: Fix Intel assembly > > parser for [global + offset] > > 5. r201507 - Craig Topper <craig.topper at gmail.com> - Fix diassembler > > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore the > > base register entirely. Mod=01/10 should treat this as R13 plus > > displacment. Fixes PR18860 > > 6. r201126 - Robert Khasanov - Changed attributes of all gather > intrinsics > > from IntrReadMem to IntrReadArgMem as they access only memory based on > > argument. > > > > Most patches fix different stable issues on X86 target. > > > > Thanks, > > Robert > > > > > > > > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net>: > > > > > Hi, > > > > > > We are now about halfway between the 3.4 and 3.5 releases, and I would > > > like to start preparing for a 3.4.1 release. Here is my proposed > release > > > schedule: > > > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the 3.4 > > > branch. > > > April 9 - April 18: Testing Phase > > > April 18: 3.4.1 Release > > > > > > How you can help: > > > > > > - If you have any bug fixes you think should be included to 3.4.1, send > > > me an email with the SVN revision in trunk and also cc the code owner > > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > > > - Start integrating the 3.4 branch into your project or OS distribution > > > to and check for any issues. > > > > > > - Volunteer as a tester for the testing phase. > > > > > > Thank you, > > > > > > Tom > > > _______________________________________________ > > > LLVM Developers mailing list > > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/c00ee855/attachment.html>
Yep. Please backport r203146 and r202774, they should be fairly isolated. On Tue, Apr 8, 2014 at 5:08 AM, Robert Khasanov <rob.khasanov at gmail.com>wrote:> Hi Reid, > > Would you approve your patches r203146 and r202774 to be backported to > 3.4.1? They fix stability issues in x86 asm. > > Thanks, > Robert > > понедельник, 7 апреля 2014 г. пользователь Tom Stellard написал: > > Hi Robert, >> >> Can you ping the code owners about these patches. It might be good >> to write a separate email per code owner and cc the appropriate -commits >> list. >> >> Thanks, >> Tom >> >> On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: >> > Hi Tom, >> > >> > I would like to nominate the following patches to be backported to 3.4.1 >> > >> > Clang: >> > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com> - Fix an logic error in >> the >> > clang driver preventing crtfastmath.o from linking when -Ofast is used >> > without -ffast-math >> > >> > LLVM: >> > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com> - [x86] Fix printing >> of >> > register operands with q modifier >> > 2. r203581 - Hans Wennborg <hans at hanshq.net> - X86: Don't generate >> 64-bit >> > movd after cmpneqsd in 32-bit mode (PR19059) >> > 3. r203146 - Reid Kleckner <reid at kleckner.net> - MS asm: The initial >> dot in >> > struct access is optional >> > 4. r202774 - Reid Kleckner <reid at kleckner.net> - MC: Fix Intel assembly >> > parser for [global + offset] >> > 5. r201507 - Craig Topper <craig.topper at gmail.com> - Fix diassembler >> > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore >> the >> > base register entirely. Mod=01/10 should treat this as R13 plus >> > displacment. Fixes PR18860 >> > 6. r201126 - Robert Khasanov - Changed attributes of all gather >> intrinsics >> > from IntrReadMem to IntrReadArgMem as they access only memory based on >> > argument. >> > >> > Most patches fix different stable issues on X86 target. >> > >> > Thanks, >> > Robert >> > >> > >> > >> > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net>: >> > >> > > Hi, >> > > >> > > We are now about halfway between the 3.4 and 3.5 releases, and I would >> > > like to start preparing for a 3.4.1 release. Here is my proposed >> release >> > > schedule: >> > > >> > > Mar 26 - April 9: Identify and backport additional bug fixes to the >> 3.4 >> > > branch. >> > > April 9 - April 18: Testing Phase >> > > April 18: 3.4.1 Release >> > > >> > > How you can help: >> > > >> > > - If you have any bug fixes you think should be included to 3.4.1, >> send >> > > me an email with the SVN revision in trunk and also cc the code >> owner >> > > and llvm-commits (or cfe-commits if it is a clang patch). >> > > >> > > - Start integrating the 3.4 branch into your project or OS >> distribution >> > > to and check for any issues. >> > > >> > > - Volunteer as a tester for the testing phase. >> > > >> > > Thank you, >> > > >> > > Tom >> > > _______________________________________________ >> > > LLVM Developers mailing list >> > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > > >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/e7685cf6/attachment.html>
Yes, if x86 owners are fine with it. On Tue, Apr 8, 2014 at 6:39 AM, Robert Khasanov <rob.khasanov at gmail.com>wrote:> Hi Akira, > > Would you approve your patch r205067 to be backported to 3.4.1? It fixes > stability issue on x86. > > Thanks, > Robert. > > понедельник, 7 апреля 2014 г. пользователь Tom Stellard написал: > >> Hi Robert, >> >> >> Can you ping the code owners about these patches. It might be good >> to write a separate email per code owner and cc the appropriate -commits >> list. >> >> Thanks, >> Tom >> >> On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: >> > Hi Tom, >> > >> > I would like to nominate the following patches to be backported to 3.4.1 >> > >> > Clang: >> > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com> - Fix an logic error in >> the >> > clang driver preventing crtfastmath.o from linking when -Ofast is used >> > without -ffast-math >> > >> > LLVM: >> > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com> - [x86] Fix printing >> of >> > register operands with q modifier >> > 2. r203581 - Hans Wennborg <hans at hanshq.net> - X86: Don't generate >> 64-bit >> > movd after cmpneqsd in 32-bit mode (PR19059) >> > 3. r203146 - Reid Kleckner <reid at kleckner.net> - MS asm: The initial >> dot in >> > struct access is optional >> > 4. r202774 - Reid Kleckner <reid at kleckner.net> - MC: Fix Intel assembly >> > parser for [global + offset] >> > 5. r201507 - Craig Topper <craig.topper at gmail.com> - Fix diassembler >> > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore >> the >> > base register entirely. Mod=01/10 should treat this as R13 plus >> > displacment. Fixes PR18860 >> > 6. r201126 - Robert Khasanov - Changed attributes of all gather >> intrinsics >> > from IntrReadMem to IntrReadArgMem as they access only memory based on >> > argument. >> > >> > Most patches fix different stable issues on X86 target. >> > >> > Thanks, >> > Robert >> > >> > >> > >> > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net>: >> > >> > > Hi, >> > > >> > > We are now about halfway between the 3.4 and 3.5 releases, and I would >> > > like to start preparing for a 3.4.1 release. Here is my proposed >> release >> > > schedule: >> > > >> > > Mar 26 - April 9: Identify and backport additional bug fixes to the >> 3.4 >> > > branch. >> > > April 9 - April 18: Testing Phase >> > > April 18: 3.4.1 Release >> > > >> > > How you can help: >> > > >> > > - If you have any bug fixes you think should be included to 3.4.1, >> send >> > > me an email with the SVN revision in trunk and also cc the code >> owner >> > > and llvm-commits (or cfe-commits if it is a clang patch). >> > > >> > > - Start integrating the 3.4 branch into your project or OS >> distribution >> > > to and check for any issues. >> > > >> > > - Volunteer as a tester for the testing phase. >> > > >> > > Thank you, >> > > >> > > Tom >> > > _______________________________________________ >> > > LLVM Developers mailing list >> > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > > >> > > _______________________________________________ > llvm-commits mailing list > llvm-commits at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140408/2676b251/attachment.html>
On Tue, Apr 08, 2014 at 04:08:13PM +0400, Robert Khasanov wrote:> Hi Reid, > > Would you approve your patches r203146 and r202774 to be backported to > 3.4.1? They fix stability issues in x86 asm. >Hi Robert, I was able to merge r203146, but it used a c++11 feature: std::string::back() which I replaced with std::string::at(std::string::size() - 1). r202774 was not merged, because it is dependent on r198584 which adds the X86AsmParser::is32BitMode() function. I don't think we would need to backport all of r198584, maybe just the function and the Mode32Bit SubtargetFeature. Could you take a look and let me know what you want to do? Thanks, Tom> Thanks, > Robert > > понедельник, 7 апреля 2014 г. пользователь Tom Stellard написал: > > > Hi Robert, > > > > Can you ping the code owners about these patches. It might be good > > to write a separate email per code owner and cc the appropriate -commits > > list. > > > > Thanks, > > Tom > > > > On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: > > > Hi Tom, > > > > > > I would like to nominate the following patches to be backported to 3.4.1 > > > > > > Clang: > > > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com <javascript:;>> - Fix an > > logic error in the > > > clang driver preventing crtfastmath.o from linking when -Ofast is used > > > without -ffast-math > > > > > > LLVM: > > > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com <javascript:;>> - > > [x86] Fix printing of > > > register operands with q modifier > > > 2. r203581 - Hans Wennborg <hans at hanshq.net <javascript:;>> - X86: > > Don't generate 64-bit > > > movd after cmpneqsd in 32-bit mode (PR19059) > > > 3. r203146 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MS asm: > > The initial dot in > > > struct access is optional > > > 4. r202774 - Reid Kleckner <reid at kleckner.net <javascript:;>> - MC: Fix > > Intel assembly > > > parser for [global + offset] > > > 5. r201507 - Craig Topper <craig.topper at gmail.com <javascript:;>> - Fix > > diassembler > > > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore the > > > base register entirely. Mod=01/10 should treat this as R13 plus > > > displacment. Fixes PR18860 > > > 6. r201126 - Robert Khasanov - Changed attributes of all gather > > intrinsics > > > from IntrReadMem to IntrReadArgMem as they access only memory based on > > > argument. > > > > > > Most patches fix different stable issues on X86 target. > > > > > > Thanks, > > > Robert > > > > > > > > > > > > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net <javascript:;> > > >: > > > > > > > Hi, > > > > > > > > We are now about halfway between the 3.4 and 3.5 releases, and I would > > > > like to start preparing for a 3.4.1 release. Here is my proposed > > release > > > > schedule: > > > > > > > > Mar 26 - April 9: Identify and backport additional bug fixes to the 3.4 > > > > branch. > > > > April 9 - April 18: Testing Phase > > > > April 18: 3.4.1 Release > > > > > > > > How you can help: > > > > > > > > - If you have any bug fixes you think should be included to 3.4.1, send > > > > me an email with the SVN revision in trunk and also cc the code owner > > > > and llvm-commits (or cfe-commits if it is a clang patch). > > > > > > > > - Start integrating the 3.4 branch into your project or OS distribution > > > > to and check for any issues. > > > > > > > > - Volunteer as a tester for the testing phase. > > > > > > > > Thank you, > > > > > > > > Tom > > > > _______________________________________________ > > > > LLVM Developers mailing list > > > > LLVMdev at cs.uiuc.edu <javascript:;> http://llvm.cs.uiuc.edu > > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > > >
On Tue, Apr 8, 2014 at 1:43 PM, Robert Khasanov <rob.khasanov at gmail.com> wrote:> Hi Hans, > > Would you approve your patch r203581 to be backported to 3.4.1? It fixes > stability issue on x86.Yes, I approve. Cheers, Hans> понедельник, 7 апреля 2014 г. пользователь Tom Stellard написал: >> >> Hi Robert, >> >> >> Can you ping the code owners about these patches. It might be good >> to write a separate email per code owner and cc the appropriate -commits >> list. >> >> Thanks, >> Tom >> >> On Wed, Apr 02, 2014 at 06:16:44PM +0400, Robert Khasanov wrote: >> > Hi Tom, >> > >> > I would like to nominate the following patches to be backported to 3.4.1 >> > >> > Clang: >> > 1. r204742 - Zinovy Nis <zinovy.nis at gmail.com> - Fix an logic error in >> > the >> > clang driver preventing crtfastmath.o from linking when -Ofast is used >> > without -ffast-math >> > >> > LLVM: >> > 1. r205067 - Akira Hatanaka <ahatanaka at apple.com> - [x86] Fix printing >> > of >> > register operands with q modifier >> > 2. r203581 - Hans Wennborg <hans at hanshq.net> - X86: Don't generate >> > 64-bit >> > movd after cmpneqsd in 32-bit mode (PR19059) >> > 3. r203146 - Reid Kleckner <reid at kleckner.net> - MS asm: The initial dot >> > in >> > struct access is optional >> > 4. r202774 - Reid Kleckner <reid at kleckner.net> - MC: Fix Intel assembly >> > parser for [global + offset] >> > 5. r201507 - Craig Topper <craig.topper at gmail.com> - Fix diassembler >> > handling of rex.b when mod=00/01/10 and bbb=101. Mod=00 should ignore >> > the >> > base register entirely. Mod=01/10 should treat this as R13 plus >> > displacment. Fixes PR18860 >> > 6. r201126 - Robert Khasanov - Changed attributes of all gather >> > intrinsics >> > from IntrReadMem to IntrReadArgMem as they access only memory based on >> > argument. >> > >> > Most patches fix different stable issues on X86 target. >> > >> > Thanks, >> > Robert >> > >> > >> > >> > 2014-03-26 20:10 GMT+04:00 Tom Stellard <tom at stellard.net>: >> > >> > > Hi, >> > > >> > > We are now about halfway between the 3.4 and 3.5 releases, and I would >> > > like to start preparing for a 3.4.1 release. Here is my proposed >> > > release >> > > schedule: >> > > >> > > Mar 26 - April 9: Identify and backport additional bug fixes to the >> > > 3.4 >> > > branch. >> > > April 9 - April 18: Testing Phase >> > > April 18: 3.4.1 Release >> > > >> > > How you can help: >> > > >> > > - If you have any bug fixes you think should be included to 3.4.1, >> > > send >> > > me an email with the SVN revision in trunk and also cc the code >> > > owner >> > > and llvm-commits (or cfe-commits if it is a clang patch). >> > > >> > > - Start integrating the 3.4 branch into your project or OS >> > > distribution >> > > to and check for any issues. >> > > >> > > - Volunteer as a tester for the testing phase. >> > > >> > > Thank you, >> > > >> > > Tom >> > > _______________________________________________ >> > > LLVM Developers mailing list >> > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > > > > > _______________________________________________ > llvm-commits mailing list > llvm-commits at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits >