Chris Lattner
2014-Mar-28 23:17 UTC
[LLVMdev] Contributing the Apple ARM64 compiler backend
On Mar 28, 2014, at 3:32 PM, Bob Wilson <bob.wilson at apple.com> wrote:> There are new conflicts several times a day, on average. I rebased them on Wednesday on top of svn 204791. If you want to try them out, it would be best to roll back to that revision. > > I’ll rebase them one more time when we commit them, but it’s such a moving target (and takes a fair bit of work), that I’d rather wait until we’re ready to commit.There has been universal support for merging it in, so lets do it. Please start by commiting the llvm part (i.e. lib/Target/ARM64, tests, etc). We should have a similar discussion on cfe-dev to get those changes reviewed, and commit the clang pieces when that settles out. The libc++, compiler_rt, and lldb piece should be separately reviewed and explained before they go in. Thanks Bob (and everyone who worked on the apple arm64 backend!) -Chris
Jevin Sweval
2014-Mar-28 23:23 UTC
[LLVMdev] Contributing the Apple ARM64 compiler backend
On Fri, Mar 28, 2014 at 7:17 PM, Chris Lattner <clattner at apple.com> wrote:> On Mar 28, 2014, at 3:32 PM, Bob Wilson <bob.wilson at apple.com> wrote: >> There are new conflicts several times a day, on average. I rebased them on Wednesday on top of svn 204791. If you want to try them out, it would be best to roll back to that revision. >> >> I'll rebase them one more time when we commit them, but it's such a moving target (and takes a fair bit of work), that I'd rather wait until we're ready to commit. > > There has been universal support for merging it in, so lets do it. Please start by commiting the llvm part (i.e. lib/Target/ARM64, tests, etc). We should have a similar discussion on cfe-dev to get those changes reviewed, and commit the clang pieces when that settles out. > > The libc++, compiler_rt, and lldb piece should be separately reviewed and explained before they go in. > > Thanks Bob (and everyone who worked on the apple arm64 backend!) > > -ChrisIs the LLDB patch missing? I only see libc++, compiler-rt, LLVM, and Clang patches. Cheers, Jevin
On Mar 28, 2014, at 4:17 PM, Chris Lattner <clattner at apple.com> wrote:> On Mar 28, 2014, at 3:32 PM, Bob Wilson <bob.wilson at apple.com> wrote: >> There are new conflicts several times a day, on average. I rebased them on Wednesday on top of svn 204791. If you want to try them out, it would be best to roll back to that revision. >> >> I’ll rebase them one more time when we commit them, but it’s such a moving target (and takes a fair bit of work), that I’d rather wait until we’re ready to commit. > > There has been universal support for merging it in, so lets do it. Please start by commiting the llvm part (i.e. lib/Target/ARM64, tests, etc). We should have a similar discussion on cfe-dev to get those changes reviewed, and commit the clang pieces when that settles out. > > The libc++, compiler_rt, and lldb piece should be separately reviewed and explained before they go in. > > Thanks Bob (and everyone who worked on the apple arm64 backend!)Tim has volunteered to commit the initial changes tomorrow. Things should be a little quieter then because its a Saturday. I’m rebasing the changes one more time now.
Chris Lattner
2014-Mar-28 23:27 UTC
[LLVMdev] Contributing the Apple ARM64 compiler backend
On Mar 28, 2014, at 4:23 PM, Bob Wilson <bob.wilson at apple.com> wrote:> > On Mar 28, 2014, at 4:17 PM, Chris Lattner <clattner at apple.com> wrote: > >> On Mar 28, 2014, at 3:32 PM, Bob Wilson <bob.wilson at apple.com> wrote: >>> There are new conflicts several times a day, on average. I rebased them on Wednesday on top of svn 204791. If you want to try them out, it would be best to roll back to that revision. >>> >>> I’ll rebase them one more time when we commit them, but it’s such a moving target (and takes a fair bit of work), that I’d rather wait until we’re ready to commit. >> >> There has been universal support for merging it in, so lets do it. Please start by commiting the llvm part (i.e. lib/Target/ARM64, tests, etc). We should have a similar discussion on cfe-dev to get those changes reviewed, and commit the clang pieces when that settles out. >> >> The libc++, compiler_rt, and lldb piece should be separately reviewed and explained before they go in. >> >> Thanks Bob (and everyone who worked on the apple arm64 backend!) > > Tim has volunteered to commit the initial changes tomorrow. Things should be a little quieter then because its a Saturday. I’m rebasing the changes one more time now.Sounds great, thank you Tim! -Chris
On Mar 28, 2014, at 4:23 PM, Jevin Sweval <jevinsweval at gmail.com> wrote:> On Fri, Mar 28, 2014 at 7:17 PM, Chris Lattner <clattner at apple.com> wrote: >> On Mar 28, 2014, at 3:32 PM, Bob Wilson <bob.wilson at apple.com> wrote: >>> There are new conflicts several times a day, on average. I rebased them on Wednesday on top of svn 204791. If you want to try them out, it would be best to roll back to that revision. >>> >>> I'll rebase them one more time when we commit them, but it's such a moving target (and takes a fair bit of work), that I'd rather wait until we're ready to commit. >> >> There has been universal support for merging it in, so lets do it. Please start by commiting the llvm part (i.e. lib/Target/ARM64, tests, etc). We should have a similar discussion on cfe-dev to get those changes reviewed, and commit the clang pieces when that settles out. >> >> The libc++, compiler_rt, and lldb piece should be separately reviewed and explained before they go in. >> >> Thanks Bob (and everyone who worked on the apple arm64 backend!) >> >> -Chris > > Is the LLDB patch missing? I only see libc++, compiler-rt, LLVM, and > Clang patches.We have a patch for LLDB but it is combined with a variety of other changes. Someone will have to go through and sort those out first.