llvm dev - Jan 2014 - [LLVMdev] PostDominatorTree methods and non-constness of arguments

Hello,

I was looking at the PostDominatorTree member functions and I noticed 
that some of them are not const or don't have const parameters for no 
apparent (to me) valid reason.

Like for example "properlyDominates" or getNode() that seems to only
do
a lookup in a table using the passed BB as a key.
In addition to that findNearestCommonDominator is not set as const while 
doesn't seem to be doing any change to the Dominator object itself.

Is there any reason I'm missing for it being like that?

Cheers,
Marcello

-- 
Marcello Maggioni

Compiler Engineer

  

Codeplay Software Ltd

45 York Place, Edinburgh, EH1 3HP

Tel: 0131 466 0503

Fax: 0131 557 6600

Website: http://www.codeplay.com

Twitter: https://twitter.com/@codeplaybiz

  

This email and any attachments may contain confidential and /or privileged
information and  is for use  by the addressee only. If you are not the intended
recipient, please notify Codeplay Software Ltd immediately and delete the
message from your computer. You may not copy or forward it,or use or disclose
its contents to any other person. Any views or other information in this message
which do not relate to our business are not authorized by Codeplay software Ltd,
nor does this message form part of any contract unless so stated.

As internet communications are capable of data corruption Codeplay Software Ltd
does not accept any responsibility for any changes made to this message after it
was sent. Please note that Codeplay Software Ltd does not accept any liability
or responsibility for viruses and it is your responsibility to scan any
attachments.

Company registered in England and Wales, number: 04567874

Registered office: 81 Linkfield Street, Redhill RH1 6BY

Sometimes const is just left off even when it could go on - feel free
to submit a patch constifying things if they can be made const. :)

-eric

On Tue, Jan 28, 2014 at 4:52 AM, Marcello Maggioni
<marcello at codeplay.com> wrote:
> Hello,
>
> I was looking at the PostDominatorTree member functions and I noticed that
> some of them are not const or don't have const parameters for no
apparent
> (to me) valid reason.
>
> Like for example "properlyDominates" or getNode() that seems to
only do a
> lookup in a table using the passed BB as a key.
> In addition to that findNearestCommonDominator is not set as const while
> doesn't seem to be doing any change to the Dominator object itself.
>
> Is there any reason I'm missing for it being like that?
>
> Cheers,
> Marcello
>
> --
> Marcello Maggioni
>
> Compiler Engineer
>
>
> Codeplay Software Ltd
>
> 45 York Place, Edinburgh, EH1 3HP
>
> Tel: 0131 466 0503
>
> Fax: 0131 557 6600
>
> Website: http://www.codeplay.com
>
> Twitter: https://twitter.com/@codeplaybiz
>
>
> This email and any attachments may contain confidential and /or privileged
> information and  is for use  by the addressee only. If you are not the
> intended recipient, please notify Codeplay Software Ltd immediately and
> delete the message from your computer. You may not copy or forward it,or
use
> or disclose its contents to any other person. Any views or other
information
> in this message which do not relate to our business are not authorized by
> Codeplay software Ltd, nor does this message form part of any contract
> unless so stated.
>
> As internet communications are capable of data corruption Codeplay Software
> Ltd does not accept any responsibility for any changes made to this message
> after it was sent. Please note that Codeplay Software Ltd does not accept
> any liability or responsibility for viruses and it is your responsibility
to
> scan any attachments.
>
> Company registered in England and Wales, number: 04567874
>
> Registered office: 81 Linkfield Street, Redhill RH1 6BY
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev