llvm dev - Dec 2013 - [LLVMdev] [PATCH] Prevent CMake from installing libgtest*.

This library is intended to be used locally for tests and not installed
as a global system library. And even if it were, the install doesn't
belong to LLVM but to a dedicated gtest package.
---
 utils/unittest/CMakeLists.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/utils/unittest/CMakeLists.txt b/utils/unittest/CMakeLists.txt
index fd1a048..c11c110 100644
--- a/utils/unittest/CMakeLists.txt
+++ b/utils/unittest/CMakeLists.txt
@@ -38,6 +38,9 @@ if(MSVC AND MSVC_VERSION EQUAL 1700)
   add_definitions(-D_VARIADIC_MAX=10)
 endif ()
 
+# Delay building until the tests pull it in, and avoid installing it.
+set(EXCLUDE_FROM_ALL ON)
+
 add_llvm_library(gtest
   googletest/src/gtest-all.cc
   )
-- 
1.8.5.2

Patches should be sent to llvm-commits, and they should be attached rather
than inline. <http://llvm.org/docs/DeveloperPolicy.html>

-- Sean Silva


On Sun, Dec 29, 2013 at 11:38 AM, Michał Górny <mgorny at gentoo.org>
wrote:
> This library is intended to be used locally for tests and not installed
> as a global system library. And even if it were, the install doesn't
> belong to LLVM but to a dedicated gtest package.
> ---
>  utils/unittest/CMakeLists.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/utils/unittest/CMakeLists.txt b/utils/unittest/CMakeLists.txt
> index fd1a048..c11c110 100644
> --- a/utils/unittest/CMakeLists.txt
> +++ b/utils/unittest/CMakeLists.txt
> @@ -38,6 +38,9 @@ if(MSVC AND MSVC_VERSION EQUAL 1700)
>    add_definitions(-D_VARIADIC_MAX=10)
>  endif ()
>
> +# Delay building until the tests pull it in, and avoid installing it.
> +set(EXCLUDE_FROM_ALL ON)
> +
>  add_llvm_library(gtest
>    googletest/src/gtest-all.cc
>    )
> --
> 1.8.5.2
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20131229/185ab33a/attachment.html>

Dnia 2013-12-29, o godz. 12:42:49
Sean Silva <chisophugis at gmail.com> napisał(a):
> Patches should be sent to llvm-commits, and they should be attached rather
> than inline. <http://llvm.org/docs/DeveloperPolicy.html>
Ok, sorry about that. Is it fine to sent them without subscription?
I've got the 'await moderator approval' mail but I'm wondering
if
there's someone who actually approves those mails.

-- 
Best regards,
Michał Górny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 966 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20131230/43b3e7c2/attachment.sig>