llvm dev - May 2013 - [LLVMdev] Unsupported MCJIT tests on ARM?

On 18 May 2013 09:56, Tim Northover <t.p.northover at gmail.com> wrote:
> According to Amara that assertion was a bit of paranoia so we'd know
> if someone tried emitting .rel relocations and sending the result
> through MCJIT. However, now we routinely re-relocate using explicit
> addends so as he says it can probably just be removed.
>
Hi Tim,

Sorry, I saw that thread but earlier on, and Amara's answer got flushed
away.

Amara, what you're saying is that it should be ok to remove the warning and
mark the tests as passing on ARM, right?

I was in doubt if the test had to pass (despite the warning) or it was
passing because something was wrong.

I'll prepare a patch and will send for your review.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130518/afa12e4d/attachment.html>

So, it seems David beat me to it, and the assert has already been removed,
but the failures are still inconsistent.

A9-check-all, compiled with GCC:
Tests XPASS:
  LLVM :: ExecutionEngine__MCJIT__test-common-symbols-remote.ll
  LLVM :: ExecutionEngine__MCJIT__test-global-init-nonzero-remote.ll
  LLVM :: ExecutionEngine__MCJIT__test-ptr-reloc-remote.ll
Unit-tests pass.

A9-self-host, compiled with GCC:
Tests XPASS:
  LLVM :: ExecutionEngine__MCJIT__test-data-align-remote.ll
  LLVM :: ExecutionEngine__MCJIT__test-ptr-reloc-remote.ll
Unit-tests pass.

A9-self-host, compiled with Clang:
Tests XPASS::
  LLVM :: ExecutionEngine__MCJIT__test-common-symbols-remote.ll
  LLVM :: ExecutionEngine__MCJIT__test-data-align-remote.ll
  LLVM :: ExecutionEngine__MCJIT__test-global-init-nonzero-remote.ll
  LLVM :: ExecutionEngine__MCJIT__test-ptr-reloc-remote.ll
Unit-tests pass.

Both A9 bots are running the same Ubuntu (13.03), with the same GCC
(4.7.2), and are the same hardware (Panda ES RevB), so it really strikes me
as odd that we have such a different behaviour between them.

ARM920, compiled with GCC:
All tests pass.
Unit-test fail:
  MCJITTest.return_global

If I take out the XFAIL on those tests, some bots will fail, others will
pass. This is not the solution. It either pass on all, or none. All errors
started with David's patch, so I'm assuming it was something enabled by
that. It could be a dormant, unrelated bug to his patch, but it was
certainly activated by it.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130518/0a3854bd/attachment.html>

> Both A9 bots are running the same Ubuntu (13.03), with the same GCC
(4.7.2),
> and are the same hardware (Panda ES RevB), so it really strikes me as odd
> that we have such a different behaviour between them.
Hmm. I'll see what I can do on my tablet (not tried building LLVM
there before so it could take a while), it seems like there are *some*
failures everywhere. If we're lucky it'll just be a matter of fixing
the PR16013 that David reported.

Tim.