Hello, I tried to compile revision 182096 of compile-rt on linux. An include missied. I attached the patch and changelog. by: Antal Tatrai -------------- next part -------------- A non-text attachment was scrubbed... Name: changelog Type: application/octet-stream Size: 53 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130517/c743da76/attachment.obj> -------------- next part -------------- -------------- next part -------------- A non-text attachment was scrubbed... Name: missing_include.diff Type: application/octet-stream Size: 481 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130517/c743da76/attachment-0001.obj> -------------- next part --------------
Tátrai Antal <tatraian at deverto.com> writes:> I tried to compile revision 182096 of compile-rt on linux. An include > missied. I attached the patch and changelog. > > by: > Antal Tatrai > > > > Index: lib/sanitizer_common/sanitizer_platform_limits_posix.cc > ==================================================================> --- lib/sanitizer_common/sanitizer_platform_limits_posix.cc (revision 182096) > +++ lib/sanitizer_common/sanitizer_platform_limits_posix.cc (working copy) > @@ -18,6 +18,7 @@ > > #include "sanitizer_internal_defs.h" > #include "sanitizer_platform_limits_posix.h" > +#include "sanitizer_platform_limits_posix.h"This patch duplicates the previous #include. Apart from that, the most correct place for submitting patches is either the llvm-commits mailing list or the bug database.
On Fri, May 17, 2013 at 10:39 AM, Óscar Fuentes <ofv at wanadoo.es> wrote:> > Apart from that, the most correct place for submitting patches is either > the llvm-commits mailing list or the bug database. > >We don't accept patches through the bug database. Patches should be sent to llvm-commits for review. -- Sean Silva -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130517/f3ddb3fd/attachment.html>