llvm dev - Jan 2013 - [LLVMdev] Patch for Transform/LoopStrengthReduction/post-inc-icmpzero.ll test-failure

Hi,

Transform/LoopStrengthReduction/post-inc-icmpzero.ll was failing for
clang-native-arm-cortex-a9 build-bot configuration. The reason for the
failure was the test was using hardcoded names. The attached patch fixes
this failure by replacing the hard-coded variables names with
pattern-matched variable names.

I have checked that the test pass after applying the patch. Could somebody
please review and commit the patch.

Regards,
Manish
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130115/efa90301/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Updated-the-test-to-use-pattern-matched-variables-in.patch
Type: application/octet-stream
Size: 1495 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130115/efa90301/attachment.obj>

Hi Manish,

Thanks for the patch, I'll check and commit.

cheers,
--renato

PS: Patches are normally sent to llvm-commit list, unless they require a
lot of discussion.


On 15 January 2013 14:52, Manish Verma <manish.avtaar at gmail.com> wrote:
> Hi,
>
> Transform/LoopStrengthReduction/post-inc-icmpzero.ll was failing for
> clang-native-arm-cortex-a9 build-bot configuration. The reason for the
> failure was the test was using hardcoded names. The attached patch fixes
> this failure by replacing the hard-coded variables names with
> pattern-matched variable names.
>
> I have checked that the test pass after applying the patch. Could somebody
> please review and commit the patch.
>
> Regards,
> Manish
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130115/ffa4fbec/attachment.html>

Hi Renato,

Thanks! I will make sure the patches are posted to the correct mailing list.

Manish


On Tue, Jan 15, 2013 at 3:04 PM, Renato Golin Linaro <
renato.golin at linaro.org> wrote:
> Hi Manish,
>
> Thanks for the patch, I'll check and commit.
>
> cheers,
> --renato
>
> PS: Patches are normally sent to llvm-commit list, unless they require a
> lot of discussion.
>
>
> On 15 January 2013 14:52, Manish Verma <manish.avtaar at gmail.com>
wrote:
>
>> Hi,
>>
>> Transform/LoopStrengthReduction/post-inc-icmpzero.ll was failing for
>> clang-native-arm-cortex-a9 build-bot configuration. The reason for the
>> failure was the test was using hardcoded names. The attached patch
fixes
>> this failure by replacing the hard-coded variables names with
>> pattern-matched variable names.
>>
>> I have checked that the test pass after applying the patch. Could
>> somebody please review and commit the patch.
>>
>> Regards,
>> Manish
>>
>>
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130115/1692e181/attachment.html>