On Jan 6, 2013, at 10:54 AM, Kostya Serebryany wrote:> Alex (in CC) is working on asan for OS X. I think he can handle ubsan as well. > (but give us a few days, we are all out of office due to holidays).OK, thanks. If there are no objections, then I can go ahead and commit the attached test case fix I mentioned before. Adding ALWAYS_INLINE to 'free_common' in r158885 changed the stack trace. -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software -------------- next part -------------- A non-text attachment was scrubbed... Name: use-after-free-test.patch Type: application/octet-stream Size: 870 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130107/c1bc0302/attachment.obj>
Hi Meador, I couldn't reproduce the ASan failures on my 10.8 machine (trying that on a 10.7 one now) I'll look into making the in-process symbolizer work on OSX (which should fix some of the ubsan failures), but we do not need it in production currently, so I'm not sure when I get to it. On Mon, Jan 7, 2013 at 7:48 PM, Meador Inge <meadori at codesourcery.com> wrote:> > On Jan 6, 2013, at 10:54 AM, Kostya Serebryany wrote: > >> Alex (in CC) is working on asan for OS X. I think he can handle ubsan as well. >> (but give us a few days, we are all out of office due to holidays). > > OK, thanks. If there are no objections, then I can go ahead and > commit the attached test case fix I mentioned before. Adding > ALWAYS_INLINE to 'free_common' in r158885 changed the stack trace. > > -- > Meador Inge > CodeSourcery / Mentor Embedded > http://www.mentor.com/embedded-software-- Alexander Potapenko Software Engineer Google Moscow
On 01/10/2013 06:41 AM, Alexander Potapenko wrote:> Hi Meador, > > I couldn't reproduce the ASan failures on my 10.8 machine (trying that > on a 10.7 one now) > I'll look into making the in-process symbolizer work on OSX (which > should fix some of the ubsan failures), but we do not need it in > production currently, so I'm not sure when I get to it.Great, thanks for looking into it. If you can't get around to implementing the symbolizer for OS X, then it would be nice if you can at least disable the tests that require it on OS X. `make check` should always pass on a fresh checkout. -- Meador Inge CodeSourcery / Mentor Embedded