On Wed, Apr 18, 2012 at 03:04:00PM +0000, Villmow, Micah wrote:> Sure, here is our diff against 3.0.A large part of that seems to be applied already. The last chunk looks wrong though? Joerg
Oops, I had the arguments backward. Patch re-attached with the correct ordering> -----Original Message----- > From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] > On Behalf Of Joerg Sonnenberger > Sent: Wednesday, April 18, 2012 8:39 AM > To: llvmdev at cs.uiuc.edu > Subject: Re: [LLVMdev] STLport > > On Wed, Apr 18, 2012 at 03:04:00PM +0000, Villmow, Micah wrote: > > Sure, here is our diff against 3.0. > > A large part of that seems to be applied already. The last chunk looks > wrong though? > > Joerg > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- A non-text attachment was scrubbed... Name: STLPort.diff Type: application/octet-stream Size: 3388 bytes Desc: STLPort.diff URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120418/17c0a4d1/attachment.obj>
Hi Micah, Looks like the diff is not against LLVM 3.0 release, but rather against some other "internal" version. :-) On Wed, Apr 18, 2012 at 9:42 AM, Villmow, Micah <Micah.Villmow at amd.com>wrote:> Oops, I had the arguments backward. Patch re-attached with the correct > ordering > > > -----Original Message----- > > From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] > > On Behalf Of Joerg Sonnenberger > > Sent: Wednesday, April 18, 2012 8:39 AM > > To: llvmdev at cs.uiuc.edu > > Subject: Re: [LLVMdev] STLport > > > > On Wed, Apr 18, 2012 at 03:04:00PM +0000, Villmow, Micah wrote: > > > Sure, here is our diff against 3.0. > > > > A large part of that seems to be applied already. The last chunk looks > > wrong though? > > > > Joerg > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >-- Welson Phone: (408) 418-8385 Email: welson.sun at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120418/93889597/attachment.html>
On Wed, Apr 18, 2012 at 04:42:00PM +0000, Villmow, Micah wrote:> Oops, I had the arguments backward. Patch re-attached with the correct > orderingThe casts for spelling NULL with explicit cast shouldn't be necessary. What is the error you are dealing with? Joerg