Happy new year to all! The attached patch adds TLS support for x86_64-pc-win32 and x86-pc-win32. Implemented is the implicit TLS model (__declspec(thread) in Visual C++). Please review. Thanks! Regards Kai -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: tls20120101.diff URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120101/b46065cb/attachment.ksh>
On Sun, Jan 1, 2012 at 10:44 AM, Kai <kai at redstar.de> wrote:> Happy new year to all! > > The attached patch adds TLS support for x86_64-pc-win32 and x86-pc-win32. > Implemented is the implicit TLS model (__declspec(thread) in Visual C++). > Please review. Thanks!Rough review: looks like the patch is in the right direction; please take out all tabs, please take out all commented-out code. -Eli
Hi! Thanks for your answer! I reworked the patch: the tabs and the commented-out is gone. I also tried to limit line-length to 80 chars. Applies cleanly to r147775 now. Kai On 01.01.2012 22:01, Eli Friedman wrote:> On Sun, Jan 1, 2012 at 10:44 AM, Kai<kai at redstar.de> wrote: >> Happy new year to all! >> >> The attached patch adds TLS support for x86_64-pc-win32 and x86-pc-win32. >> Implemented is the implicit TLS model (__declspec(thread) in Visual C++). >> Please review. Thanks! > > Rough review: looks like the patch is in the right direction; please > take out all tabs, please take out all commented-out code. > > -Eli-------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: tls20120109.diff URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120109/63295641/attachment.ksh>
Hi! I added 2 more tests and also refined an assert statement. Applies cleanly to r148473 now. Are there more comments on the code? Thank you!! Regards Kai On 01.01.2012 22:01, Eli Friedman wrote:> On Sun, Jan 1, 2012 at 10:44 AM, Kai<kai at redstar.de> wrote: >> Happy new year to all! >> >> The attached patch adds TLS support for x86_64-pc-win32 and x86-pc-win32. >> Implemented is the implicit TLS model (__declspec(thread) in Visual C++). >> Please review. Thanks! > > Rough review: looks like the patch is in the right direction; please > take out all tabs, please take out all commented-out code. > > -Eli-------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: tls-20120119.diff URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120119/89b04bb3/attachment.ksh>