llvm dev - Apr 2011 - [LLVMdev] Issues running LLVM tests on Windows + MKS; filed 4 PRs and have patches

I have filed a number of problem reports about getting the LLVM test
infrastructure working for an environment with: Windows + MSVC9 +
Cmake + NMake makefiles + MKS.  (MKS provides unix-like tools for
Windows, but based on very old versions, so they have quirky or
minimal compatibility with GNU tools.)

http://llvm.org/bugs/show_bug.cgi?id=9689 - Fix Cmake generation of
compile_cxx for MSVC - Oscar already applied a fix. Thanks!

http://llvm.org/bugs/show_bug.cgi?id=9687 - MKS bash does not
understand  "set -o pipefail"
http://llvm.org/bugs/show_bug.cgi?id=9691 - lit can't find bash in
non-standard location.  (I see now it's a duplicate of PR8502)
http://llvm.org/bugs/show_bug.cgi?id=9698 - Many tests fail because
Windows doesn't understand /dev/null nor >&
http://llvm.org/bugs/show_bug.cgi?id=9703 - MC/COFF and MC/ELF tests
fail because you have to call the .bat version of elf-dump (etc.)

I have attached a patch to 9703 to fix 9703,9698,9687.
I also have a patch in 9691 to fix 9691.  Similarly I think the patch
for 8502 will also fix 9691.

How do I get these reviewed?  Attach them in an email?  Or is this
email with references to the PRs ok?

With all these patches I can reasonably run the LLVM trunk tests (not
the llvm-gcc based ones though).  Things look very good, with two
non-infrastructure issues.  (And whoever generalized the CodeGen/X86
tests for the Microsoft x86-64 calling convention: you have a special
place in my heart.  :-)


thanks,
david

Good morning David,

I won't accept your patches for now. It breaks lots of things in
current environments, autoconf - msys, cmake - msys, cmake -mingw and
cmake - msvs.

  - You should never forget other environments. (eg., MSYS and CMD.EXE)
    You should implement detecting MKS if you tweak MKS-specific stuff.
  - Bash should be assumed to be mature.
    I suppose MKS bash might be extremely broken (for me).
  - *.bat is not acceptable on MSYS bash.
    Is MKS bash not capable to understand #!shbang, or is /usr/bin/env missing?
  - MKS utils (eg. grep) might not accept our-expected quotes.

Yeah, usually I could tweak proposed patches, but I cannot obtain MKS.
(and I won't!).

At least, you should consider not to break cmake - {mingw|msvc} - gnuwin32.
You may try tests w/o MKS, by CMake's "LLVM_LIT_TOOLS_DIR" with
X:/gnuwin32/bin.
(You may try also msbuild.exe! )

FYI, as you oughta know, Lit detects bash.exe in $PATH on Win32 hosts.
Lit assumes bash.exe might be with a few GNU utils (grep.exe &c.)

You would be welcome if you would maintain MKS on, or we shall say "We
don't support MKS", thank you.

...Takumi

Ok.  I will try to update the proposed patches to be friendly to the
other environments.  They are open source and so it is easier for me
to replicate.  :-)

Thank you for the pointer to LLVM_LIT_TOOLS_DIR

In my environment Windows cmd.exe is the default shell.  So in
thinking about some of these changes, some of them are MKS issues,
some of them may be CMD.exe shell issues (e.g. /dev/null and >&).


thanks,
david

On Wed, Apr 13, 2011 at 8:43 PM, NAKAMURA Takumi <geek4civic at gmail.com>
wrote:
> Good morning David,
>
> I won't accept your patches for now. It breaks lots of things in
> current environments, autoconf - msys, cmake - msys, cmake -mingw and
> cmake - msvs.
>
>  - You should never forget other environments. (eg., MSYS and CMD.EXE)
>    You should implement detecting MKS if you tweak MKS-specific stuff.
>  - Bash should be assumed to be mature.
>    I suppose MKS bash might be extremely broken (for me).
>  - *.bat is not acceptable on MSYS bash.
>    Is MKS bash not capable to understand #!shbang, or is /usr/bin/env
missing?
>  - MKS utils (eg. grep) might not accept our-expected quotes.
>
> Yeah, usually I could tweak proposed patches, but I cannot obtain MKS.
> (and I won't!).
>
> At least, you should consider not to break cmake - {mingw|msvc} - gnuwin32.
> You may try tests w/o MKS, by CMake's "LLVM_LIT_TOOLS_DIR"
with X:/gnuwin32/bin.
> (You may try also msbuild.exe! )
>
> FYI, as you oughta know, Lit detects bash.exe in $PATH on Win32 hosts.
> Lit assumes bash.exe might be with a few GNU utils (grep.exe &c.)
>
> You would be welcome if you would maintain MKS on, or we shall say "We
> don't support MKS", thank you.
>
> ...Takumi
>