Jan Sjodin
2011-Mar-10 23:43 UTC
[LLVMdev] Detrimental optimization for reducing relocations.
----- Original Message ----> From: Rafael Ávila de Espíndola <rafael.espindola at gmail.com> > To: llvmdev at cs.uiuc.edu > Sent: Thu, March 10, 2011 4:22:32 PM > Subject: Re: [LLVMdev] Detrimental optimization for reducing relocations. > > > So, clearly the optimization is making things worse. Would it be okay to >delete > > this code and eliminate the isBaseAddressKnownZero? I would like to get rid >of > > it. > > I think it is OK. I can see ld/gdb expecting a relocation, but if that > is the case we should just have a flag saying it is needed. > > If you are really motivated to check it, run the gdb testsuite with your > patch, but on ELF our debug info is still too big to be usable.Will the testsuite work on ELF? The patch does not make any functional change for the other formats. I know that gdb is okay with the example, but that doesn't say very much. - Jan
Rafael Ávila de Espíndola
2011-Mar-11 02:02 UTC
[LLVMdev] Detrimental optimization for reducing relocations.
> Will the testsuite work on ELF? The patch does not make any functional change > for the other formats. I know that gdb is okay with the example, but that > doesn't say very much.The patch is probably OK then. The gdb testsuite works with clang on ELF. There used to be a lot of silly failures like it not expecting clang warnings, but I think most of the current ones are real.> - Jan >Cheers, Rafael
Jan Sjodin
2011-Mar-11 12:31 UTC
[LLVMdev] Detrimental optimization for reducing relocations.
Ok, I will try and run the testsuite and spend some time checking things before I post a patch for review. Thanks, Jan ----- Original Message ----> From: Rafael Ávila de Espíndola <rafael.espindola at gmail.com> > To: Jan Sjodin <jan_sjodin at yahoo.com> > Cc: llvmdev at cs.uiuc.edu > Sent: Thu, March 10, 2011 9:02:27 PM > Subject: Re: [LLVMdev] Detrimental optimization for reducing relocations. > > > Will the testsuite work on ELF? The patch does not make any functional >change > > for the other formats. I know that gdb is okay with the example, but that > > doesn't say very much. > > The patch is probably OK then. The gdb testsuite works with clang on ELF. >There used to be a lot of silly failures like it not expecting clang warnings, >but I think most of the current ones are real. > > > - Jan > > > > Cheers, > Rafael >
Apparently Analagous Threads
- [LLVMdev] Detrimental optimization for reducing relocations.
- [LLVMdev] Detrimental optimization for reducing relocations.
- [LLVMdev] Detrimental optimization for reducing relocations.
- [LLVMdev] Detrimental optimization for reducing relocations.
- [LLVMdev] X86 FMA4