Is there any good reason for using DW_FORM_data1 for the DW_AT_language attribute of DW_TAG_compile_unit? This prevents using language codes in the DW_LANG_lo_user=0x8000 to DW_LANG_hi_user=0xffff range. I think the obvious change to use DW_FORM_data2 in line 1897 of lib/CodeGen/AsmPrinter/DwarfDebug.cpp should fix it. Or, if there are binary compatibility issues, the abbrev form could be chosen conditionally. Are there? Thanks -Peter S. Housel- housel at acm.org
On Wed, Feb 23, 2011 at 1:32 PM, Peter Housel <housel at acm.org> wrote:> Is there any good reason for using DW_FORM_data1 for the DW_AT_language > attribute of DW_TAG_compile_unit? This prevents using language codes in > the DW_LANG_lo_user=0x8000 to DW_LANG_hi_user=0xffff range. > > I think the obvious change to use DW_FORM_data2 in line 1897 of > lib/CodeGen/AsmPrinter/DwarfDebug.cpp should fix it. Or, if there are > binary compatibility issues, the abbrev form could be chosen > conditionally. Are there? >this bit be when I tried to use a language ID in the user range> > Thanks > -Peter S. Housel- housel at acm.org > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110223/70ff5014/attachment.html>
Peter, On Feb 23, 2011, at 1:32 PM, Peter Housel wrote:> Is there any good reason for using DW_FORM_data1 for the DW_AT_language > attribute of DW_TAG_compile_unit? This prevents using language codes in > the DW_LANG_lo_user=0x8000 to DW_LANG_hi_user=0xffff range. > > I think the obvious change to use DW_FORM_data2 in line 1897 of > lib/CodeGen/AsmPrinter/DwarfDebug.cpp should fix it. Or, if there are > binary compatibility issues, the abbrev form could be chosen > conditionally. Are there?I do not see any binary compatibility issue. In any case, if there are any I'd learn them about soon! Checked in change to use DW_FORM_data2. r126339. I am curious, what is your source language ? - Devang
On Wed, 2011-02-23 at 14:42 -0800, Devang Patel wrote:> > I think the obvious change to use DW_FORM_data2 in line 1897 of > > lib/CodeGen/AsmPrinter/DwarfDebug.cpp should fix it. Or, if there are > > binary compatibility issues, the abbrev form could be chosen > > conditionally. Are there? > > I do not see any binary compatibility issue. In any case, if there are > any I'd learn them about soon! Checked in change to use DW_FORM_data2. r126339.Thanks!> I am curious, what is your source language ?Dylan, generated using the Open Dylan compiler. -Peter-
Possibly Parallel Threads
- [LLVMdev] DWARF DW_AT_language in LLVM
- [LLVMdev] llvm-dwarfdump offsets
- [LLVMdev] [lldb-dev] How is variable info retrieved in debugging for executables generated by llvm backend?
- [LLVMdev] [lldb-dev] How is variable info retrieved in debugging for executables generated by llvm backend?
- [LLVMdev] How is variable info retrieved in debugging for executables generated by llvm backend?