On 21 September 2010 20:02, Bob Wilson <bob.wilson at apple.com> wrote:> That code is to support reading old bitcode files containing intrinsics that no longer exist or that have different arguments/usage than in previous versions of llvm. It's not a validation pass, and it's not relevant to any new IR. It's only for backward compatibility.Oh, I see. So we should also change ARMInstrNEON.td that still have the intrinsic names on the definitions (ie. is still possible to generate those intrinsics at all?). -- cheers, --renato http://systemcall.org/ Reclaim your digital rights, eliminate DRM, learn more at http://www.defectivebydesign.org/what_is_drm
On Sep 21, 2010, at 12:28 PM, Renato Golin wrote:> On 21 September 2010 20:02, Bob Wilson <bob.wilson at apple.com> wrote: >> That code is to support reading old bitcode files containing intrinsics that no longer exist or that have different arguments/usage than in previous versions of llvm. It's not a validation pass, and it's not relevant to any new IR. It's only for backward compatibility. > > Oh, I see. So we should also change ARMInstrNEON.td that still have > the intrinsic names on the definitions (ie. is still possible to > generate those intrinsics at all?).The intrinsics that have been removed are no longer defined, so I don't see how ARMInstrNEON.td could be using them. I really don't know what you're referring to, though.
On 21 September 2010 20:30, Bob Wilson <bob.wilson at apple.com> wrote:> The intrinsics that have been removed are no longer defined, so I don't see how ARMInstrNEON.td could be using them. I really don't know what you're referring to, though.Hi Bob, Example: lib/VMCore/AutoUpgrade.cpp:91: Name.compare(14, 5, "vabal", 5) == 0) && lib/Target/ARM/ARMInstrNEON.td:3001: defm VABALs : N3VLIntExtOp_QHS<0,1,0b0101,0, IIC_VABAD, "vabal", "s", int_arm_neon_vabds, zext, add>; Isn't that "int_arm_neon_vabds" creating (or referring to) the intrinsic? -- cheers, --renato http://systemcall.org/ Reclaim your digital rights, eliminate DRM, learn more at http://www.defectivebydesign.org/what_is_drm