llvm dev - Aug 2010 - [LLVMdev] [Bug 7748] [PATCH] Fix MSVC truncating enums

I attached a patch to http://llvm.org/bugs/show_bug.cgi?id=7748 that
should fix it; can anybody review?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-enum-truncation.patch
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20100818/208ff43e/attachment.bin>

On Aug 18, 2010, at 8:45 PM, nobled wrote:
> I attached a patch to http://llvm.org/bugs/show_bug.cgi?id=7748 that
> should fix it; can anybody review?
Wow, this is really ugly.  I feel bad because I told bruno to go ahead and use
64-bit integers in the enum values.  Bruno, how terrible would it be to switch
back to 32-bit enumerators?

-Chris

On Mon, Aug 23, 2010 at 12:44 PM, Chris Lattner <clattner at apple.com>
wrote:
>
> On Aug 18, 2010, at 8:45 PM, nobled wrote:
>
> > I attached a patch to http://llvm.org/bugs/show_bug.cgi?id=7748 that
> > should fix it; can anybody review?
>
> Wow, this is really ugly.  I feel bad because I told bruno to go ahead and
use 64-bit integers in the enum values.  Bruno, how terrible would it be to
switch back to 32-bit enumerators?
Not a problem at all! There's already a patch laying around for that
on the bug description, I will give it a try, if it doesn't work I'll
switch it back myself soon.



--
Bruno Cardoso Lopes
http://www.brunocardoso.cc