On Monday 29 March 2010 12:08:45 Chris Lattner wrote:> >> Your patch doesn't include the file that defines > >> createMachineFunctionPrinterPass, but I assume it's fine. > > > > Odd. This was a patch generated from a clean upstream. It built fine. > > I'll see if maybe I missed something. > > I think it's just missing from the patch you sent, maybe it didn't get svn > added.Yep, that's what happened. It's added now.> >> After making these changes, please test the resultant patch against > >> mainline with just the patch applied and commit if it looks ok. Thanks > >> David, > > > > Will do. > > Thanks!How should we handle the llvm-gcc and clang changes? They are trivial but I don't have commit access to either repository. Should I post them here to be applied? There will be a window where things won't build between when the first of these patches is applied and when all of them are applied. -Dave
On Mar 29, 2010, at 11:14 AM, David Greene wrote:>>>> >>>> After making these changes, please test the resultant patch against >>>> mainline with just the patch applied and commit if it looks ok. Thanks >>>> David, >>> >>> Will do. >> >> Thanks! > > How should we handle the llvm-gcc and clang changes?What changes are required?> They are trivial > but I don't have commit access to either repository. Should I post them here > to be applied? There will be a window where things won't build between > when the first of these patches is applied and when all of them are applied.You have access to all llvm repositories, including clang and llvm-gcc. -Chris
On Monday 29 March 2010 13:20:37 Chris Lattner wrote:> > How should we handle the llvm-gcc and clang changes? > > What changes are required?Attached. They are trivial.> You have access to all llvm repositories, including clang and llvm-gcc.Ok. Is there are preferred order to commit things? I think I'm ready to go. -Dave -------------- next part -------------- A non-text attachment was scrubbed... Name: clang-beforeafter.patch Type: text/x-patch Size: 605 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100330/c1df4dc2/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: llvm-gcc-beforeafter.patch Type: text/x-patch Size: 1532 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100330/c1df4dc2/attachment-0001.bin>