On Mar 6, 2010, at 3:49 AM, Aaron Gray wrote:> > I am hoping I can just not build the indexer and will see if I can get a patch together first for 2.7 before submitting a bug report if I have to. > > Okay here's a patch to no build the CIndexer on Cygwin and MinGW :- > > Index: tools/Makefile > ==================================================================> --- tools/Makefile (revision 97834) > +++ tools/Makefile (working copy) > @@ -10,4 +10,9 @@ > LEVEL := ../../.. > DIRS := driver CIndex c-index-test > > +ifeq ($(OS), $(filter $(OS), Cygwin MingW)) > +DIRS := $(filter $(DIRS), CIndex) > +DIRS := $(filter $(DIRS), c-index-test) > +endif > + > include $(LEVEL)/Makefile.commonHi Aaron, did you actually test that this patch fixes the problem you're seeing? -Chris -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100306/a4979eb7/attachment.html>
On 6 March 2010 19:12, Chris Lattner <clattner at apple.com> wrote:> On Mar 6, 2010, at 3:49 AM, Aaron Gray wrote: > > >> I am hoping I can just not build the indexer and will see if I can get a >> patch together first for 2.7 before submitting a bug report if I have to. >> > > Okay here's a patch to no build the CIndexer on Cygwin and MinGW :- > > Index: tools/Makefile > ==================================================================> --- tools/Makefile (revision 97834) > +++ tools/Makefile (working copy) > @@ -10,4 +10,9 @@ > LEVEL := ../../.. > DIRS := driver CIndex c-index-test > > +ifeq ($(OS), $(filter $(OS), Cygwin MingW)) > +DIRS := $(filter $(DIRS), CIndex) > +DIRS := $(filter $(DIRS), c-index-test) > +endif > + > include $(LEVEL)/Makefile.common > > > Hi Aaron, did you actually test that this patch fixes the problem you're > seeing? > >Yes, its been tested on Cygwin, and disables CIndex and its test on Cygwin and MinGW. CIndex makes programatic usage of DL_open so cannot be used on either platform. There maybe a better solution as I just hacked this to get Clang to build on Cygwin.. Aaron -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100306/cedce0de/attachment.html>
On Mar 6, 2010, at 1:47 PM, Aaron Gray wrote:> On 6 March 2010 19:12, Chris Lattner <clattner at apple.com> wrote: > On Mar 6, 2010, at 3:49 AM, Aaron Gray wrote: >> >> >> +ifeq ($(OS), $(filter $(OS), Cygwin MingW)) >> +DIRS := $(filter $(DIRS), CIndex) >> +DIRS := $(filter $(DIRS), c-index-test) >> +endif >> + >> include $(LEVEL)/Makefile.common > > Hi Aaron, did you actually test that this patch fixes the problem you're seeing? > > > Yes, its been tested on Cygwin, and disables CIndex and its test on Cygwin and MinGW. CIndex makes programatic usage of DL_open so cannot be used on either platform. There maybe a better solution as I just hacked this to get Clang to build on Cygwin..I committed a fixed patch as r97892 -Chris -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100306/e39a5766/attachment.html>