Kalle Raiskila
2010-Mar-05 14:26 UTC
[LLVMdev] Patch - SPU assembly printer to print ".section .bss"
Hello, I noticed that the SPU assembly printer prints just ".bss", when gas requires ".section .bss". Now the gas prints out: Assembler messages: Error: expected symbol name Attached is a test case and a patch to fix this. (This time 'make check' passes also ;) kalle -------------- next part -------------- A non-text attachment was scrubbed... Name: spu_bss.patch Type: text/x-patch Size: 538 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100305/487ec0d6/attachment.bin> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: bss.ll URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100305/487ec0d6/attachment.ksh>
Chris Lattner
2010-Mar-05 18:56 UTC
[LLVMdev] Patch - SPU assembly printer to print ".section .bss"
On Mar 5, 2010, at 6:26 AM, Kalle Raiskila wrote:> Hello, > > I noticed that the SPU assembly printer prints just ".bss", when gas requires ".section .bss". Now the gas prints out: > Assembler messages: > Error: expected symbol name > > Attached is a test case and a patch to fix this. > (This time 'make check' passes also ;)Looks great, applied here, thanks! http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20100301/097332.html