llvm dev - Oct 2009 - [LLVMdev] SoftenSetCCOpernads in LegalizeFloatTypes.cpp

Duncan Sands wrote:
> Hi Sanjiv, I think a lot of the softening code assumes you are dealing
> with float (32 bits).  So it's not just a matter of changing the
libcall
> return type.
>
Yes, we are dealing with 32-bits only. But why the cmp libcalls have to 
return a 32-bit value.
e.g. Our libcall for comparing two floats is

  char _eq_f32 (float a, float b);

rather than
 
  long _eq_f32 (float a, float b);


- Sanjiv

Sanjiv Gupta wrote:
> Duncan Sands wrote:
>   
>> Hi Sanjiv, I think a lot of the softening code assumes you are dealing
>> with float (32 bits).  So it's not just a matter of changing the
libcall
>> return type.
>>
>>     
> Yes, we are dealing with 32-bits only. But why the cmp libcalls have to 
> return a 32-bit value.
> e.g. Our libcall for comparing two floats is
>
>   char _eq_f32 (float a, float b);
>
> rather than
>  
>   long _eq_f32 (float a, float b);
>
>
> - Sanjiv
>   
Why not use TLI.getSetCCResultType () ?

- Sanjiv
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>

Sanjiv Gupta wrote:
> Sanjiv Gupta wrote:
>   
>> Duncan Sands wrote:
>>   
>>     
>>> Hi Sanjiv, I think a lot of the softening code assumes you are
dealing
>>> with float (32 bits).  So it's not just a matter of changing
the libcall
>>> return type.
>>>
>>>     
>>>       
>> Yes, we are dealing with 32-bits only. But why the cmp libcalls have to
>> return a 32-bit value.
>> e.g. Our libcall for comparing two floats is
>>
>>   char _eq_f32 (float a, float b);
>>
>> rather than
>>  
>>   long _eq_f32 (float a, float b);
>>
>>
>> - Sanjiv
>>   
>>     
> Why not use TLI.getSetCCResultType () ?
>
> - Sanjiv
>
>   
Duncan,
Any thoughts ?
Or am I missing something very obvious here?

- Sanjiv