llvm dev - Sep 2009 - [LLVMdev] [PATCH] llvm-bcanalyzer: print percentages without scientific notation

Hi,

Andreas Neustifter <astifter-llvm at gmx.at>
writes:
> Maybe you can use the already available
"include/llvm/Support/Format.h"?
Thanks, that simplifies the patch a lot. See the attached patch.

Btw, llvm-bcanalyzer.cpp seems to also use fprintf -- does mixing it
with errs() cause problems and should it be converted to use format()?

best regards,
Timo Lindfors

-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-bcanalyzer-format-percentage2.patch
Type: text/x-diff
Size: 1422 bytes
Desc: llvm-bcanalyzer: print percentages without scientific	notation
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090929/644096a9/attachment.patch>

On Sep 29, 2009, at 9:44 AM, Timo Juhani Lindfors wrote:
> Hi,
>
> Andreas Neustifter <astifter-llvm at gmx.at> writes:
>> Maybe you can use the already available "include/llvm/Support/ 
>> Format.h"?
>
> Thanks, that simplifies the patch a lot. See the attached patch.
It looks like something similar got applied back in r82772 on
9/25.
>
> Btw, llvm-bcanalyzer.cpp seems to also use fprintf -- does mixing it
> with errs() cause problems and should it be converted to use format()?
It would be nice to switch everything to use errs().

-Chris

Chris Lattner <clattner at apple.com> writes:
> It looks like something similar got applied back in r82772 on 9/25.
Aha, great. I did not realize llvm was moving _that_ fast and was
still working with r82620.
> It would be nice to switch everything to use errs().
There seem to be several hundred references to *printf in
llvm. Unfortunately I don't feel confident enough in the codebase to
start rewriting all those just yet ;-)