Chris Lattner
2009-Aug-25 21:20 UTC
[LLVMdev] std::cout << *MyModule does not work anymore
On Aug 25, 2009, at 12:24 PM, Albert Graef wrote:> Trunk (r80020): > raw_fd_ostream(const char *Filename, std::string &ErrorInfo, > unsigned Flags = 0); > > It would be helpful to emulate the LLVM 2.5 variant of the constructor > on both 2.6 and trunk, so that frontend developers don't have to code > against three different versions of the constructor, if they don't > need > the added functionality.We do not guarantee API stability at all, so this is just the tip of the iceberg. At one point we discussed having a Version.h that you could #include and then #ifdef based on the version number, I don't know what happened to it if anything. It seems that it would be relatively easy to get autoconf to make a include/llvm/Config/Version.h file that did this. -Chris
Chris Lattner wrote:> We do not guarantee API stability at all, so this is just the tip of the > iceberg.I understand that. But in this specific case it would be very easy to maintain, no?> It seems that it would be relatively easy to get autoconf to make a > include/llvm/Config/Version.h file that did this.I already have the necessary autoconf magic to deal with this in my frontend. I just hoped that I might get rid of it in this case. All those #ifdef's don't make the code prettier. :) Albert -- Dr. Albert Gr"af Dept. of Music-Informatics, University of Mainz, Germany Email: Dr.Graef at t-online.de, ag at muwiinfa.geschichte.uni-mainz.de WWW: http://www.musikinformatik.uni-mainz.de/ag
Albert Graef wrote:> I understand that. But in this specific case it would be very easy to > maintain, no?FWIW, suggested patch attached. That makes the LLVM 2.5 style raw_fd_ostream constructor work with the trunk (r80036). Note that this just adds a second constructor, existing code will continue to work as before. I'd be happy to prepare an analogous patch for the 2.6 release branch, just let me know. Albert -- Dr. Albert Gr"af Dept. of Music-Informatics, University of Mainz, Germany Email: Dr.Graef at t-online.de, ag at muwiinfa.geschichte.uni-mainz.de WWW: http://www.musikinformatik.uni-mainz.de/ag -------------- next part -------------- A non-text attachment was scrubbed... Name: raw_fd_ostream.patch Type: text/x-patch Size: 2863 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090826/976e987a/attachment.bin>
Seemingly Similar Threads
- [LLVMdev] std::cout << *MyModule does not work anymore
- [LLVMdev] std::cout << *MyModule does not work anymore
- [LLVMdev] std::cout << *MyModule does not work anymore
- [LLVMdev] std::cout << *MyModule does not work anymore
- [LLVMdev] std::cout << *MyModule does not work anymore