llvm dev - Aug 2009 - [LLVMdev] [PATCH]: enable multilib build on x86_64-apple-darwin

Current llvm-gcc-4.2 for trunk and the 2.6 release
is unable to build the i386 multilib for the 
x86_64-apple-darwin target. The attached patch provides
this support. Can we get this into the 2.6 release 
and trunk?
           Jack

-------------- next part --------------
Index: gcc/config/i386/t-darwin64
==================================================================---
gcc/config/i386/t-darwin64	(revision 79792)
+++ gcc/config/i386/t-darwin64	(working copy)
@@ -2,6 +2,12 @@
 LIB2_SIDITI_CONV_FUNCS=yes
 LIB2FUNCS_EXTRA = $(srcdir)/config/darwin-64.c
 
+MULTILIB_OPTIONS = m32
+MULTILIB_DIRNAMES = i386
+
+LIBGCC = stmp-multilib
+INSTALL_LIBGCC = install-multilib
+
 # APPLE LOCAL begin gcov 5573505
 # -pipe because there's an assembler bug, 4077127, which causes
 # it to not properly process the first # directive, causing temporary

doesn't --target=x86_64-apple-darwin imply you don't want multi-libs,  
and an x86_64-only compiler?

Shantonu

Sent from my MacBook

On Aug 23, 2009, at 11:36 AM, Jack Howarth wrote:
> Current llvm-gcc-4.2 for trunk and the 2.6 release
> is unable to build the i386 multilib for the
> x86_64-apple-darwin target. The attached patch provides
> this support. Can we get this into the 2.6 release
> and trunk?
>           Jack
>
> < 
> darwin64_multilib.diff>_______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

Why would you say that? On FSF gcc it is normal to have
the i386 multilib on x86_64 targets. I had that added for
gcc 4.4 on x86_64-apple-darwin...

http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01515.html
http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01522.html

On Sun, Aug 23, 2009 at 11:43:03AM -0700, Shantonu Sen
wrote:
> doesn't --target=x86_64-apple-darwin imply you don't want
multi-libs,
> and an x86_64-only compiler?
>
> Shantonu
>
> Sent from my MacBook
>
> On Aug 23, 2009, at 11:36 AM, Jack Howarth wrote:
>
>> Current llvm-gcc-4.2 for trunk and the 2.6 release
>> is unable to build the i386 multilib for the
>> x86_64-apple-darwin target. The attached patch provides
>> this support. Can we get this into the 2.6 release
>> and trunk?
>>           Jack
>>
>> < 
>>
darwin64_multilib.diff>_______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

Shantonu,
   To clarify, the reason for the i386 multilib on
x86_64-apple-darwin is to enable users of the
x86_64-apple-darwin target to also compile i386
code in gfortran for example. Otherwise they have
to build the i686-apple-darwin target and keep to
seperate compilers around. I will admit this feature
is perhaps more useful on FSF gcc 4.4 where we have
the new -static-libgfortran flag allows for building
semi-static binaries (linked against libgfortran.a)
on darwin...

http://gcc.gnu.org/ml/gcc-patches/2009-01/msg00850.html

Perhaps I should port that change to llvm-gcc-4.2 as
well?
             Jack

On Sun, Aug 23, 2009 at 11:43:03AM -0700, Shantonu Sen
wrote:
> doesn't --target=x86_64-apple-darwin imply you don't want
multi-libs,
> and an x86_64-only compiler?
>
> Shantonu
>
> Sent from my MacBook
>
> On Aug 23, 2009, at 11:36 AM, Jack Howarth wrote:
>
>> Current llvm-gcc-4.2 for trunk and the 2.6 release
>> is unable to build the i386 multilib for the
>> x86_64-apple-darwin target. The attached patch provides
>> this support. Can we get this into the 2.6 release
>> and trunk?
>>           Jack
>>
>> < 
>>
darwin64_multilib.diff>_______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

On Aug 23, 2009, at 11:36 AM, Jack Howarth wrote:
> Current llvm-gcc-4.2 for trunk and the 2.6 release
> is unable to build the i386 multilib for the
> x86_64-apple-darwin target. The attached patch provides
> this support. Can we get this into the 2.6 release
> and trunk?
This is fine.  I don't have a rw llvm-gcc tree, some else want to  
check it in?  For 2.6, that's be someone else's call, for what it's
worth, this should be fairly safe.

On Aug 25, 2009, at 2:33 PM, Mike Stump wrote:
> On Aug 23, 2009, at 11:36 AM, Jack Howarth wrote:
>> Current llvm-gcc-4.2 for trunk and the 2.6 release
>> is unable to build the i386 multilib for the
>> x86_64-apple-darwin target. The attached patch provides
>> this support. Can we get this into the 2.6 release
>> and trunk?
>
> This is fine.  I don't have a rw llvm-gcc tree, some else want to
> check it in?  For 2.6, that's be someone else's call, for what
it's
> worth, this should be fairly safe.
I applied this as r80071.  However, I don't understand what this  
does.  I'm able to build a working i386/x86-64 compiler on darwin  
without this, what exactly does this fix?  What exactly is an "i386  
multilib" and why do we care? :)

-Chris