llvm dev - Aug 2009 - [LLVMdev] I add utf8 meta for all html documents:)

The patch is for version 77784
And it's fixed the cmake for eclipse win32 mingw makefile  output:)
Also a warning in VS 2008 on stub.c
Hope someone apply this patch.
And those files that place the
  <meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
Before <title> is just because of
in tag title may contains strange characters such as Chinese
Characters and so on:)
-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvmdoc.patch
Type: application/octet-stream
Size: 31247 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090801/7944c4e9/attachment.obj>

On Sat, Aug 1, 2009 at 7:23 AM, 罗勇刚(Yonggang Luo)<luoyonggang at
gmail.com> wrote:
> The patch is for version 77784
> And it's fixed the cmake for eclipse win32 mingw makefile  output:)
> Also a warning in VS 2008 on stub.c
> Hope someone apply this patch.
> And those files that place the
>  <meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
> Before <title> is just because of
> in tag title may contains strange characters such as Chinese
> Characters and so on:)
One issue per patch, please.

The HTML changes look fine, but please split them into a separate patch.

-  else( MSVC )
+#Support for eclipse and don't need msys or cygwin
+#It's working fine on my computer:)
+  elseif( MINGW AND WIN32 )
+	set( ${var} "i686-pc-win32" PARENT_SCOPE )
+  else ( MINGW AND WIN32 )

The most common triple for MinGW is i686-pc-mingw32, although there
any many different possibilities.  Also, comments should be complete
sentences, and should be directed at someone newly looking at the code
rather than a patch reviewer.  Someone more familiar with CMake should
also take a look at this.

Are the changes to CMakeLists.txt all whitespace changes?  Can you
explain the justification?

-  execvp(Interp, (char *const*)Args);
+  execvp(Interp, (const char *const*)Args);

What exactly is the warning here?  execvp is normally defined as follows:
    int execvp(const char *file, char *const argv[]);

-Eli

* 罗勇刚(Yonggang Luo)  <luoyonggang at gmail.com>
wrote:
> The patch is for version 77784
> And it's fixed the cmake for eclipse win32 mingw makefile  output:)
> Also a warning in VS 2008 on stub.c
> Hope someone apply this patch.
> And those files that place the
>   <meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
> Before <title> is just because of
> in tag title may contains strange characters such as Chinese
> Characters and so on:)
Why not just configure the webserver properly, to serve the page with
the appropriate header?

-- 
 Ed Schouten <ed at 80386.nl>
 WWW: http://80386.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090802/9cae0def/attachment.sig>

2009/8/2 Ed Schouten <ed at 80386.nl>:
> * 罗勇刚(Yonggang Luo)  <luoyonggang at gmail.com> wrote:
>> The patch is for version 77784
>> And it's fixed the cmake for eclipse win32 mingw makefile  output:)
>> Also a warning in VS 2008 on stub.c
>> Hope someone apply this patch.
>> And those files that place the
>>   <meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
>> Before <title> is just because of
>> in tag title may contains strange characters such as Chinese
>> Characters and so on:)
>
> Why not just configure the webserver properly, to serve the page with
> the appropriate header?
Because these files are static html files.
And so we can direct access to it on the local computer, and don't
need the webserver:)
This is much more simpler for using by those users that don't know how
to configure webserver:)
And also more simple to edit by some IDE such as eclipse wtp:)
Thanks
-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo