I just checked in my changes to bugpoint and Makefile.programs in the test suite. These changes shouldn't conflict with yours. revision 75292 revision 75293 bugpoint now works for remote ARM if you run it directly from the command line. It doesn't work correctly when invoked from the test makefile because envvar PWD is being set to /bin/pwd and so causing GCC::ExecuteProgram to do the wrong thing. I'm not sure what is going on with that, perhaps something in the makefile hierarchy is setting PWD to /bin/pwd instead of executing that command to get the pwd. I will investigate. David On Jul 10, 2009, at 1:45 PM, Viktor Kutuzov wrote:> David, > > Please find attached 2 diffs. Please notice that RemoteRunSafely.sh > may get moved to the test suite sub-tree. > > We have targeted different areas fso far which is great. > What's your plan? > > I have been thinking of using -run-custom and -safe-run-custom > argumants for the cross-tools to keep bugpoint out of knowing any > target details ans such. > > Best regards, > Viktor > > ----- Original Message ----- From: "David Goodwin" <david_goodwin at apple.com > > > To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> > Sent: Friday, July 10, 2009 1:26 PM > Subject: Re: [LLVMdev] Heads up! Working on bugpoint > > >> Hi Viktor, >> >> I did not see your patches, can you send them again. Here are the >> changes that I have made that seem to get remote execution working >> for >> bugpoint. I have not yet changed the test system to provide -remote- >> client and -remote-port. >> >> David >> >> >> > > > -------------------------------------------------------------------------------- > > >> >> >> >> >> On Jul 10, 2009, at 12:50 PM, Viktor Kutuzov wrote: >> >>> Hello David, >>> >>> I'm working on bugpoint. >>> >>> There are 2 patched out there for review that fix problems and make >>> remote execution work. >>> I'm looking at adding it to the test-suit and use make to run tests >>> remotely for cross-compilation (following Evan's suggestion). >>> >>> Let's coorddinate our effort. >>> >>> Best regards, >>> Viktor >>> >>> ----- Original Message ----- >>> From: "David Goodwin" <david_goodwin at apple.com> >>> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> >>> Sent: Friday, July 10, 2009 12:23 PM >>> Subject: [LLVMdev] Heads up! Working on bugpoint >>> >>> >>>> I'm starting work on getting bugpoint working with remote execution >>>> for arm. Is anyone else working on this? >>>> >>>> David >>>> >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> >> > > > -------------------------------------------------------------------------------- > > >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > < > makeAbsolute > .patch > ><ToolRunner.diff>_______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> I will investigate.I'm in the middle of it as well. Best regards, Viktor ----- Original Message ----- From: "David Goodwin" <david_goodwin at apple.com> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> Sent: Friday, July 10, 2009 2:43 PM Subject: Re: [LLVMdev] Heads up! Working on bugpoint>I just checked in my changes to bugpoint and Makefile.programs in the > test suite. These changes shouldn't conflict with yours. > > revision 75292 > revision 75293 > > bugpoint now works for remote ARM if you run it directly from the > command line. It doesn't work correctly when invoked from the test > makefile because envvar PWD is being set to /bin/pwd and so causing > GCC::ExecuteProgram to do the wrong thing. I'm not sure what is going > on with that, perhaps something in the makefile hierarchy is setting > PWD to /bin/pwd instead of executing that command to get the pwd. I > will investigate. > > David > > > On Jul 10, 2009, at 1:45 PM, Viktor Kutuzov wrote: > >> David, >> >> Please find attached 2 diffs. Please notice that RemoteRunSafely.sh >> may get moved to the test suite sub-tree. >> >> We have targeted different areas fso far which is great. >> What's your plan? >> >> I have been thinking of using -run-custom and -safe-run-custom >> argumants for the cross-tools to keep bugpoint out of knowing any >> target details ans such. >> >> Best regards, >> Viktor >> >> ----- Original Message ----- From: "David Goodwin" <david_goodwin at apple.com >> > >> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> >> Sent: Friday, July 10, 2009 1:26 PM >> Subject: Re: [LLVMdev] Heads up! Working on bugpoint >> >> >>> Hi Viktor, >>> >>> I did not see your patches, can you send them again. Here are the >>> changes that I have made that seem to get remote execution working >>> for >>> bugpoint. I have not yet changed the test system to provide -remote- >>> client and -remote-port. >>> >>> David >>> >>> >>> >> >> >> -------------------------------------------------------------------------------- >> >> >>> >>> >>> >>> >>> On Jul 10, 2009, at 12:50 PM, Viktor Kutuzov wrote: >>> >>>> Hello David, >>>> >>>> I'm working on bugpoint. >>>> >>>> There are 2 patched out there for review that fix problems and make >>>> remote execution work. >>>> I'm looking at adding it to the test-suit and use make to run tests >>>> remotely for cross-compilation (following Evan's suggestion). >>>> >>>> Let's coorddinate our effort. >>>> >>>> Best regards, >>>> Viktor >>>> >>>> ----- Original Message ----- >>>> From: "David Goodwin" <david_goodwin at apple.com> >>>> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> >>>> Sent: Friday, July 10, 2009 12:23 PM >>>> Subject: [LLVMdev] Heads up! Working on bugpoint >>>> >>>> >>>>> I'm starting work on getting bugpoint working with remote execution >>>>> for arm. Is anyone else working on this? >>>>> >>>>> David >>>>> >>>>> _______________________________________________ >>>>> LLVM Developers mailing list >>>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>>>> >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>> >>> >> >> >> -------------------------------------------------------------------------------- >> >> >>> _______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> < >> makeAbsolute >> .patch >> ><ToolRunner.diff>_______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >
I fixed the PWD weirdness. bugpoint now works with remote ARM from testsuite makefiles. Sending External/SPEC/Makefile.spec Sending Makefile.programs Transmitting file data .. Committed revision 75307. David On Jul 10, 2009, at 2:48 PM, Viktor Kutuzov wrote:>> I will investigate. > > I'm in the middle of it as well. > > Best regards, > Viktor > > ----- Original Message ----- > From: "David Goodwin" <david_goodwin at apple.com> > To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> > Sent: Friday, July 10, 2009 2:43 PM > Subject: Re: [LLVMdev] Heads up! Working on bugpoint > > >> I just checked in my changes to bugpoint and Makefile.programs in the >> test suite. These changes shouldn't conflict with yours. >> >> revision 75292 >> revision 75293 >> >> bugpoint now works for remote ARM if you run it directly from the >> command line. It doesn't work correctly when invoked from the test >> makefile because envvar PWD is being set to /bin/pwd and so causing >> GCC::ExecuteProgram to do the wrong thing. I'm not sure what is going >> on with that, perhaps something in the makefile hierarchy is setting >> PWD to /bin/pwd instead of executing that command to get the pwd. I >> will investigate. >> >> David >> >> >> On Jul 10, 2009, at 1:45 PM, Viktor Kutuzov wrote: >> >>> David, >>> >>> Please find attached 2 diffs. Please notice that RemoteRunSafely.sh >>> may get moved to the test suite sub-tree. >>> >>> We have targeted different areas fso far which is great. >>> What's your plan? >>> >>> I have been thinking of using -run-custom and -safe-run-custom >>> argumants for the cross-tools to keep bugpoint out of knowing any >>> target details ans such. >>> >>> Best regards, >>> Viktor >>> >>> ----- Original Message ----- From: "David Goodwin" <david_goodwin at apple.com >>>> >>> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> >>> Sent: Friday, July 10, 2009 1:26 PM >>> Subject: Re: [LLVMdev] Heads up! Working on bugpoint >>> >>> >>>> Hi Viktor, >>>> >>>> I did not see your patches, can you send them again. Here are the >>>> changes that I have made that seem to get remote execution working >>>> for >>>> bugpoint. I have not yet changed the test system to provide - >>>> remote- >>>> client and -remote-port. >>>> >>>> David >>>> >>>> >>>> >>> >>> >>> -------------------------------------------------------------------------------- >>> >>> >>>> >>>> >>>> >>>> >>>> On Jul 10, 2009, at 12:50 PM, Viktor Kutuzov wrote: >>>> >>>>> Hello David, >>>>> >>>>> I'm working on bugpoint. >>>>> >>>>> There are 2 patched out there for review that fix problems and >>>>> make >>>>> remote execution work. >>>>> I'm looking at adding it to the test-suit and use make to run >>>>> tests >>>>> remotely for cross-compilation (following Evan's suggestion). >>>>> >>>>> Let's coorddinate our effort. >>>>> >>>>> Best regards, >>>>> Viktor >>>>> >>>>> ----- Original Message ----- >>>>> From: "David Goodwin" <david_goodwin at apple.com> >>>>> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> >>>>> Sent: Friday, July 10, 2009 12:23 PM >>>>> Subject: [LLVMdev] Heads up! Working on bugpoint >>>>> >>>>> >>>>>> I'm starting work on getting bugpoint working with remote >>>>>> execution >>>>>> for arm. Is anyone else working on this? >>>>>> >>>>>> David >>>>>> >>>>>> _______________________________________________ >>>>>> LLVM Developers mailing list >>>>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>>>>> >>>>> _______________________________________________ >>>>> LLVM Developers mailing list >>>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>>> >>>> >>> >>> >>> -------------------------------------------------------------------------------- >>> >>> >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>> < >>> makeAbsolute >>> .patch >>>> <ToolRunner.diff>_______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Hello, David> bugpoint now works for remote ARM if you run it directly from the > command line. It doesn't work correctly when invoked from the test > makefile because envvar PWD is being set to /bin/pwd and so causing > GCC::ExecuteProgram to do the wrong thing. I'm not sure what is going > on with that, perhaps something in the makefile hierarchy is setting > PWD to /bin/pwd instead of executing that command to get the pwd. I > will investigate.This might be propagated from Makefile.config. I think it's better to figure out why it's propagated from there instead of hardcoding paths into testsuite. This might break mingw32, for example. -- With best regards, Anton Korobeynikov Faculty of Mathematics and Mechanics, Saint Petersburg State University
I don't think it is being propagated from anywhere. I don't thing you can rely on PWD being defined in make like you do from a shell. Other places in the makefile also explicitly need to calculate PWD using $ (shell pwd) so I don't think this usage is unusual. But looking at it some more it does seem that I might be able to use an already available variable that is calculating pwd. I give it a try. David On Jul 11, 2009, at 1:41 AM, Anton Korobeynikov wrote:> Hello, David > >> bugpoint now works for remote ARM if you run it directly from the >> command line. It doesn't work correctly when invoked from the test >> makefile because envvar PWD is being set to /bin/pwd and so causing >> GCC::ExecuteProgram to do the wrong thing. I'm not sure what is going >> on with that, perhaps something in the makefile hierarchy is setting >> PWD to /bin/pwd instead of executing that command to get the pwd. I >> will investigate. > This might be propagated from Makefile.config. I think it's better to > figure out why it's propagated from there instead of hardcoding paths > into testsuite. This might break mingw32, for example. > > -- > With best regards, Anton Korobeynikov > Faculty of Mathematics and Mechanics, Saint Petersburg State > University > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev