llvm dev - Jul 2009 - [LLVMdev] [PATCH] Fix for bugpoint -remote-client

Hello everyone,

Please find the patch attached.
This fixes the bugpoint -remote-client and adds a helper script for a remote
run.

-Viktor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ToolRunner.diff
Type: application/octet-stream
Size: 4210 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090707/ab4d4635/attachment.obj>

Thanks Viktor.

+    std::cout << "<run locally>" << std::flush;

This should use std::cerr and make sure it is wrapped inside the DEBUG  
macro.

Also, we don't want RemoteRunSafely.sh  to be under utils/bugpoint.  
Can you move it to test-suite? Are you planning to change the llvm  
test suite makefile to make use of RemoteRunSafely.sh?

Thanks,

Evan

On Jul 7, 2009, at 4:32 PM, Viktor Kutuzov wrote:
> Hello everyone,
>
> Please find the patch attached.
> This fixes the bugpoint -remote-client and adds a helper script for  
> a remote run.
>
> -Viktor
> <ToolRunner.diff>_______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

Hello Evan,

Thanks for looking at the patch.
> This should use std::cerr and make sure it is wrapped inside the DEBUG  
> macro.
Will do.
> Also, we don't want RemoteRunSafely.sh  to be under utils/bugpoint.  
> Can you move it to test-suite? Are you planning to change the llvm  
> test suite makefile to make use of RemoteRunSafely.sh?

I thought about bugpoint remote mode and the RemoteRunSafely.sh script more as a
manual tool rather than a part of the test suit.
Unless I'm missing something, getting it there will add some dependencies
which are not for a regular build system.
This is why I have placed the script under utils/bugpoint.

But it sounds like you have an idea how to do this. Would you explain your
thoughts, please?

Best regards,
Viktor

----- Original Message ----- 
From: "Evan Cheng" <evan.cheng at apple.com>
To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu>
Sent: Tuesday, July 07, 2009 6:08 PM
Subject: Re: [LLVMdev] [PATCH] Fix for bugpoint -remote-client

> Thanks Viktor.
> 
> +    std::cout << "<run locally>" <<
std::flush;
> 
> This should use std::cerr and make sure it is wrapped inside the DEBUG  
> macro.
> 
> Also, we don't want RemoteRunSafely.sh  to be under utils/bugpoint.  
> Can you move it to test-suite? Are you planning to change the llvm  
> test suite makefile to make use of RemoteRunSafely.sh?
> 
> Thanks,
> 
> Evan
> 
> On Jul 7, 2009, at 4:32 PM, Viktor Kutuzov wrote:
> 
>> Hello everyone,
>>
>> Please find the patch attached.
>> This fixes the bugpoint -remote-client and adds a helper script for  
>> a remote run.
>>
>> -Viktor
>> <ToolRunner.diff>_______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>